You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Per discussion, update the telemetry prompt to reduce redundancy, and
omit the upload date (which is not necessary for the opt-in model).
Change-Id: I7e4db24076996f40a39e9653633e3e821a688f3b
Reviewed-on: https://go-review.googlesource.com/c/tools/+/532095
Reviewed-by: Hyang-Ah Hana Kim <[email protected]>
LUCI-TryBot-Result: Go LUCI <[email protected]>
Copy file name to clipboardExpand all lines: gopls/internal/lsp/prompt.go
+6-15Lines changed: 6 additions & 15 deletions
Original file line number
Diff line number
Diff line change
@@ -198,8 +198,8 @@ Would you like to enable Go telemetry?
198
198
ifs.Options().LinkifyShowMessage {
199
199
prompt=`Go telemetry helps us improve Go by periodically sending anonymous metrics and crash reports to the Go team. Learn more at [telemetry.go.dev/privacy](https://telemetry.go.dev/privacy).
200
200
201
-
Would you like to enable Go telemetry?
202
-
`
201
+
Would you like to enable Go telemetry?
202
+
`
203
203
}
204
204
// TODO(rfindley): investigate a "tell me more" action in combination with ShowDocument.
205
205
params:=&protocol.ShowMessageRequestParams{
@@ -258,24 +258,15 @@ Would you like to enable Go telemetry?
format:=`Telemetry uploading is now enabled and may be sent to https://telemetry.go.dev starting %s. Uploaded data is used to help improve the Go toolchain and related tools, and it will be published as part of a public dataset.
263
-
264
-
For more details, see https://telemetry.go.dev/privacy.
265
-
This data is collected in accordance with the Google Privacy Policy (https://policies.google.com/privacy).
261
+
format:=`Thank you. Telemetry uploading is now enabled.
266
262
267
263
To disable telemetry uploading, run %s.
268
264
`
265
+
varrunCmd="`go run golang.org/x/telemetry/cmd/gotelemetry@latest off`"
269
266
iflinkify {
270
-
format=`Telemetry uploading is now enabled and may be sent to [telemetry.go.dev](https://telemetry.go.dev) starting %s. Uploaded data is used to help improve the Go toolchain and related tools, and it will be published as part of a public dataset.
271
-
272
-
For more details, see [telemetry.go.dev/privacy](https://telemetry.go.dev/privacy).
273
-
This data is collected in accordance with the [Google Privacy Policy](https://policies.google.com/privacy).
274
-
275
-
To disable telemetry uploading, run [%s](https://golang.org/x/telemetry/cmd/gotelemetry).
0 commit comments