godev/internal: add a content writer for http status

Added a function as a convenience for writing an http status
code response without additional content.

Change-Id: I1b9ee9d39d7ab1bb43248d0b800e5dacf2743606
Reviewed-on: https://go-review.googlesource.com/c/telemetry/+/503760
Run-TryBot: Jamal Carvalho <[email protected]>
TryBot-Result: Gopher Robot <[email protected]>
Reviewed-by: Hyang-Ah Hana Kim <[email protected]>

Author: jamalc

godev/cmd/telemetrygodev/main.go

@@ -68,7 +68,7 @@ func handleUpload(store storage.Store) content.HandlerFunc {
 			}
 			return content.Text(w, "ok", http.StatusOK)
 		}
-		return content.ErrorStatus(http.StatusMethodNotAllowed)
+		return content.Status(w, http.StatusMethodNotAllowed)
 	}
 }
 

godev/internal/content/content.go

@@ -213,14 +213,16 @@ func Text(w http.ResponseWriter, data any, code int) error {
 	return nil
 }
 
-// Error annotates an error with http status information.
-func Error(err error, code int) error {
-	return &contentError{err, code}
+// Text renders an http status code as a text response.
+func Status(w http.ResponseWriter, code int) error {
+	if code < http.StatusBadRequest {
+		return Text(w, http.StatusText(code), code)
+	}
+	return Error(errors.New(http.StatusText(code)), code)
 }
 
-// Error status returns a content error from a status code.
-func ErrorStatus(code int) error {
-	err := errors.New(http.StatusText(code))
+// Error annotates an error with http status information.
+func Error(err error, code int) error {
 	return &contentError{err, code}
 }
 

godev/internal/content/content_test.go

@@ -24,6 +24,7 @@ func TestServer_ServeHTTP(t *testing.T) {
 		Handler("/data", handleTemplate(fsys)),
 		Handler("/json", handleJSON()),
 		Handler("/text", handleText()),
+		Handler("/teapot", handleTeapot()),
 		Handler("/error", handleError()),
 	)
 
@@ -57,6 +58,11 @@ func TestServer_ServeHTTP(t *testing.T) {
 			"error.out",
 			http.StatusBadRequest,
 		},
+		{
+			"/teapot",
+			"teapot.out",
+			http.StatusTeapot,
+		},
 		{
 			"/script.ts",
 			"script.ts.out",
@@ -146,16 +152,25 @@ func handleTemplate(fsys fs.FS) HandlerFunc {
 		return Template(w, fsys, "data.html", "Data from Handler", http.StatusOK)
 	}
 }
+
 func handleJSON() HandlerFunc {
 	return func(w http.ResponseWriter, _ *http.Request) error {
 		return JSON(w, struct{ Data string }{Data: "Data"}, http.StatusOK)
 	}
 }
+
 func handleText() HandlerFunc {
 	return func(w http.ResponseWriter, _ *http.Request) error {
 		return Text(w, "Hello, World!", http.StatusOK)
 	}
 }
+
+func handleTeapot() HandlerFunc {
+	return func(w http.ResponseWriter, r *http.Request) error {
+		return Status(w, http.StatusTeapot)
+	}
+}
+
 func handleError() HandlerFunc {
 	return func(w http.ResponseWriter, r *http.Request) error {
 		return Error(errors.New("Bad Request"), http.StatusBadRequest)

godev/internal/content/testdata/teapot.out

@@ -0,0 +1 @@
+I'm a teapot