-
Notifications
You must be signed in to change notification settings - Fork 589
windows: add CTRL_CLOSE_EVENT, CTRL_LOGOFF_EVENT, and CTRL_SHUTDOWN_EVENT #37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…VENT This is part of the changes necessary to allow simulated `SIGTERM` on Windows (these are the relevant events for `SetConsoleCtrlHandler` that would correspond to `SIGTERM` on Unix). See https://docs.microsoft.com/en-us/windows/console/handlerroutine for a good documentation source upstream to confirm these values. Updates golang/go#7479
This PR (HEAD: 7db84d6) has been imported to Gerrit for code review. Please visit https://go-review.googlesource.com/c/sys/+/187578 to see it. Tip: You can toggle comments from me using the |
Message from Gobot Gobot: Patch Set 1: Congratulations on opening your first change. Thank you for your contribution! Next steps: Most changes in the Go project go through a few rounds of revision. This can be During May-July and Nov-Jan the Go project is in a code freeze, during which Please don’t reply on this GitHub thread. Visit golang.org/cl/187578. |
Message from Alex Brainman: Patch Set 1: Run-TryBot+1 Code-Review+2 LGTM Thank you. Alex Please don’t reply on this GitHub thread. Visit golang.org/cl/187578. |
Message from Gobot Gobot: Patch Set 1: TryBots beginning. Status page: https://farmer.golang.org/try?commit=2824e855 Please don’t reply on this GitHub thread. Visit golang.org/cl/187578. |
…VENT This is part of the changes necessary to allow simulated `SIGTERM` on Windows (these are the relevant events for `SetConsoleCtrlHandler` that would correspond to `SIGTERM` on Unix). See https://docs.microsoft.com/en-us/windows/console/handlerroutine for a good documentation source upstream to confirm these values. Updates golang/go#7479 (This exists under `src/cmd/vendor/golang.org/x/sys/windows/types_windows.go` in https://github.com/golang/go, so I figured I would start here and follow up with a https://github.com/golang/go PR/CL if reviewers here were amenable to this half.) Change-Id: If3d0175bb889e4eddca838ef765faf5e379285ea GitHub-Last-Rev: 7db84d6 GitHub-Pull-Request: #37 Reviewed-on: https://go-review.googlesource.com/c/sys/+/187578 Reviewed-by: Alex Brainman <[email protected]> Run-TryBot: Alex Brainman <[email protected]> TryBot-Result: Gobot Gobot <[email protected]>
Message from Gobot Gobot: Patch Set 1: TryBot-Result+1 TryBots are happy. Please don’t reply on this GitHub thread. Visit golang.org/cl/187578. |
This PR is being closed because golang.org/cl/187578 has been merged. |
This is part of the changes necessary to allow simulated
SIGTERM
on Windows (these are the relevant events forSetConsoleCtrlHandler
that would correspond toSIGTERM
on Unix).See https://docs.microsoft.com/en-us/windows/console/handlerroutine for a good documentation source upstream to confirm these values.
Updates golang/go#7479
(This exists under
src/cmd/vendor/golang.org/x/sys/windows/types_windows.go
in https://github.com/golang/go, so I figured I would start here and follow up with a https://github.com/golang/go PR/CL if reviewers here were amenable to this half.)