Skip to content

unix: fix unused import in syscall_darwin_386.go #26

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

unix: fix unused import in syscall_darwin_386.go #26

wants to merge 1 commit into from

Conversation

itchyny
Copy link
Contributor

@itchyny itchyny commented Dec 21, 2018

Fix a compile error due to unused import introduced by CL 154663.

@gopherbot
Copy link
Contributor

This PR (HEAD: 3033ecc) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/sys/+/155460 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot
Copy link
Contributor

Message from Gobot Gobot:

Patch Set 1:

Congratulations on opening your first change. Thank you for your contribution!

Next steps:
Within the next week or so, a maintainer will review your change and provide
feedback. See https://golang.org/doc/contribute.html#review for more info and
tips to get your patch through code review.

Most changes in the Go project go through a few rounds of revision. This can be
surprising to people new to the project. The careful, iterative review process
is our way of helping mentor contributors and ensuring that their contributions
have a lasting impact.

During May-July and Nov-Jan the Go project is in a code freeze, during which
little code gets reviewed or merged. If a reviewer responds with a comment like
R=go1.11, it means that this CL will be reviewed as part of the next development
cycle. See https://golang.org/s/release for more details.


Please don’t reply on this GitHub thread. Visit golang.org/cl/155460.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

This PR (HEAD: 5c7065d) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/sys/+/155460 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@itchyny itchyny changed the title fix unused import in syscall_darwin_386.go unix: fix unused import in syscall_darwin_386.go Dec 21, 2018
@gopherbot
Copy link
Contributor

Message from Tobias Klauser:

Patch Set 3:

(2 comments)


Please don’t reply on this GitHub thread. Visit golang.org/cl/155460.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Tobias Klauser:

Patch Set 4: Run-TryBot+1 Code-Review+2

Thanks


Please don’t reply on this GitHub thread. Visit golang.org/cl/155460.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Gobot Gobot:

Patch Set 4:

TryBots beginning. Status page: https://farmer.golang.org/try?commit=3f4aa6a9


Please don’t reply on this GitHub thread. Visit golang.org/cl/155460.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Gobot Gobot:

Patch Set 4: TryBot-Result+1

TryBots are happy.


Please don’t reply on this GitHub thread. Visit golang.org/cl/155460.
After addressing review feedback, remember to publish your drafts!

gopherbot pushed a commit that referenced this pull request Dec 21, 2018
Fix a compile error due to unused import introduced by CL 154663.

Change-Id: I2a732380c35cd98dfff36289f5d72fd7d7222205
GitHub-Last-Rev: 5c7065d
GitHub-Pull-Request: #26
Reviewed-on: https://go-review.googlesource.com/c/155460
Reviewed-by: Tobias Klauser <[email protected]>
Run-TryBot: Tobias Klauser <[email protected]>
TryBot-Result: Gobot Gobot <[email protected]>
@gopherbot
Copy link
Contributor

This PR is being closed because golang.org/cl/155460 has been merged.

@gopherbot gopherbot closed this Dec 21, 2018
@itchyny itchyny deleted the fix-unused-import-unix-syscall-darwin-386 branch December 21, 2018 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants