Skip to content

Generate field_mask.proto WKT. #227

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Conversation

tswast
Copy link
Contributor

@tswast tswast commented Sep 2, 2016

Upstream change is protocolbuffers/protobuf#2058.

Fixes #226.

@dsymonds
Copy link
Contributor

dsymonds commented Sep 2, 2016

That doesn't look like the right output filename.

@tswast
Copy link
Contributor Author

tswast commented Sep 2, 2016

Oops. Yep, you're right. Fixed now.

@zombiezen
Copy link
Contributor

Note that FieldMask already exists in google.golang.org/genproto/protobuf. See also #218.

@tswast
Copy link
Contributor Author

tswast commented Sep 6, 2016

@zombiezen Thanks for pointing that out. I'll read through that discussion. Possibly I'll need to change my upstream change to point to the genproto package name.

@tswast tswast closed this Sep 6, 2016
@golang golang locked and limited conversation to collaborators Jun 26, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

FieldMask is missing from ptypes directory.
3 participants