Skip to content

nokiehealth: add endpoint for Nokia Health Mate #315

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

nokiehealth: add endpoint for Nokia Health Mate #315

wants to merge 2 commits into from

Conversation

jrmycanady
Copy link
Contributor

No description provided.

@gopherbot
Copy link
Contributor

Message from Gerrit User 5976:

Patch Set 1:

Congratulations on opening your first change. Thank you for your contribution!

Next steps:
Within the next week or so, a maintainer will review your change and provide
feedback. See https://golang.org/doc/contribute.html#review for more info and
tips to get your patch through code review.

Most changes in the Go project go through a few rounds of revision. This can be
surprising to people new to the project. The careful, iterative review process
is our way of helping mentor contributors and ensuring that their contributions
have a lasting impact.

During May-July and Nov-Jan the Go project is in a code freeze, during which
little code gets reviewed or merged. If a reviewer responds with a comment like
R=go1.11, it means that this CL will be reviewed as part of the next development
cycle. See https://golang.org/s/release for more details.

Please don’t reply on this GitHub thread. Visit golang.org/cl/130477.
After addressing review feedback, remember to publish your drafts!

@bradfitz bradfitz changed the title adds support for the nokia health mate api nokiehealth: add endpoint for Nokia Health Mate Aug 21, 2018
@gopherbot
Copy link
Contributor

Message from Gerrit User 12446:

Uploaded patch set 2: Commit message was updated.

Please don’t reply on this GitHub thread. Visit golang.org/cl/130477.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Gerrit User 5065:

Patch Set 2:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/130477.
After addressing review feedback, remember to publish your drafts!

gopherbot pushed a commit that referenced this pull request Aug 21, 2018
@jrmycanady @bradfitz
nokiehealth: add endpoint for Nokia Health Mate
d2e6202 
Change-Id: I4fdc7be10d1e10c188889aa149fd5019a7c062bd
GitHub-Last-Rev: 6fbdac8
GitHub-Pull-Request: #315
Reviewed-on: https://go-review.googlesource.com/130477
Reviewed-by: Brad Fitzpatrick <[email protected]>
@gopherbot
Copy link
Contributor

This PR is being closed because golang.org/cl/130477 has been merged.

@gopherbot gopherbot closed this Aug 21, 2018
dmitriyminer pushed a commit to dmitriyminer/oauth2 that referenced this pull request Sep 27, 2018
@jrmycanady @dmitriyminer
nokiehealth: add endpoint for Nokia Health Mate
d268dbf 
Change-Id: I4fdc7be10d1e10c188889aa149fd5019a7c062bd
GitHub-Last-Rev: 6fbdac8
GitHub-Pull-Request: golang#315
Reviewed-on: https://go-review.googlesource.com/130477
Reviewed-by: Brad Fitzpatrick <[email protected]>

Add Scope specifies optional requested permissions for tokenRefresher

Some OAuth providers require "scope" value with "refresh_token" grant type

Update test TestTokenRefreshRequest
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jrmycanady @gopherbot @googlebot