Skip to content

appengine build tag is not set in new go111 runtime #334

Closed
@mtraver

Description

@mtraver

App Engine just launched a new Go 1.11 runtime. The go111 runtime uses the stock Go toolchain and does not set the appengine build tag.

I encountered this when using AppEngineTokenSource, which panicked because appengine_hook.go wasn't built. Does this code need to be behind a build tag? If someone tries to use App Engine specific features when not on App Engine failure should be expected.

cc @sbuss, lead on go111 runtime

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions