Skip to content

nettest: log more details about err for checkForTimeoutError #132

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

nettest: log more details about err for checkForTimeoutError #132

wants to merge 1 commit into from

Conversation

ZekeLu
Copy link
Contributor

@ZekeLu ZekeLu commented May 14, 2022

@gopherbot
Copy link
Contributor

This PR (HEAD: bdccfc3) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/net/+/406435 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot
Copy link
Contributor

Message from Bryan Mills:

Patch Set 1: Run-TryBot+1 Auto-Submit+1 Code-Review+2

Please don’t reply on this GitHub thread. Visit golang.org/cl/406435.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Gopher Robot:

Patch Set 1:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/406435.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Gopher Robot:

Patch Set 1: TryBot-Result+1

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/406435.
After addressing review feedback, remember to publish your drafts!

gopherbot pushed a commit that referenced this pull request May 16, 2022
@ZekeLu @gopherbot
nettest: log more details about err for checkForTimeoutError
20f9603 
For golang/go#52893

Change-Id: I2897c3f22b670af0aa2df1edbc9bbebdf1bafe59
GitHub-Last-Rev: bdccfc3
GitHub-Pull-Request: #132
Reviewed-on: https://go-review.googlesource.com/c/net/+/406435
Run-TryBot: Bryan Mills <[email protected]>
Reviewed-by: Damien Neil <[email protected]>
Auto-Submit: Bryan Mills <[email protected]>
TryBot-Result: Gopher Robot <[email protected]>
Reviewed-by: Bryan Mills <[email protected]>
@gopherbot
Copy link
Contributor

This PR is being closed because golang.org/cl/406435 has been merged.

@gopherbot gopherbot closed this May 16, 2022
@ZekeLu ZekeLu deleted the err-details branch October 24, 2022 05:11
WeiminShang added a commit to WeiminShang/net that referenced this pull request Nov 16, 2022
@WeiminShang @gopherbot
nettest: log more details about err for checkForTimeoutError
314f518 
For golang/go#52893

Change-Id: I2897c3f22b670af0aa2df1edbc9bbebdf1bafe59
GitHub-Last-Rev: bdccfc34beedc504a7ab4b3e903f1e09753ff85f
GitHub-Pull-Request: golang/net#132
Reviewed-on: https://go-review.googlesource.com/c/net/+/406435
Run-TryBot: Bryan Mills <[email protected]>
Reviewed-by: Damien Neil <[email protected]>
Auto-Submit: Bryan Mills <[email protected]>
TryBot-Result: Gopher Robot <[email protected]>
Reviewed-by: Bryan Mills <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ZekeLu @gopherbot