Skip to content

Commit 89adc90

Browse files
committed
http2: fix typo referring to RFC 9218 as RFC 9128 instead
In go.dev/cl/704758, I accidentally typed RFC 9128 rather than 9218. This changes fixes all such typo. For go/golang#75500 Change-Id: I61c3008a85ca0ca0e9f58315cb5eb20cd82fb9f9 Reviewed-on: https://go-review.googlesource.com/c/net/+/714740 Reviewed-by: Damien Neil <[email protected]> Reviewed-by: Nicholas Husin <[email protected]> LUCI-TryBot-Result: Go LUCI <[email protected]>
1 parent 8d76a2c commit 89adc90

File tree

3 files changed

+9
-9
lines changed

3 files changed

+9
-9
lines changed

http2/writesched_benchmarks_test.go

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -152,28 +152,28 @@ func BenchmarkWriteSchedulerLifetimePriorityRFC7540(b *testing.B) {
152152
}
153153

154154
func BenchmarkWriteSchedulerThroughputPriorityRFC9218Incremental(b *testing.B) {
155-
benchmarkThroughput(b, newPriorityWriteSchedulerRFC9128, PriorityParam{
155+
benchmarkThroughput(b, newPriorityWriteSchedulerRFC9218, PriorityParam{
156156
urgency: defaultRFC9218Priority.urgency,
157157
incremental: 1,
158158
})
159159
}
160160

161161
func BenchmarkWriteSchedulerLifetimePriorityRFC9218Incremental(b *testing.B) {
162-
benchmarkStreamLifetime(b, newPriorityWriteSchedulerRFC9128, PriorityParam{
162+
benchmarkStreamLifetime(b, newPriorityWriteSchedulerRFC9218, PriorityParam{
163163
urgency: defaultRFC9218Priority.urgency,
164164
incremental: 1,
165165
})
166166
}
167167

168168
func BenchmarkWriteSchedulerThroughputPriorityRFC9218NonIncremental(b *testing.B) {
169-
benchmarkThroughput(b, newPriorityWriteSchedulerRFC9128, PriorityParam{
169+
benchmarkThroughput(b, newPriorityWriteSchedulerRFC9218, PriorityParam{
170170
urgency: defaultRFC9218Priority.urgency,
171171
incremental: 0,
172172
})
173173
}
174174

175175
func BenchmarkWriteSchedulerLifetimePriorityRFC9218NonIncremental(b *testing.B) {
176-
benchmarkStreamLifetime(b, newPriorityWriteSchedulerRFC9128, PriorityParam{
176+
benchmarkStreamLifetime(b, newPriorityWriteSchedulerRFC9218, PriorityParam{
177177
urgency: defaultRFC9218Priority.urgency,
178178
incremental: 0,
179179
})

http2/writesched_priority_rfc9128.go renamed to http2/writesched_priority_rfc9218.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,7 @@ type priorityWriteSchedulerRFC9218 struct {
3939
prioritizeIncremental bool
4040
}
4141

42-
func newPriorityWriteSchedulerRFC9128() WriteScheduler {
42+
func newPriorityWriteSchedulerRFC9218() WriteScheduler {
4343
ws := &priorityWriteSchedulerRFC9218{
4444
streams: make(map[uint32]streamMetadata),
4545
}

http2/writesched_priority_rfc9128_test.go renamed to http2/writesched_priority_rfc9218_test.go

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ import (
1212
func TestPrioritySchedulerUrgency(t *testing.T) {
1313
const maxFrameSize = 16
1414
sc := &serverConn{maxFrameSize: maxFrameSize}
15-
ws := newPriorityWriteSchedulerRFC9128()
15+
ws := newPriorityWriteSchedulerRFC9218()
1616
streams := make([]*stream, 5)
1717
for i := range streams {
1818
streamID := uint32(i) + 1
@@ -83,7 +83,7 @@ func TestPrioritySchedulerUrgency(t *testing.T) {
8383
func TestPrioritySchedulerIncremental(t *testing.T) {
8484
const maxFrameSize = 16
8585
sc := &serverConn{maxFrameSize: maxFrameSize}
86-
ws := newPriorityWriteSchedulerRFC9128()
86+
ws := newPriorityWriteSchedulerRFC9218()
8787
streams := make([]*stream, 5)
8888
for i := range streams {
8989
streamID := uint32(i) + 1
@@ -160,7 +160,7 @@ func TestPrioritySchedulerIncremental(t *testing.T) {
160160
func TestPrioritySchedulerUrgencyAndIncremental(t *testing.T) {
161161
const maxFrameSize = 16
162162
sc := &serverConn{maxFrameSize: maxFrameSize}
163-
ws := newPriorityWriteSchedulerRFC9128()
163+
ws := newPriorityWriteSchedulerRFC9218()
164164
streams := make([]*stream, 6)
165165
for i := range streams {
166166
streamID := uint32(i) + 1
@@ -239,7 +239,7 @@ func TestPrioritySchedulerUrgencyAndIncremental(t *testing.T) {
239239
func TestPrioritySchedulerIdempotentUpdate(t *testing.T) {
240240
const maxFrameSize = 16
241241
sc := &serverConn{maxFrameSize: maxFrameSize}
242-
ws := newPriorityWriteSchedulerRFC9128()
242+
ws := newPriorityWriteSchedulerRFC9218()
243243
streams := make([]*stream, 6)
244244
for i := range streams {
245245
streamID := uint32(i) + 1

0 commit comments

Comments
 (0)