Skip to content

Commit 6e87631

Browse files
fraenkeldmitshur
authored andcommitted
[internal-branch.go1.16-vendor] http2: remove PingTimeout from TestTransportPingWhenReading
Use the default PingTimeout since it has no bearing on the test. A small value can cause a failure on slower machines. Rely on the deadline to determine a sufficient amount of time to complete. Updates golang/go#49076 Change-Id: I9389777fa00ed5193f1fc7ae04d2e2134114c675 Reviewed-on: https://go-review.googlesource.com/c/net/+/352970 Reviewed-by: Bryan C. Mills <[email protected]> Trust: Bryan C. Mills <[email protected]> Trust: Brad Fitzpatrick <[email protected]> Run-TryBot: Bryan C. Mills <[email protected]> TryBot-Result: Go Bot <[email protected]> Reviewed-on: https://go-review.googlesource.com/c/net/+/356987 Trust: Damien Neil <[email protected]> Run-TryBot: Damien Neil <[email protected]> Reviewed-by: Dmitri Shuralyov <[email protected]>
1 parent b843c7d commit 6e87631

File tree

1 file changed

+0
-1
lines changed

1 file changed

+0
-1
lines changed

http2/transport_test.go

-1
Original file line numberDiff line numberDiff line change
@@ -3437,7 +3437,6 @@ func TestTransportPingWhenReading(t *testing.T) {
34373437
func testTransportPingWhenReading(t *testing.T, readIdleTimeout, deadline time.Duration, expectedPingCount int) {
34383438
var pingCount int
34393439
ct := newClientTester(t)
3440-
ct.tr.PingTimeout = 10 * time.Millisecond
34413440
ct.tr.ReadIdleTimeout = readIdleTimeout
34423441

34433442
ctx, cancel := context.WithTimeout(context.Background(), deadline)

0 commit comments

Comments
 (0)