Skip to content

Commit 1ed2336

Browse files
committed
http2: use ASCII space trimming for parsing Trailer header
Security hardening against HTTP request smuggling recommended by an external reporter. Change-Id: I58cba9aa508eca1ae83c3bcf33858b7ba06ca583 Reviewed-on: https://go-review.googlesource.com/c/net/+/231437 Reviewed-by: Brad Fitzpatrick <[email protected]>
1 parent e0ff5e5 commit 1ed2336

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

http2/server.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2058,7 +2058,7 @@ func (sc *serverConn) newWriterAndRequestNoBody(st *stream, rp requestParam) (*r
20582058
var trailer http.Header
20592059
for _, v := range rp.header["Trailer"] {
20602060
for _, key := range strings.Split(v, ",") {
2061-
key = http.CanonicalHeaderKey(strings.TrimSpace(key))
2061+
key = http.CanonicalHeaderKey(textproto.TrimString(key))
20622062
switch key {
20632063
case "Transfer-Encoding", "Trailer", "Content-Length":
20642064
// Bogus. (copy of http1 rules)

0 commit comments

Comments
 (0)