This repository was archived by the owner on Jun 27, 2023. It is now read-only.
retain ordering of expected calls #107
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While writing tests for a stateful object, I noticed unexpected behavior where the mock would use the 1st call, but then the 3rd expected call before the 2nd ([1,3,2]). Since our tests all used the `gomock.Any()` function param, there was no ordering that could be detected by the matching without chaining all calls with `After()`.
|
@natebrennand It occurred to me after merging this that I should have asked for a unit test for this. I don't have any more leverage but I would appreciate it if you would write one. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While writing tests for a stateful object, I noticed unexpected behavior
where the mock would use the 1st call, but then the 3rd expected call
before the 2nd (called in [1,3,2]).
Since our tests all used the
gomock.Any()function param, there was noordering that could be detected by the matching without chaining all
calls with
After().