This repository was archived by the owner on Jun 27, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 609
Fix variadic mock for gomock.Any() . fix #68 #101
Merged
balshetzer
merged 5 commits into
golang:master
from
hori-ryota:feature/fix-variadic-mock
Oct 1, 2017
Merged
Fix variadic mock for gomock.Any() . fix #68 #101
balshetzer
merged 5 commits into
golang:master
from
hori-ryota:feature/fix-variadic-mock
Oct 1, 2017
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sorry, broke other tests. I'll fix. |
fixed. |
@balshetzer how about this? |
fmm... |
Hi. This change is good but I wanted to clean it up a bit. The first error message is not the same as the others, for example. |
OK. Is something better for me to do? |
@balshetzer Can I fix it? Let me know what you want to fix and I will try! |
@hori-ryota The only mandatory thing I want fixed is for the error message on line 203 to be clearer. It should be similar to the other error messages. Some nice to have improvements:
|
How about my refactor? |
Thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please see #68 .