-
Notifications
You must be signed in to change notification settings - Fork 18.1k
cmd/compile: determine static values of len and cap in make() calls #71693
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cmd/compile: determine static values of len and cap in make() calls #71693
Conversation
Change-Id: I70bd8d4961f12cb16cfd94650ac7ff8e4243163b
This PR (HEAD: 3e4916f) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/go/+/649035. Important tips:
|
Message from Gopher Robot: Patch Set 1: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/649035. |
Change-Id: If229448904be3f8fe4a013cba2f74856b0e79f60
Message from Mateusz Poliwczak: Patch Set 1: Commit-Queue+1 (2 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/649035. |
Message from Go LUCI: Patch Set 1: Dry run: CV is trying the patch. Bot data: {"action":"start","triggered_at":"2025-02-12T18:47:06Z","revision":"0c753a000d5b795bcb28b602e334bc7397cc3978"} Please don’t reply on this GitHub thread. Visit golang.org/cl/649035. |
Message from Mateusz Poliwczak: Patch Set 1: -Commit-Queue Please don’t reply on this GitHub thread. Visit golang.org/cl/649035. |
Message from Go LUCI: Patch Set 1: This CL has failed the run. Reason: Tryjob golang/try/gotip-linux-amd64-boringcrypto has failed with summary (view all results):
Build or test failure, click here for results. To reproduce, try Additional links for debugging:
Please don’t reply on this GitHub thread. Visit golang.org/cl/649035. |
Message from Go LUCI: Patch Set 1: LUCI-TryBot-Result-1 Please don’t reply on this GitHub thread. Visit golang.org/cl/649035. |
This PR (HEAD: a6e512c) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/go/+/649035. Important tips:
|
Change-Id: I687b2ac63a61b82561013b87f0b9d0c37c640719
This PR (HEAD: e42e793) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/go/+/649035. Important tips:
|
Message from Mateusz Poliwczak: Patch Set 3: Commit-Queue+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/649035. |
Message from Go LUCI: Patch Set 3: Dry run: CV is trying the patch. Bot data: {"action":"start","triggered_at":"2025-02-12T19:21:20Z","revision":"32ce04757ef752bb904b8c39808a3684b8a9f5f6"} Please don’t reply on this GitHub thread. Visit golang.org/cl/649035. |
Message from Mateusz Poliwczak: Patch Set 3: -Commit-Queue Please don’t reply on this GitHub thread. Visit golang.org/cl/649035. |
Message from Go LUCI: Patch Set 3: This CL has passed the run Please don’t reply on this GitHub thread. Visit golang.org/cl/649035. |
Message from Go LUCI: Patch Set 3: LUCI-TryBot-Result+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/649035. |
Message from Alan Donovan: Patch Set 3: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/649035. |
Message from Mateusz Poliwczak: Patch Set 4: Commit-Queue+1 (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/649035. |
Message from Go LUCI: Patch Set 4: Dry run: CV is trying the patch. Bot data: {"action":"start","triggered_at":"2025-02-12T19:51:36Z","revision":"a418d8d279935c9742e59c8cd37c922fb2a07048"} Please don’t reply on this GitHub thread. Visit golang.org/cl/649035. |
Message from Mateusz Poliwczak: Patch Set 4: -Commit-Queue Please don’t reply on this GitHub thread. Visit golang.org/cl/649035. |
Message from Go LUCI: Patch Set 4: This CL has passed the run Please don’t reply on this GitHub thread. Visit golang.org/cl/649035. |
Message from Go LUCI: Patch Set 4: LUCI-TryBot-Result+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/649035. |
Message from Keith Randall: Patch Set 4: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/649035. |
This PR (HEAD: 1bacc01) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/go/+/649035. Important tips:
|
Message from Mateusz Poliwczak: Patch Set 5: Commit-Queue+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/649035. |
Message from Go LUCI: Patch Set 5: Dry run: CV is trying the patch. Bot data: {"action":"start","triggered_at":"2025-02-13T07:29:09Z","revision":"e21a122b584578b28d5e9f84839c8d6b5900451c"} Please don’t reply on this GitHub thread. Visit golang.org/cl/649035. |
Message from Mateusz Poliwczak: Patch Set 5: -Commit-Queue Please don’t reply on this GitHub thread. Visit golang.org/cl/649035. |
Message from Go LUCI: Patch Set 5: This CL has failed the run. Reason: Tryjob golang/try/gotip-linux-amd64-misccompile has failed with summary (view all results):
Error:
Additional links for debugging:
Please don’t reply on this GitHub thread. Visit golang.org/cl/649035. |
Message from Mateusz Poliwczak: Patch Set 5: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/649035. |
Message from Mateusz Poliwczak: Patch Set 5: Commit-Queue+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/649035. |
Message from Go LUCI: Patch Set 5: Dry run: CV is trying the patch. Bot data: {"action":"start","triggered_at":"2025-02-14T06:44:56Z","revision":"e21a122b584578b28d5e9f84839c8d6b5900451c"} Please don’t reply on this GitHub thread. Visit golang.org/cl/649035. |
Message from Mateusz Poliwczak: Patch Set 5: -Commit-Queue Please don’t reply on this GitHub thread. Visit golang.org/cl/649035. |
Message from Go LUCI: Patch Set 5: This CL has passed the run Please don’t reply on this GitHub thread. Visit golang.org/cl/649035. |
Message from Go LUCI: Patch Set 5: LUCI-TryBot-Result+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/649035. |
Message from Keith Randall: Patch Set 5: (3 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/649035. |
Message from Keith Randall: Patch Set 5: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/649035. |
Change-Id: I6175d154af235a31dd1c985827b99bdd7c0ac993
This PR (HEAD: e5847b2) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/go/+/649035. Important tips:
|
Message from Mateusz Poliwczak: Patch Set 6: Commit-Queue+1 (3 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/649035. |
Message from Go LUCI: Patch Set 6: Dry run: CV is trying the patch. Bot data: {"action":"start","triggered_at":"2025-02-17T10:16:33Z","revision":"d09b981820d5aac045df68ed1bf9e66678a013a8"} Please don’t reply on this GitHub thread. Visit golang.org/cl/649035. |
Message from Mateusz Poliwczak: Patch Set 6: -Commit-Queue Please don’t reply on this GitHub thread. Visit golang.org/cl/649035. |
Message from Go LUCI: Patch Set 6: This CL has failed the run. Reason: Tryjob golang/try/gotip-linux-amd64-typesalias has failed with summary (view all results):
Build or test failure, click here for results. To reproduce, try Additional links for debugging: Please don’t reply on this GitHub thread. Visit golang.org/cl/649035. |
Message from Go LUCI: Patch Set 6: LUCI-TryBot-Result-1 Please don’t reply on this GitHub thread. Visit golang.org/cl/649035. |
Change-Id: I2f845692852ecc65db21ac2160123b72fdcf4892
This PR (HEAD: d78c1b4) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/go/+/649035. Important tips:
|
Message from Mateusz Poliwczak: Patch Set 7: Commit-Queue+1 (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/649035. |
Message from Go LUCI: Patch Set 7: Dry run: CV is trying the patch. Bot data: {"action":"start","triggered_at":"2025-02-17T11:31:06Z","revision":"9400398c46cfee6ad8372d52eb580d58a45f6ed0"} Please don’t reply on this GitHub thread. Visit golang.org/cl/649035. |
Message from Mateusz Poliwczak: Patch Set 7: -Commit-Queue Please don’t reply on this GitHub thread. Visit golang.org/cl/649035. |
Message from Go LUCI: Patch Set 7: This CL has passed the run Please don’t reply on this GitHub thread. Visit golang.org/cl/649035. |
Message from Go LUCI: Patch Set 7: LUCI-TryBot-Result+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/649035. |
Message from Jorropo: Patch Set 7: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/649035. |
Message from Jorropo: Patch Set 7: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/649035. |
Message from Keith Randall: Patch Set 7: Auto-Submit+1 Code-Review+2 (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/649035. |
Message from Keith Randall: Patch Set 7: Code-Review+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/649035. |
This change improves escape analysis by attempting to deduce static values for the len and cap parameters, allowing allocations to be made on the stack. Change-Id: I1161019aed9f60cf2c2fe4d405da94ad415231ac GitHub-Last-Rev: d78c1b4 GitHub-Pull-Request: #71693 Reviewed-on: https://go-review.googlesource.com/c/go/+/649035 LUCI-TryBot-Result: Go LUCI <[email protected]> Reviewed-by: Michael Knyszek <[email protected]> Reviewed-by: Keith Randall <[email protected]> Auto-Submit: Keith Randall <[email protected]> Reviewed-by: Keith Randall <[email protected]>
This PR is being closed because golang.org/cl/649035 has been merged. |
This change improves escape analysis by attempting to deduce static values for the len and cap parameters, allowing allocations to be made on the stack. Change-Id: I1161019aed9f60cf2c2fe4d405da94ad415231ac GitHub-Last-Rev: d78c1b4ca55fa53282e665009f689d0b013f1434 GitHub-Pull-Request: golang/go#71693 Reviewed-on: https://go-review.googlesource.com/c/go/+/649035 LUCI-TryBot-Result: Go LUCI <[email protected]> Reviewed-by: Michael Knyszek <[email protected]> Reviewed-by: Keith Randall <[email protected]> Auto-Submit: Keith Randall <[email protected]> Reviewed-by: Keith Randall <[email protected]>
This change improves escape analysis by attempting to
deduce static values for the len and cap parameters,
allowing allocations to be made on the stack.