-
Notifications
You must be signed in to change notification settings - Fork 18.3k
cmd/compile/internal/gc: handle errors from *bio.Writer #71621
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cmd/compile/internal/gc: handle errors from *bio.Writer #71621
Conversation
Change-Id: I425b5d16149a7a40d888a1ab723b3642eb08224f
This PR (HEAD: a5d3622) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/go/+/647915. Important tips:
|
Message from Gopher Robot: Patch Set 1: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/647915. |
Message from Mateusz Poliwczak: Patch Set 2: Commit-Queue+1 (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/647915. |
Message from Go LUCI: Patch Set 2: Dry run: CV is trying the patch. Bot data: {"action":"start","triggered_at":"2025-02-08T14:02:57Z","revision":"1b75be157cd1099a523c6eb65d0be2575750546c"} Please don’t reply on this GitHub thread. Visit golang.org/cl/647915. |
Message from Mateusz Poliwczak: Patch Set 2: -Commit-Queue Please don’t reply on this GitHub thread. Visit golang.org/cl/647915. |
Message from Go LUCI: Patch Set 2: This CL has passed the run Please don’t reply on this GitHub thread. Visit golang.org/cl/647915. |
Message from Go LUCI: Patch Set 2: LUCI-TryBot-Result+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/647915. |
Message from Keith Randall: Patch Set 2: Auto-Submit+1 Code-Review+2 Please don’t reply on this GitHub thread. Visit golang.org/cl/647915. |
Message from Keith Randall: Patch Set 2: Code-Review+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/647915. |
The error is stored internally in *bio.Writer, more specifically in *bufio.Writer and the current code does not handle it, ignoring errors silently. Change-Id: Iefa9bf7ddabb3c4fc03377e676a8098dcad9be6d GitHub-Last-Rev: a5d3622 GitHub-Pull-Request: #71621 Reviewed-on: https://go-review.googlesource.com/c/go/+/647915 Reviewed-by: Keith Randall <[email protected]> LUCI-TryBot-Result: Go LUCI <[email protected]> Reviewed-by: Keith Randall <[email protected]> Reviewed-by: Dmitri Shuralyov <[email protected]> Auto-Submit: Keith Randall <[email protected]>
This PR is being closed because golang.org/cl/647915 has been merged. |
The error is stored internally in *bio.Writer, more specifically in *bufio.Writer and the current code does not handle it, ignoring errors silently. Change-Id: Iefa9bf7ddabb3c4fc03377e676a8098dcad9be6d GitHub-Last-Rev: a5d36223312773039c37bb1c52fffc96fff04fba GitHub-Pull-Request: golang/go#71621 Reviewed-on: https://go-review.googlesource.com/c/go/+/647915 Reviewed-by: Keith Randall <[email protected]> LUCI-TryBot-Result: Go LUCI <[email protected]> Reviewed-by: Keith Randall <[email protected]> Reviewed-by: Dmitri Shuralyov <[email protected]> Auto-Submit: Keith Randall <[email protected]>
The error is stored internally in *bio.Writer, more specifically
in *bufio.Writer and the current code does not handle it, ignoring
errors silently.