-
Notifications
You must be signed in to change notification settings - Fork 18k
go/types, types2: ensure deterministic output when reporting an init cycle #71264
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This PR (HEAD: cc69654) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/go/+/642396. Important tips:
|
Message from Gopher Robot: Patch Set 1: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/642396. |
Message from Shengwei Zhao: Patch Set 1: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/642396. |
This PR (HEAD: c061e6f) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/go/+/642396. Important tips:
|
This PR (HEAD: 8c49d8f) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/go/+/642396. Important tips:
|
Message from Robert Findley: Patch Set 4: (2 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/642396. |
reportCycle
has a deterministic outputreportCycle
has a deterministic output
Message from Alan Donovan: Patch Set 4: (3 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/642396. |
This PR (HEAD: f4404dc) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/go/+/642396. Important tips:
|
This PR (HEAD: eb16b9b) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/go/+/642396. Important tips:
|
Message from Robert Findley: Patch Set 6: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/642396. |
Message from Shengwei Zhao: Patch Set 6: (4 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/642396. |
This PR (HEAD: 04de0fb) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/go/+/642396. Important tips:
|
Message from Robert Findley: Patch Set 6: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/642396. |
Message from Shengwei Zhao: Patch Set 7: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/642396. |
Message from Mateusz Poliwczak: Patch Set 7: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/642396. |
Message from Shengwei Zhao: Patch Set 7: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/642396. |
Message from Mateusz Poliwczak: Patch Set 7: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/642396. |
Message from Robert Griesemer: Patch Set 7: (6 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/642396. |
This PR (HEAD: 04617ea) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/go/+/642396. Important tips:
|
reportCycle
has a deterministic output
This PR (HEAD: 410967c) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/go/+/642396. Important tips:
|
This PR (HEAD: efadb95) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/go/+/642396. Important tips:
|
Message from Robert Findley: Patch Set 10: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/642396. |
Message from Robert Griesemer: Patch Set 10: (4 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/642396. |
This PR (HEAD: ec630ca) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/go/+/642396. Important tips:
|
Message from Shengwei Zhao: Patch Set 11: (5 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/642396. |
Message from Robert Griesemer: Patch Set 11: Commit-Queue+1 (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/642396. |
Message from Go LUCI: Patch Set 11: Dry run: CV is trying the patch. Bot data: {"action":"start","triggered_at":"2025-01-15T01:21:11Z","revision":"d79a3c600e043636165d1191365be44a9311a297"} Please don’t reply on this GitHub thread. Visit golang.org/cl/642396. |
Message from Robert Griesemer: Patch Set 11: -Commit-Queue Please don’t reply on this GitHub thread. Visit golang.org/cl/642396. |
Message from Go LUCI: Patch Set 11: This CL has failed the run. Reason: Failed Tryjobs:
Build or test failure, click here for results. To reproduce, try Additional links for debugging:
Build or test failure, click here for results. To reproduce, try Additional links for debugging:
Build or test failure, click here for results. To reproduce, try Additional links for debugging: Please don’t reply on this GitHub thread. Visit golang.org/cl/642396. |
Message from Go LUCI: Patch Set 11: LUCI-TryBot-Result-1 Please don’t reply on this GitHub thread. Visit golang.org/cl/642396. |
This PR (HEAD: 72d3374) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/go/+/642396. Important tips:
|
This PR (HEAD: 88622ef) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/go/+/642396. Important tips:
|
Message from Shengwei Zhao: Patch Set 13: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/642396. |
Message from Robert Griesemer: Patch Set 13: (2 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/642396. |
Message from Shengwei Zhao: Patch Set 13: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/642396. |
Message from Shengwei Zhao: Patch Set 13: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/642396. |
Message from Robert Griesemer: Patch Set 13: (3 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/642396. |
This PR (HEAD: 9b804a7) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/go/+/642396. Important tips:
|
Message from Shengwei Zhao: Patch Set 14: (2 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/642396. |
Message from Shengwei Zhao: Patch Set 14: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/642396. |
Message from Robert Findley: Patch Set 14: Code-Review+1 (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/642396. |
Message from Robert Griesemer: Patch Set 14: Auto-Submit+1 Code-Review+2 Commit-Queue+1 (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/642396. |
Message from Go LUCI: Patch Set 14: Dry run: CV is trying the patch. Bot data: {"action":"start","triggered_at":"2025-01-17T15:59:21Z","revision":"340a94e7ceb5fed23fedfadb765141ed41693031"} Please don’t reply on this GitHub thread. Visit golang.org/cl/642396. |
…cycle Fixes #71254 Change-Id: Ie3bad281403c8ff6215e03d92760b9a378714cee GitHub-Last-Rev: 9b804a7 GitHub-Pull-Request: #71264 Reviewed-on: https://go-review.googlesource.com/c/go/+/642396 LUCI-TryBot-Result: Go LUCI <[email protected]> Reviewed-by: Robert Griesemer <[email protected]> Reviewed-by: Robert Findley <[email protected]> Auto-Submit: Robert Griesemer <[email protected]>
…cycle Fixes #71254 Change-Id: Ie3bad281403c8ff6215e03d92760b9a378714cee GitHub-Last-Rev: 9b804a7842421dca6a97c57ce18523b593b0817d GitHub-Pull-Request: golang/go#71264 Reviewed-on: https://go-review.googlesource.com/c/go/+/642396 LUCI-TryBot-Result: Go LUCI <[email protected]> Reviewed-by: Robert Griesemer <[email protected]> Reviewed-by: Robert Findley <[email protected]> Auto-Submit: Robert Griesemer <[email protected]>
Fixes #71254