Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses and resolves the potential deadlock issue described in #70753. The problem was identified in the file
src/encoding/json/encode.go
on line 373 of the Go 1.23 version. Previously, thetypeEncoder
function did not callwg.Done()
before executing the return statementreturn fi.(encoderFunc)
. This oversight could lead to cases where the waitgroup never reaches zero, causing deadlocks within concurrent executions. The modification introduced in this PR ensures thatwg.Done()
is called appropriately, thereby preventing any such deadlock situations and improving the stability and reliability of JSON encoding in concurrent environments.