-
Notifications
You must be signed in to change notification settings - Fork 18.1k
net/internal/cgotest: don't try to use cgo with netgo build tag #70141
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This PR (HEAD: e9bd204) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/go/+/623816. Important tips:
|
Message from Gopher Robot: Patch Set 1: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/623816. |
Message from Gopher Robot: Patch Set 1: Congratulations on opening your first change. Thank you for your contribution! Next steps: Most changes in the Go project go through a few rounds of revision. This can be During May-July and Nov-Jan the Go project is in a code freeze, during which Please don’t reply on this GitHub thread. Visit golang.org/cl/623816. |
Message from Ian Lance Taylor: Patch Set 2: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/623816. |
Message from Markus S: Patch Set 2: (2 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/623816. |
Message from Mateusz Poliwczak: Patch Set 2: (2 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/623816. |
Message from Ian Lance Taylor: Patch Set 2: (3 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/623816. |
When using bazel with hermetic_cc_toolchain resolv.h is not available.
Message from Markus S: Patch Set 3: (3 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/623816. |
This PR (HEAD: 818c723) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/go/+/623816. Important tips:
|
Message from Mateusz Poliwczak: Patch Set 4: Code-Review+1 Commit-Queue+1 (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/623816. |
Message from Go LUCI: Patch Set 4: Dry run: CV is trying the patch. Bot data: {"action":"start","triggered_at":"2024-11-04T19:27:04Z","revision":"47bf5896bab9d7d444de833afe58b41ea94649ed"} Please don’t reply on this GitHub thread. Visit golang.org/cl/623816. |
Message from Mateusz Poliwczak: Patch Set 4: -Commit-Queue Please don’t reply on this GitHub thread. Visit golang.org/cl/623816. |
Message from Go LUCI: Patch Set 4: This CL has passed the run Please don’t reply on this GitHub thread. Visit golang.org/cl/623816. |
Message from Go LUCI: Patch Set 4: LUCI-TryBot-Result+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/623816. |
Message from Markus S: Patch Set 4: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/623816. |
Message from Ian Lance Taylor: Patch Set 4: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/623816. |
Message from Ian Lance Taylor: Patch Set 4: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/623816. |
Message from Ian Lance Taylor: Patch Set 4: Auto-Submit+1 Code-Review+2 Commit-Queue+1 (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/623816. |
Message from Go LUCI: Patch Set 4: Dry run: CV is trying the patch. Bot data: {"action":"start","triggered_at":"2024-11-04T20:37:22Z","revision":"47bf5896bab9d7d444de833afe58b41ea94649ed"} Please don’t reply on this GitHub thread. Visit golang.org/cl/623816. |
Message from Ian Lance Taylor: Patch Set 4: -Commit-Queue Please don’t reply on this GitHub thread. Visit golang.org/cl/623816. |
Message from Go LUCI: Patch Set 4: This CL has passed the run Please don’t reply on this GitHub thread. Visit golang.org/cl/623816. |
When using bazel with hermetic_cc_toolchain resolv.h is not available. Change-Id: I2aed72e6c14535cb1400b30d285bf05aa2498fde GitHub-Last-Rev: 818c723 GitHub-Pull-Request: #70141 Reviewed-on: https://go-review.googlesource.com/c/go/+/623816 LUCI-TryBot-Result: Go LUCI <[email protected]> Auto-Submit: Ian Lance Taylor <[email protected]> Reviewed-by: Mateusz Poliwczak <[email protected]> Reviewed-by: Ian Lance Taylor <[email protected]> Reviewed-by: David Chase <[email protected]>
This PR is being closed because golang.org/cl/623816 has been merged. |
When using bazel with hermetic_cc_toolchain resolv.h is not available.