cmd/go: clarify that -coverpkg uses import paths #69655

matttproud · 2024-09-27T08:48:20Z

This change amends the long-form help output for 'go help build' and
'go help testflag' to specify that the '-coverpkg' flag operates
explicitly on import paths as well as package names. Import paths are
fundamental for precise specification of packages versus unqualified
package names, and the naming of the flag '-coverpkg' and its original
documentation leads a user to assume that it only operates on the
simple, unqualified package name form. The situation warrants
clarification.

Fixes #69653

gopherbot · 2024-09-27T08:56:07Z

This PR (HEAD: bbf6766) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/go/+/616257.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to log in to Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

gopherbot · 2024-09-27T09:03:26Z

Message from Gopher Robot:

Patch Set 1:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/616257.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-09-27T09:03:27Z

Message from Gopher Robot:

Patch Set 1:

Congratulations on opening your first change. Thank you for your contribution!

Next steps:
A maintainer will review your change and provide feedback. See
https://go.dev/doc/contribute#review for more info and tips to get your
patch through code review.

Most changes in the Go project go through a few rounds of revision. This can be
surprising to people new to the project. The careful, iterative review process
is our way of helping mentor contributors and ensuring that their contributions
have a lasting impact.

During May-July and Nov-Jan the Go project is in a code freeze, during which
little code gets reviewed or merged. If a reviewer responds with a comment like
R=go1.11 or adds a tag like "wait-release", it means that this CL will be
reviewed as part of the next development cycle. See https://go.dev/s/release
for more details.

Please don’t reply on this GitHub thread. Visit golang.org/cl/616257.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-09-27T09:11:07Z

Message from Rob Pike:

Patch Set 1:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/616257.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-09-27T09:25:44Z

Message from Matt Proud:

Patch Set 1:

(3 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/616257.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-09-27T11:44:56Z

This PR (HEAD: 40483ba) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/go/+/616257.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to log in to Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

gopherbot · 2024-09-27T11:59:18Z

Message from Matt Proud:

Patch Set 2:

(2 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/616257.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-09-27T21:24:51Z

Message from Rob Pike:

Patch Set 3: Code-Review+2

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/616257.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-09-27T21:31:50Z

Message from Ian Lance Taylor:

Patch Set 3: Commit-Queue+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/616257.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-09-27T21:31:51Z

Message from Go LUCI:

Patch Set 3:

Dry run: CV is trying the patch.

Bot data: {"action":"start","triggered_at":"2024-09-27T21:26:58Z","revision":"e6e460f067a5c1dcfad03e5fc2cbd2ee93d0f5bc"}

Please don’t reply on this GitHub thread. Visit golang.org/cl/616257.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-09-27T21:46:12Z

Message from Ian Lance Taylor:

Patch Set 3: -Commit-Queue

Please don’t reply on this GitHub thread. Visit golang.org/cl/616257.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-09-27T21:46:12Z

Message from Go LUCI:

Patch Set 3:

This CL has failed the run. Reason:

Tryjob golang/try/gotip-linux-amd64-newinliner has failed with summary (view all results):

go on master (change 616257)

Build or test failure, click here for results.

To reproduce, try gomote repro 8735607593658244769.

Additional links for debugging:

Output for go tool dist test -json [shard 3]

Please don’t reply on this GitHub thread. Visit golang.org/cl/616257.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-09-27T21:46:13Z

Message from Go LUCI:

Patch Set 3: LUCI-TryBot-Result-1

Please don’t reply on this GitHub thread. Visit golang.org/cl/616257.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-09-27T22:49:10Z

Message from Ian Lance Taylor:

Patch Set 3:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/616257.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-09-28T06:51:52Z

This PR (HEAD: a76a3a6) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/go/+/616257.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to log in to Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

gopherbot · 2024-09-28T07:06:20Z

Message from Matt Proud:

Patch Set 4:

(4 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/616257.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-09-29T04:41:38Z

Message from Ian Lance Taylor:

Patch Set 4: Commit-Queue+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/616257.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-09-29T04:41:38Z

Message from Go LUCI:

Patch Set 4:

Dry run: CV is trying the patch.

Bot data: {"action":"start","triggered_at":"2024-09-29T04:29:31Z","revision":"a91793dd231ebbf1a356ac92e71d9e9ad223ed34"}

Please don’t reply on this GitHub thread. Visit golang.org/cl/616257.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-09-29T05:01:56Z

Message from Ian Lance Taylor:

Patch Set 4: -Commit-Queue

Please don’t reply on this GitHub thread. Visit golang.org/cl/616257.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-09-29T05:01:57Z

Message from Go LUCI:

Patch Set 4:

This CL has passed the run

Please don’t reply on this GitHub thread. Visit golang.org/cl/616257.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-09-29T05:01:57Z

Message from Go LUCI:

Patch Set 4: LUCI-TryBot-Result+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/616257.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-09-30T12:46:05Z

Message from Michael Knyszek:

Patch Set 4: Code-Review+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/616257.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-09-30T14:41:42Z

Message from Michael Matloob:

Patch Set 4:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/616257.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-09-30T14:56:43Z

Message from Matt Proud:

Patch Set 4:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/616257.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-09-30T15:12:56Z

Message from Michael Matloob:

Patch Set 4:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/616257.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-09-30T16:37:39Z

Message from Matt Proud:

Patch Set 4:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/616257.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-10-02T17:04:10Z

Message from Michael Matloob:

Patch Set 4:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/616257.
After addressing review feedback, remember to publish your drafts!

This change amends the long-form help output for 'go help build' and 'go help testflag' to specify that the '-coverpkg' flag operates explicitly on import paths as well as package names. Import paths are fundamental for precise specification of packages versus unqualified package names, and the naming of the flag '-coverpkg' and its original documentation leads a user to assume that it only operates on the simple, unqualified package name form. The situation warrants clarification. Fixes golang#69653

gopherbot · 2024-10-03T07:57:50Z

This PR (HEAD: 466c662) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/go/+/616257.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to log in to Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

gopherbot · 2024-10-03T08:46:23Z

Message from Matt Proud:

Patch Set 5:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/616257.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-10-03T18:15:39Z

Message from Michael Matloob:

Patch Set 5: Code-Review+2

Please don’t reply on this GitHub thread. Visit golang.org/cl/616257.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-10-03T18:15:39Z

Message from Michael Matloob:

Patch Set 5: Commit-Queue+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/616257.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-10-03T18:15:40Z

Message from Go LUCI:

Patch Set 5:

Dry run: CV is trying the patch.

Bot data: {"action":"start","triggered_at":"2024-10-03T18:02:51Z","revision":"180a8f02ddc222d2b13bca9050fbcbcac3e91eba"}

Please don’t reply on this GitHub thread. Visit golang.org/cl/616257.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-10-03T18:30:03Z

Message from Michael Matloob:

Patch Set 5: -Commit-Queue

Please don’t reply on this GitHub thread. Visit golang.org/cl/616257.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-10-03T18:30:03Z

Message from Go LUCI:

Patch Set 5:

This CL has passed the run

Please don’t reply on this GitHub thread. Visit golang.org/cl/616257.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-10-03T18:30:04Z

Message from Go LUCI:

Patch Set 5: LUCI-TryBot-Result+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/616257.
After addressing review feedback, remember to publish your drafts!

This change amends the long-form help output for 'go help build' and 'go help testflag' to specify that the '-coverpkg' flag operates explicitly on import paths as well as package names. Import paths are fundamental for precise specification of packages versus unqualified package names, and the naming of the flag '-coverpkg' and its original documentation leads a user to assume that it only operates on the simple, unqualified package name form. The situation warrants clarification. Fixes #69653 Change-Id: Ifde6a974405ce1614e28898fc2b92ed5bad94e57 GitHub-Last-Rev: 466c662 GitHub-Pull-Request: #69655 Reviewed-on: https://go-review.googlesource.com/c/go/+/616257 LUCI-TryBot-Result: Go LUCI <[email protected]> Reviewed-by: Michael Matloob <[email protected]> Auto-Submit: Ian Lance Taylor <[email protected]> Reviewed-by: Rob Pike <[email protected]> Reviewed-by: Michael Knyszek <[email protected]>

gopherbot · 2024-10-28T17:55:09Z

This PR is being closed because golang.org/cl/616257 has been merged.

matttproud force-pushed the docs/coverpkg-clarification branch from bbf6766 to 40483ba Compare September 27, 2024 11:38

matttproud force-pushed the docs/coverpkg-clarification branch from 40483ba to a76a3a6 Compare September 28, 2024 06:46

matttproud force-pushed the docs/coverpkg-clarification branch from a76a3a6 to 466c662 Compare October 3, 2024 07:54

gopherbot closed this Oct 28, 2024

cmd/go: clarify that -coverpkg uses import paths #69655

cmd/go: clarify that -coverpkg uses import paths #69655

Uh oh!

Conversation

matttproud commented Sep 27, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

gopherbot commented Sep 27, 2024

Uh oh!

gopherbot commented Sep 27, 2024

Uh oh!

gopherbot commented Sep 27, 2024

Uh oh!

gopherbot commented Sep 27, 2024

Uh oh!

gopherbot commented Sep 27, 2024

Uh oh!

gopherbot commented Sep 27, 2024

Uh oh!

gopherbot commented Sep 27, 2024

Uh oh!

gopherbot commented Sep 27, 2024

Uh oh!

gopherbot commented Sep 27, 2024

Uh oh!

gopherbot commented Sep 27, 2024

Uh oh!

gopherbot commented Sep 27, 2024

Uh oh!

gopherbot commented Sep 27, 2024

Uh oh!

gopherbot commented Sep 27, 2024

Uh oh!

gopherbot commented Sep 27, 2024

Uh oh!

gopherbot commented Sep 28, 2024

Uh oh!

gopherbot commented Sep 28, 2024

Uh oh!

gopherbot commented Sep 29, 2024

Uh oh!

gopherbot commented Sep 29, 2024

Uh oh!

gopherbot commented Sep 29, 2024

Uh oh!

gopherbot commented Sep 29, 2024

Uh oh!

gopherbot commented Sep 29, 2024

Uh oh!

gopherbot commented Sep 30, 2024

Uh oh!

gopherbot commented Sep 30, 2024

Uh oh!

gopherbot commented Sep 30, 2024

Uh oh!

gopherbot commented Sep 30, 2024

Uh oh!

gopherbot commented Sep 30, 2024

Uh oh!

gopherbot commented Oct 2, 2024

Uh oh!

gopherbot commented Oct 3, 2024

Uh oh!

gopherbot commented Oct 3, 2024

Uh oh!

gopherbot commented Oct 3, 2024

Uh oh!

gopherbot commented Oct 3, 2024

Uh oh!

gopherbot commented Oct 3, 2024

Uh oh!

gopherbot commented Oct 3, 2024

Uh oh!

gopherbot commented Oct 3, 2024

Uh oh!

gopherbot commented Oct 3, 2024

Uh oh!

gopherbot commented Oct 28, 2024

Uh oh!

Uh oh!

matttproud commented Sep 27, 2024 •

edited

Loading