-
Notifications
You must be signed in to change notification settings - Fork 18.1k
internal/zstd: optimize skipFrame by using io.CopyN #69619
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This PR (HEAD: 08db6be) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/go/+/615716. Important tips:
|
Message from Gopher Robot: Patch Set 1: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/615716. |
Message from Zhen Li: Patch Set 1: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/615716. |
Message from Ian Lance Taylor: Patch Set 1: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/615716. |
Replaced the manual byte skipping logic with io.CopyN to improve performance and reduce memory allocation. This change simplifies the code by directly discarding the bytes read, enhancing readability and efficiency.
This PR (HEAD: dc5f836) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/go/+/615716. Important tips:
|
Message from Zhen Li: Patch Set 1: (2 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/615716. |
Message from Zhen Li: Patch Set 2: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/615716. |
Message from Ian Lance Taylor: Patch Set 2: Commit-Queue+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/615716. |
Message from Go LUCI: Patch Set 2: Dry run: CV is trying the patch. Bot data: {"action":"start","triggered_at":"2024-09-25T20:20:00Z","revision":"155ec20b3530b75885a0501d8c5e18aa8f9ef9a2"} Please don’t reply on this GitHub thread. Visit golang.org/cl/615716. |
Message from Ian Lance Taylor: Patch Set 2: -Commit-Queue Please don’t reply on this GitHub thread. Visit golang.org/cl/615716. |
Message from Go LUCI: Patch Set 2: This CL has passed the run Please don’t reply on this GitHub thread. Visit golang.org/cl/615716. |
Message from Go LUCI: Patch Set 2: LUCI-TryBot-Result+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/615716. |
Message from Ian Lance Taylor: Patch Set 2: Auto-Submit+1 Code-Review+2 Commit-Queue+1 (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/615716. |
Message from Go LUCI: Patch Set 2: Dry run: CV is trying the patch. Bot data: {"action":"start","triggered_at":"2024-09-25T20:40:33Z","revision":"155ec20b3530b75885a0501d8c5e18aa8f9ef9a2"} Please don’t reply on this GitHub thread. Visit golang.org/cl/615716. |
Message from Ian Lance Taylor: Patch Set 2: -Commit-Queue Please don’t reply on this GitHub thread. Visit golang.org/cl/615716. |
Message from Go LUCI: Patch Set 2: This CL has passed the run Please don’t reply on this GitHub thread. Visit golang.org/cl/615716. |
Replaced the manual byte skipping logic with io.CopyN to improve performance and reduce memory allocation. This change simplifies the code by directly discarding the bytes read, enhancing readability and efficiency. Change-Id: Id11496d072fb554c394947d08e63616ca48ecab4 GitHub-Last-Rev: dc5f836 GitHub-Pull-Request: #69619 Reviewed-on: https://go-review.googlesource.com/c/go/+/615716 Auto-Submit: Ian Lance Taylor <[email protected]> Reviewed-by: Ian Lance Taylor <[email protected]> LUCI-TryBot-Result: Go LUCI <[email protected]> Reviewed-by: Carlos Amedee <[email protected]>
This PR is being closed because golang.org/cl/615716 has been merged. |
Replaced the manual byte skipping logic with io.CopyN
to improve performance and reduce memory allocation.
This change simplifies the code by directly discarding
the bytes read, enhancing readability and efficiency.