-
Notifications
You must be signed in to change notification settings - Fork 18k
time: implement the encoding.(Binary|Text)Appender for Time #68942
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This PR (HEAD: fc953c8) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/go/+/606655. Important tips:
|
Message from Mateusz Poliwczak: Patch Set 1: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/606655. |
fc953c8
to
3dc72f4
Compare
This PR (HEAD: 3dc72f4) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/go/+/606655. Important tips:
|
3dc72f4
to
7773415
Compare
This PR (HEAD: 7773415) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/go/+/606655. Important tips:
|
Message from kyose chang: Patch Set 3: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/606655. |
Message from Ian Lance Taylor: Patch Set 3: (2 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/606655. |
"Time.Marshal(Binary|Text)" could also gain some performance improvements. Here is the benchmark highlight: │ old │ new │ │ sec/op │ sec/op vs base │ MarshalText-8 104.00n ± 3% 67.27n ± 2% -35.32% (p=0.000 n=10) MarshalBinary-8 31.77n ± 2% 12.13n ± 1% -61.82% (p=0.000 n=10) geomean 57.48n 28.57n -50.30% │ old │ new │ │ B/op │ B/op vs base │ MarshalText-8 48.00 ± 0% 0.00 ± 0% -100.00% (p=0.000 n=10) MarshalBinary-8 16.00 ± 0% 0.00 ± 0% -100.00% (p=0.000 n=10) │ old │ new │ │ allocs/op │ allocs/op vs base │ MarshalText-8 1.000 ± 0% 0.000 ± 0% -100.00% (p=0.000 n=10) MarshalBinary-8 1.000 ± 0% 0.000 ± 0% -100.00% (p=0.000 n=10) For golang#62384
7773415
to
e04f8df
Compare
This PR (HEAD: e04f8df) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/go/+/606655. Important tips:
|
Message from kyose chang: Patch Set 3: (2 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/606655. |
Message from Ian Lance Taylor: Patch Set 4: Commit-Queue+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/606655. |
Message from Go LUCI: Patch Set 4: Dry run: CV is trying the patch. Bot data: {"action":"start","triggered_at":"2024-08-19T20:44:38Z","revision":"0a64807b1dad1baf20513dd8155f80ff90aa6385"} Please don’t reply on this GitHub thread. Visit golang.org/cl/606655. |
Message from Ian Lance Taylor: Patch Set 4: -Commit-Queue Please don’t reply on this GitHub thread. Visit golang.org/cl/606655. |
Message from Go LUCI: Patch Set 4: This CL has passed the run Please don’t reply on this GitHub thread. Visit golang.org/cl/606655. |
Message from Go LUCI: Patch Set 4: LUCI-TryBot-Result+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/606655. |
Message from Ian Lance Taylor: Patch Set 4: Auto-Submit+1 Code-Review+2 Commit-Queue+1 (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/606655. |
Message from Go LUCI: Patch Set 4: Dry run: CV is trying the patch. Bot data: {"action":"start","triggered_at":"2024-08-19T23:35:03Z","revision":"0a64807b1dad1baf20513dd8155f80ff90aa6385"} Please don’t reply on this GitHub thread. Visit golang.org/cl/606655. |
Message from Ian Lance Taylor: Patch Set 4: -Commit-Queue Please don’t reply on this GitHub thread. Visit golang.org/cl/606655. |
Message from Go LUCI: Patch Set 4: This CL has passed the run Please don’t reply on this GitHub thread. Visit golang.org/cl/606655. |
Message from Cherry Mui: Patch Set 4: Code-Review+1 (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/606655. |
Message from kyose chang: Patch Set 4: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/606655. |
"Time.Marshal(Binary|Text)" could also gain some performance improvements. Here is the benchmark highlight: │ old │ new │ │ sec/op │ sec/op vs base │ MarshalText-8 104.00n ± 3% 67.27n ± 2% -35.32% (p=0.000 n=10) MarshalBinary-8 31.77n ± 2% 12.13n ± 1% -61.82% (p=0.000 n=10) geomean 57.48n 28.57n -50.30% │ old │ new │ │ B/op │ B/op vs base │ MarshalText-8 48.00 ± 0% 0.00 ± 0% -100.00% (p=0.000 n=10) MarshalBinary-8 16.00 ± 0% 0.00 ± 0% -100.00% (p=0.000 n=10) │ old │ new │ │ allocs/op │ allocs/op vs base │ MarshalText-8 1.000 ± 0% 0.000 ± 0% -100.00% (p=0.000 n=10) MarshalBinary-8 1.000 ± 0% 0.000 ± 0% -100.00% (p=0.000 n=10) For #62384 Change-Id: I320421878a341abf8d668fd57b27292cdfa61330 GitHub-Last-Rev: e04f8df GitHub-Pull-Request: #68942 Reviewed-on: https://go-review.googlesource.com/c/go/+/606655 Reviewed-by: Cherry Mui <[email protected]> LUCI-TryBot-Result: Go LUCI <[email protected]> Reviewed-by: Ian Lance Taylor <[email protected]> Auto-Submit: Ian Lance Taylor <[email protected]>
This PR is being closed because golang.org/cl/606655 has been merged. |
"Time.Marshal(Binary|Text)" could also gain some performance
improvements. Here is the benchmark highlight:
MarshalText-8 104.00n ± 3% 67.27n ± 2% -35.32% (p=0.000 n=10)
MarshalBinary-8 31.77n ± 2% 12.13n ± 1% -61.82% (p=0.000 n=10)
geomean 57.48n 28.57n -50.30%
MarshalText-8 48.00 ± 0% 0.00 ± 0% -100.00% (p=0.000 n=10)
MarshalBinary-8 16.00 ± 0% 0.00 ± 0% -100.00% (p=0.000 n=10)
MarshalText-8 1.000 ± 0% 0.000 ± 0% -100.00% (p=0.000 n=10)
MarshalBinary-8 1.000 ± 0% 0.000 ± 0% -100.00% (p=0.000 n=10)
For #62384