-
Notifications
You must be signed in to change notification settings - Fork 18.1k
encoding/json: merge FieldStack if the error's Field exists. #68870
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This PR (HEAD: 95f0918) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/go/+/605455. Important tips:
|
95f0918
to
c9a6f13
Compare
Message from Gopher Robot: Patch Set 1: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/605455. |
This PR (HEAD: c9a6f13) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/go/+/605455. Important tips:
|
Message from Yanjie Wang: Patch Set 1: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/605455. |
Message from Ian Lance Taylor: Patch Set 2: Commit-Queue+1 (2 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/605455. |
Message from Go LUCI: Patch Set 2: Dry run: CV is trying the patch. Bot data: {"action":"start","triggered_at":"2024-08-14T16:57:53Z","revision":"818e45841664c2f7d215108129261b34310cd94d"} Please don’t reply on this GitHub thread. Visit golang.org/cl/605455. |
Message from Ian Lance Taylor: Patch Set 2: -Commit-Queue Please don’t reply on this GitHub thread. Visit golang.org/cl/605455. |
Message from Go LUCI: Patch Set 2: This CL has passed the run Please don’t reply on this GitHub thread. Visit golang.org/cl/605455. |
Message from Go LUCI: Patch Set 2: LUCI-TryBot-Result+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/605455. |
When people return UnmarshalTypeError in UnmarshalJSON, we should append error's Field to FieldStack. Fixes golang#68750
c9a6f13
to
18796ad
Compare
This PR (HEAD: 18796ad) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/go/+/605455. Important tips:
|
Message from Yanjie Wang: Patch Set 2: (2 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/605455. |
Message from Ian Lance Taylor: Patch Set 4: Commit-Queue+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/605455. |
Message from Go LUCI: Patch Set 4: Dry run: CV is trying the patch. Bot data: {"action":"start","triggered_at":"2024-08-15T17:15:01Z","revision":"29c88b0211a3b281c3d82aa8e981063c89e468e6"} Please don’t reply on this GitHub thread. Visit golang.org/cl/605455. |
Message from Ian Lance Taylor: Patch Set 4: -Commit-Queue Please don’t reply on this GitHub thread. Visit golang.org/cl/605455. |
Message from Go LUCI: Patch Set 4: This CL has passed the run Please don’t reply on this GitHub thread. Visit golang.org/cl/605455. |
Message from Go LUCI: Patch Set 4: LUCI-TryBot-Result+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/605455. |
Message from Ian Lance Taylor: Patch Set 4: Auto-Submit+1 Code-Review+2 Commit-Queue+1 (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/605455. |
Message from Go LUCI: Patch Set 4: Dry run: CV is trying the patch. Bot data: {"action":"start","triggered_at":"2024-08-15T17:46:27Z","revision":"29c88b0211a3b281c3d82aa8e981063c89e468e6"} Please don’t reply on this GitHub thread. Visit golang.org/cl/605455. |
Message from Ian Lance Taylor: Patch Set 4: -Commit-Queue Please don’t reply on this GitHub thread. Visit golang.org/cl/605455. |
Message from Go LUCI: Patch Set 4: This CL has passed the run Please don’t reply on this GitHub thread. Visit golang.org/cl/605455. |
When people return UnmarshalTypeError in UnmarshalJSON, we should append error's Field to FieldStack. Fixes #68750 Change-Id: I0a5a9b259a1b569de1bebc815ec936c913e10469 GitHub-Last-Rev: 18796ad GitHub-Pull-Request: #68870 Reviewed-on: https://go-review.googlesource.com/c/go/+/605455 Reviewed-by: Carlos Amedee <[email protected]> Auto-Submit: Ian Lance Taylor <[email protected]> Reviewed-by: Ian Lance Taylor <[email protected]> LUCI-TryBot-Result: Go LUCI <[email protected]>
This PR is being closed because golang.org/cl/605455 has been merged. |
When people return UnmarshalTypeError in UnmarshalJSON, we should append error's Field to FieldStack.
Fixes #68750