net/http: fix debugRoundTrip log typo #66772

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Closed

testwill wants to merge 1 commit into golang:master from testwill:http_transport_typo

Contributor

testwill commented Apr 11, 2024

No description provided.


          net/http: fix debugRoundTrip log typo

b2e84f1

Contributor

gopherbot commented Apr 11, 2024

This PR (HEAD: b2e84f1) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/go/+/578135.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to log in to Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

Contributor

gopherbot commented Apr 11, 2024

Message from Ian Lance Taylor:

Patch Set 1: Auto-Submit+1 Code-Review+2 Commit-Queue+1

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/578135.
After addressing review feedback, remember to publish your drafts!

Contributor

gopherbot commented Apr 11, 2024

Message from Go LUCI:

Patch Set 1:

Dry run: CV is trying the patch.

Bot data: {"action":"start","triggered_at":"2024-04-11T21:54:25Z","revision":"3881f6469406cdbb955f26b8082ff9fdc95142db"}

Please don’t reply on this GitHub thread. Visit golang.org/cl/578135.
After addressing review feedback, remember to publish your drafts!

Contributor

gopherbot commented Apr 11, 2024

Message from Ian Lance Taylor:

Patch Set 1: -Commit-Queue

Please don’t reply on this GitHub thread. Visit golang.org/cl/578135.
After addressing review feedback, remember to publish your drafts!

Contributor

gopherbot commented Apr 11, 2024

Message from Go LUCI:

Patch Set 1:

This CL has passed the run

Please don’t reply on this GitHub thread. Visit golang.org/cl/578135.
After addressing review feedback, remember to publish your drafts!

Contributor

gopherbot commented Apr 11, 2024

Message from Go LUCI:

Patch Set 1: LUCI-TryBot-Result+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/578135.
After addressing review feedback, remember to publish your drafts!

gopherbot pushed a commit that referenced this pull request


          net/http: fix debugRoundTrip log typo

5c20d5f

Change-Id: I449fcb008fa4c1f51de0bef9f016907d8b99da67
GitHub-Last-Rev: b2e84f1
GitHub-Pull-Request: #66772
Reviewed-on: https://go-review.googlesource.com/c/go/+/578135
Reviewed-by: Carlos Amedee <[email protected]>
Auto-Submit: Ian Lance Taylor <[email protected]>
Reviewed-by: Ian Lance Taylor <[email protected]>
LUCI-TryBot-Result: Go LUCI <[email protected]>

Contributor

gopherbot commented Apr 12, 2024

Message from Carlos Amedee:

Patch Set 1: Code-Review+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/578135.
After addressing review feedback, remember to publish your drafts!

Contributor

gopherbot commented Apr 12, 2024

This PR is being closed because golang.org/cl/578135 has been merged.

gopherbot closed this

testwill deleted the http_transport_typo branch

April 12, 2024 14:32

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet