-
Notifications
You must be signed in to change notification settings - Fork 18k
archive/tar: add FileInfoNames interface #65273
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This PR (HEAD: 292ab66) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/go/+/558355. Important tips:
|
Message from Gopher Robot: Patch Set 1: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/558355. |
This PR (HEAD: 124d651) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/go/+/558355. Important tips:
|
Message from Kirill Kolyshkin: Patch Set 3: (3 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/558355. |
This PR (HEAD: a91a7a6) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/go/+/558355. Important tips:
|
Message from qiulaidongfeng: Patch Set 4: Run-TryBot+1 (4 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/558355. |
Message from Gopher Robot: Patch Set 4: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/558355. |
Message from Gopher Robot: Patch Set 4: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/558355. |
Message from Gopher Robot: Patch Set 4: TryBot-Result-1 (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/558355. |
Message from qiulaidongfeng: Patch Set 4: -Run-TryBot (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/558355. |
This PR (HEAD: e080379) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/go/+/558355. Important tips:
|
Message from qiulaidongfeng: Patch Set 5: Run-TryBot+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/558355. |
Message from Gopher Robot: Patch Set 5: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/558355. |
Message from Gopher Robot: Patch Set 5: TryBot-Result+1 (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/558355. |
Message from qiulaidongfeng: Patch Set 5: -Run-TryBot Please don’t reply on this GitHub thread. Visit golang.org/cl/558355. |
This PR (HEAD: 34b2feb) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/go/+/558355. Important tips:
|
Message from qiulaidongfeng: Patch Set 6: Run-TryBot+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/558355. |
Message from Gopher Robot: Patch Set 6: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/558355. |
Message from Gopher Robot: Patch Set 6: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/558355. |
Message from Gopher Robot: Patch Set 6: TryBot-Result-1 (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/558355. |
This PR (HEAD: a25a4d5) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/go/+/558355. Important tips:
|
Message from qiulaidongfeng: Patch Set 7: Run-TryBot+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/558355. |
Message from Gopher Robot: Patch Set 7: (2 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/558355. |
Message from qiulaidongfeng: Patch Set 7: -Run-TryBot Please don’t reply on this GitHub thread. Visit golang.org/cl/558355. |
This PR (HEAD: 08f7daa) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/go/+/558355. Important tips:
|
Message from qiulaidongfeng: Patch Set 8: Run-TryBot+1 (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/558355. |
Message from Gopher Robot: Patch Set 8: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/558355. |
Message from Gopher Robot: Patch Set 8: TryBot-Result+1 (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/558355. |
Message from qiulaidongfeng: Patch Set 8: -Run-TryBot Please don’t reply on this GitHub thread. Visit golang.org/cl/558355. |
An optional interface FileInfoNames has been added. If the parameter fi of FileInfoHeader implements the interface the Gname/Uname and Gid/Uid of the return value Header are provided by the method of the interface. Also added testing. Fixes golang#50102 Change-Id: Ie0465303a406292d6d0f6df886e5fc135b9d3cc6
Message from qiulaidongfeng: Patch Set 13: Commit-Queue+1 (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/558355. |
Message from qiulaidongfeng: Patch Set 13: -Commit-Queue Please don’t reply on this GitHub thread. Visit golang.org/cl/558355. |
Message from Go LUCI: Patch Set 13: CV cannot start a Run for Please don’t reply on this GitHub thread. Visit golang.org/cl/558355. |
Message from Go LUCI: Patch Set 13: LUCI-TryBot-Result-1 Please don’t reply on this GitHub thread. Visit golang.org/cl/558355. |
Message from qiulaidongfeng: Patch Set 13: Commit-Queue+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/558355. |
Message from Go LUCI: Patch Set 13: Dry run: CV is trying the patch. Bot data: {"action":"start","triggered_at":"2024-03-12T09:18:05Z","revision":"0c085606198adfc57b025734bc1e0f5fe659a480"} Please don’t reply on this GitHub thread. Visit golang.org/cl/558355. |
Message from qiulaidongfeng: Patch Set 13: -Commit-Queue Please don’t reply on this GitHub thread. Visit golang.org/cl/558355. |
Message from Go LUCI: Patch Set 13: This CL has passed the run Please don’t reply on this GitHub thread. Visit golang.org/cl/558355. |
Message from Go LUCI: Patch Set 13: LUCI-TryBot-Result+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/558355. |
Message from Ian Lance Taylor: Patch Set 13: Auto-Submit+1 Code-Review+2 Commit-Queue+1 (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/558355. |
Message from Go LUCI: Patch Set 13: Dry run: CV is trying the patch. Bot data: {"action":"start","triggered_at":"2024-03-12T22:47:18Z","revision":"0c085606198adfc57b025734bc1e0f5fe659a480"} Please don’t reply on this GitHub thread. Visit golang.org/cl/558355. |
Message from Ian Lance Taylor: Patch Set 13: -Commit-Queue Please don’t reply on this GitHub thread. Visit golang.org/cl/558355. |
Message from Go LUCI: Patch Set 13: This CL has failed the run. Reason: Tryjob golang/try/gotip-linux-amd64-race has failed with summary (view all results): FAILURE
Tests failed. See all test results. Error: Links: Please don’t reply on this GitHub thread. Visit golang.org/cl/558355. |
Message from Go LUCI: Patch Set 13: LUCI-TryBot-Result-1 Please don’t reply on this GitHub thread. Visit golang.org/cl/558355. |
Message from qiulaidongfeng: Patch Set 13: Commit-Queue+1 (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/558355. |
Message from Go LUCI: Patch Set 13: Dry run: CV is trying the patch. Bot data: {"action":"start","triggered_at":"2024-03-13T08:34:35Z","revision":"0c085606198adfc57b025734bc1e0f5fe659a480"} Please don’t reply on this GitHub thread. Visit golang.org/cl/558355. |
Message from qiulaidongfeng: Patch Set 13: -Commit-Queue Please don’t reply on this GitHub thread. Visit golang.org/cl/558355. |
Message from Go LUCI: Patch Set 13: This CL has passed the run Please don’t reply on this GitHub thread. Visit golang.org/cl/558355. |
Message from Go LUCI: Patch Set 13: LUCI-TryBot-Result+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/558355. |
Message from Cherry Mui: Patch Set 13: Code-Review+1 (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/558355. |
This PR (HEAD: a213613) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/go/+/558355. Important tips:
|
Message from qiulaidongfeng: Patch Set 14: Commit-Queue+1 (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/558355. |
Message from Go LUCI: Patch Set 14: Dry run: CV is trying the patch. Bot data: {"action":"start","triggered_at":"2024-03-15T10:43:39Z","revision":"921bc6ec77b8be689727d8e5f866941480f9f1ef"} Please don’t reply on this GitHub thread. Visit golang.org/cl/558355. |
Message from qiulaidongfeng: Patch Set 14: -Commit-Queue Please don’t reply on this GitHub thread. Visit golang.org/cl/558355. |
Message from Go LUCI: Patch Set 14: This CL has passed the run Please don’t reply on this GitHub thread. Visit golang.org/cl/558355. |
Message from Go LUCI: Patch Set 14: LUCI-TryBot-Result+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/558355. |
An optional interface FileInfoNames has been added. If the parameter fi of FileInfoHeader implements the interface the Gname/Uname of the return value Header are provided by the method of the interface. Also added testing. Fixes #50102 Change-Id: I47976e238eb20ed43113b060e4f83a14ae49493e GitHub-Last-Rev: a213613 GitHub-Pull-Request: #65273 Reviewed-on: https://go-review.googlesource.com/c/go/+/558355 Reviewed-by: Cherry Mui <[email protected]> Reviewed-by: Ian Lance Taylor <[email protected]> LUCI-TryBot-Result: Go LUCI <[email protected]>
This PR is being closed because golang.org/cl/558355 has been merged. |
An optional interface FileInfoNames has been added.
If the parameter fi of FileInfoHeader implements the interface
the Gname/Uname of the return value Header
are provided by the method of the interface.
Also added testing.
Fixes #50102