-
Notifications
You must be signed in to change notification settings - Fork 18k
reflect: fix isRegularMemory at case Array #65252
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
reflect: fix isRegularMemory at case Array #65252
Conversation
To match cmd/compile/internal/compare.IsRegularMemory, this CL adds code for empty arrays of comparable element type.
This PR (HEAD: 40db7ed) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/go/+/558155. Important tips:
|
Message from Gopher Robot: Patch Set 1: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/558155. |
Message from qiulaidongfeng: Patch Set 1: Code-Review+1 Run-TryBot+1 (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/558155. |
Message from Gopher Robot: Patch Set 1: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/558155. |
Message from Gopher Robot: Patch Set 1: TryBot-Result+1 (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/558155. |
Message from Jes Cok: Patch Set 1: (2 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/558155. |
Message from Keith Randall: Patch Set 1: Code-Review+2 (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/558155. |
Message from Keith Randall: Patch Set 1: Code-Review+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/558155. |
Message from Cherry Mui: Patch Set 1: Code-Review+2 Please don’t reply on this GitHub thread. Visit golang.org/cl/558155. |
To match cmd/compile/internal/compare.IsRegularMemory, this CL adds code for empty arrays of comparable element type. Change-Id: I205fb9bfda60be6c9aac2d9098ed3f0eb51cd0fa GitHub-Last-Rev: 40db7ed GitHub-Pull-Request: #65252 Reviewed-on: https://go-review.googlesource.com/c/go/+/558155 Reviewed-by: Keith Randall <[email protected]> Run-TryBot: qiulaidongfeng <[email protected]> Reviewed-by: Keith Randall <[email protected]> Reviewed-by: qiulaidongfeng <[email protected]> Reviewed-by: Cherry Mui <[email protected]> TryBot-Result: Gopher Robot <[email protected]>
This PR is being closed because golang.org/cl/558155 has been merged. |
To match cmd/compile/internal/compare.IsRegularMemory, this CL adds code for empty arrays of comparable element type. Change-Id: I205fb9bfda60be6c9aac2d9098ed3f0eb51cd0fa GitHub-Last-Rev: 40db7ed GitHub-Pull-Request: golang#65252 Reviewed-on: https://go-review.googlesource.com/c/go/+/558155 Reviewed-by: Keith Randall <[email protected]> Run-TryBot: qiulaidongfeng <[email protected]> Reviewed-by: Keith Randall <[email protected]> Reviewed-by: qiulaidongfeng <[email protected]> Reviewed-by: Cherry Mui <[email protected]> TryBot-Result: Gopher Robot <[email protected]>
To match cmd/compile/internal/compare.IsRegularMemory,
this CL adds code for empty arrays of comparable element type.