cmd/cgo/internal/testsanitizers: fix msan test failing with clang >= 16 #64691

mauri870 · 2023-12-13T00:23:07Z

Clang 16 introduced a more aggressive behavior regarding uninitialized
memory in the memory sanitizer.

The new option -fsanitize-memory-param-retval is enabled by default
and makes the test msan8 fail, since it uses an
uninitialized variable on purpose.

Disable this behavior if we are running with clang 16+.

Fixes #64616

Clang 16 introduced a more aggressive behavior regarding uninitilized memory in the memory sanitizer. The new option -fsanitize-memory-param-retval is enabled by default and makes the test msan8 fail, since it uses an uninitilialized variable. I restored the old behavior for this particular test with -fno-sanitize-memory-param-retval. Older versions of clang are still happy with the flag. Fixes [reserved]

gopherbot · 2023-12-13T00:30:29Z

This PR (HEAD: 7c43d91) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/go/+/549297.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to log in to Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

gopherbot · 2023-12-13T01:13:03Z

Message from Mauri de Souza Meneguzzo:

Patch Set 1: Run-TryBot+1

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/549297.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2023-12-13T01:19:50Z

Message from Gopher Robot:

Patch Set 1:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/549297.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2023-12-13T01:26:37Z

Message from Gopher Robot:

Patch Set 1:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/549297.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2023-12-13T01:26:38Z

Message from Gopher Robot:

Patch Set 1: TryBot-Result-1

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/549297.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2023-12-13T02:52:42Z

This PR (HEAD: d8a96a6) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/go/+/549297.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to log in to Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

gopherbot · 2023-12-13T03:05:39Z

Message from Mauri de Souza Meneguzzo:

Patch Set 2:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/549297.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2023-12-13T03:05:40Z

Message from Mauri de Souza Meneguzzo:

Patch Set 2: Run-TryBot+1

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/549297.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2023-12-13T03:05:41Z

Message from Gopher Robot:

Patch Set 2:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/549297.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2023-12-13T03:12:11Z

Message from Gopher Robot:

Patch Set 3:

(2 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/549297.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2023-12-13T03:18:41Z

Message from Gopher Robot:

Patch Set 3: TryBot-Result+1

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/549297.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2023-12-13T16:35:01Z

Message from Bryan Mills:

Patch Set 3:

(2 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/549297.
After addressing review feedback, remember to publish your drafts!

Change-Id: Iedb85372e6e562754441bf5c5a9df407167a6199

gopherbot · 2023-12-13T19:06:27Z

Message from Mauri de Souza Meneguzzo:

Patch Set 3: Run-TryBot+1

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/549297.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2023-12-13T19:06:35Z

This PR (HEAD: 9a04a2d) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/go/+/549297.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to log in to Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

gopherbot · 2023-12-13T19:14:17Z

Message from Mauri de Souza Meneguzzo:

Patch Set 4:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/549297.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2023-12-13T19:14:18Z

Message from Mauri de Souza Meneguzzo:

Patch Set 4:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/549297.
After addressing review feedback, remember to publish your drafts!

Change-Id: Ifa256f8ba008fe351d19f454196c42eec2a0e65e

gopherbot · 2023-12-13T19:50:55Z

This PR (HEAD: 6b2a14a) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/go/+/549297.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to log in to Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

Change-Id: I235ec5a9587218a6d77a5df72c48c568a48901f2

gopherbot · 2023-12-13T19:58:16Z

Message from Bryan Mills:

Patch Set 4: Code-Review+2 Commit-Queue+1 Run-TryBot+1

(2 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/549297.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2023-12-13T19:58:16Z

Message from Go LUCI:

Patch Set 4:

Dry run: CV is trying the patch.

Bot data: {"action":"start","triggered_at":"2023-12-13T19:44:22Z","revision":"a9068aac7fe8e05320c33d7d8f69e2c8439888c9"}

Please don’t reply on this GitHub thread. Visit golang.org/cl/549297.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2023-12-13T19:58:17Z

Message from Bryan Mills:

Patch Set 4:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/549297.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2023-12-13T19:58:18Z

Message from Bryan Mills:

Patch Set 4:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/549297.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2023-12-13T19:58:18Z

Message from Gopher Robot:

Patch Set 4:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/549297.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2023-12-13T19:58:19Z

Message from Go LUCI:

Patch Set 4: LUCI-TryBot-Result-1

Please don’t reply on this GitHub thread. Visit golang.org/cl/549297.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2023-12-13T19:58:26Z

This PR (HEAD: 60bd64a) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/go/+/549297.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to log in to Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

gopherbot · 2023-12-13T20:05:50Z

Message from Mauri de Souza Meneguzzo:

Patch Set 4:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/549297.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2023-12-15T02:15:35Z

Message from Mauri de Souza Meneguzzo:

Patch Set 6:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/549297.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2023-12-15T02:15:36Z

Message from Mauri de Souza Meneguzzo:

Patch Set 6:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/549297.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2023-12-15T21:40:51Z

Message from Bryan Mills:

Patch Set 6: Code-Review+2 Commit-Queue+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/549297.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2023-12-15T21:40:52Z

Message from Go LUCI:

Patch Set 6:

Dry run: CV is trying the patch.

Bot data: {"action":"start","triggered_at":"2023-12-15T21:35:23Z","revision":"4ff73482c5921f49ace31e4c4192f439e82d825f"}

Please don’t reply on this GitHub thread. Visit golang.org/cl/549297.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2023-12-15T21:40:52Z

Message from Bryan Mills:

Patch Set 6: Auto-Submit+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/549297.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2023-12-15T22:00:23Z

Message from Bryan Mills:

Patch Set 6: -Commit-Queue

Please don’t reply on this GitHub thread. Visit golang.org/cl/549297.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2023-12-15T22:00:24Z

Message from Go LUCI:

Patch Set 6:

This CL has passed the run

Please don’t reply on this GitHub thread. Visit golang.org/cl/549297.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2023-12-15T22:00:24Z

Message from Go LUCI:

Patch Set 6: LUCI-TryBot-Result+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/549297.
After addressing review feedback, remember to publish your drafts!

Clang 16 introduced a more aggressive behavior regarding uninitialized memory in the memory sanitizer. The new option -fsanitize-memory-param-retval is enabled by default and makes the test msan8 fail, since it uses an uninitialized variable on purpose. Disable this behavior if we are running with clang 16+. Fixes #64616 Change-Id: If366f978bef984ea73f6ae958f24c8fce99b59fe GitHub-Last-Rev: 60bd64a GitHub-Pull-Request: #64691 Reviewed-on: https://go-review.googlesource.com/c/go/+/549297 Auto-Submit: Bryan Mills <[email protected]> Reviewed-by: Bryan Mills <[email protected]> LUCI-TryBot-Result: Go LUCI <[email protected]> Reviewed-by: Than McIntosh <[email protected]>

gopherbot · 2023-12-18T19:26:43Z

This PR is being closed because golang.org/cl/549297 has been merged.

Clang 16 introduced a more aggressive behavior regarding uninitialized memory in the memory sanitizer. The new option -fsanitize-memory-param-retval is enabled by default and makes the test msan8 fail, since it uses an uninitialized variable on purpose. Disable this behavior if we are running with clang 16+. Fixes golang#64616 Change-Id: If366f978bef984ea73f6ae958f24c8fce99b59fe GitHub-Last-Rev: 60bd64a GitHub-Pull-Request: golang#64691 Reviewed-on: https://go-review.googlesource.com/c/go/+/549297 Auto-Submit: Bryan Mills <[email protected]> Reviewed-by: Bryan Mills <[email protected]> LUCI-TryBot-Result: Go LUCI <[email protected]> Reviewed-by: Than McIntosh <[email protected]>

mauri870 changed the title ~~cmd/cgo/internal/testsanitizers: fix msan tests failing with clang >= 16~~ cmd/cgo/internal/testsanitizers: fix msan test failing with clang >= 16 Dec 13, 2023

mauri870 force-pushed the hotfix/msan-test-clang-16 branch from 400efce to c1a93a2 Compare December 13, 2023 02:50

implement clang version check

d8a96a6

mauri870 force-pushed the hotfix/msan-test-clang-16 branch from c1a93a2 to d8a96a6 Compare December 13, 2023 02:51

use __clang_major__ to detect clang version

9a04a2d

Change-Id: Iedb85372e6e562754441bf5c5a9df407167a6199

use Environ() instead of Env

6b2a14a

Change-Id: Ifa256f8ba008fe351d19f454196c42eec2a0e65e

use replaceEnv

60bd64a

Change-Id: I235ec5a9587218a6d77a5df72c48c568a48901f2

gopherbot closed this Dec 18, 2023

cmd/cgo/internal/testsanitizers: fix msan test failing with clang >= 16 #64691

cmd/cgo/internal/testsanitizers: fix msan test failing with clang >= 16 #64691

Uh oh!

Conversation

mauri870 commented Dec 13, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

gopherbot commented Dec 13, 2023

Uh oh!

gopherbot commented Dec 13, 2023

Uh oh!

gopherbot commented Dec 13, 2023

Uh oh!

gopherbot commented Dec 13, 2023

Uh oh!

gopherbot commented Dec 13, 2023

Uh oh!

gopherbot commented Dec 13, 2023

Uh oh!

gopherbot commented Dec 13, 2023

Uh oh!

gopherbot commented Dec 13, 2023

Uh oh!

gopherbot commented Dec 13, 2023

Uh oh!

gopherbot commented Dec 13, 2023

Uh oh!

gopherbot commented Dec 13, 2023

Uh oh!

gopherbot commented Dec 13, 2023

Uh oh!

gopherbot commented Dec 13, 2023

Uh oh!

gopherbot commented Dec 13, 2023

Uh oh!

gopherbot commented Dec 13, 2023

Uh oh!

gopherbot commented Dec 13, 2023

Uh oh!

gopherbot commented Dec 13, 2023

Uh oh!

gopherbot commented Dec 13, 2023

Uh oh!

gopherbot commented Dec 13, 2023

Uh oh!

gopherbot commented Dec 13, 2023

Uh oh!

gopherbot commented Dec 13, 2023

Uh oh!

gopherbot commented Dec 13, 2023

Uh oh!

gopherbot commented Dec 13, 2023

Uh oh!

gopherbot commented Dec 13, 2023

Uh oh!

gopherbot commented Dec 13, 2023

Uh oh!

gopherbot commented Dec 15, 2023

Uh oh!

gopherbot commented Dec 15, 2023

Uh oh!

gopherbot commented Dec 15, 2023

Uh oh!

gopherbot commented Dec 15, 2023

Uh oh!

gopherbot commented Dec 15, 2023

Uh oh!

gopherbot commented Dec 15, 2023

Uh oh!

gopherbot commented Dec 15, 2023

Uh oh!

gopherbot commented Dec 15, 2023

Uh oh!

gopherbot commented Dec 18, 2023

Uh oh!

Uh oh!

mauri870 commented Dec 13, 2023 •

edited

Loading