net: fixes to dnsReadConfig in dnsconfig_windows.go #64441

qdm12 · 2023-11-29T10:22:02Z

Only search DNS servers for network interfaces with at least one gateway
Clarify comment on deprecated site local anycast fec0/10 DNS IPv6 addresses
Minor maintenance: skip not "up" interfaces earlier in outer loop

gopherbot · 2023-11-29T10:42:40Z

This PR (HEAD: 6de0c4b) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/go/+/545775.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to log in to Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

gopherbot · 2023-11-29T10:56:02Z

Message from Gopher Robot:

Patch Set 1:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/545775.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2023-11-29T10:56:03Z

Message from Gopher Robot:

Patch Set 1:

Congratulations on opening your first change. Thank you for your contribution!

Next steps:
A maintainer will review your change and provide feedback. See
https://go.dev/doc/contribute#review for more info and tips to get your
patch through code review.

Most changes in the Go project go through a few rounds of revision. This can be
surprising to people new to the project. The careful, iterative review process
is our way of helping mentor contributors and ensuring that their contributions
have a lasting impact.

During May-July and Nov-Jan the Go project is in a code freeze, during which
little code gets reviewed or merged. If a reviewer responds with a comment like
R=go1.11 or adds a tag like "wait-release", it means that this CL will be
reviewed as part of the next development cycle. See https://go.dev/s/release
for more details.

Please don’t reply on this GitHub thread. Visit golang.org/cl/545775.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2023-11-29T11:09:28Z

Message from Quentin McGaw:

Patch Set 1:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/545775.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2023-11-29T11:09:29Z

Message from Quentin McGaw:

Patch Set 1:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/545775.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2023-11-29T18:52:09Z

Message from Damien Neil:

Patch Set 1: Code-Review+1 Commit-Queue+1

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/545775.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2023-11-29T18:52:10Z

Message from Go LUCI:

Patch Set 1:

Dry run: CV is trying the patch.

Bot data: {"action":"start","triggered_at":"2023-11-29T18:34:11Z","revision":"c2e45a0c373711bc74aed1e39a511ba85f14367c"}

Please don’t reply on this GitHub thread. Visit golang.org/cl/545775.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2023-11-29T18:52:11Z

Message from Damien Neil:

Patch Set 1: -Commit-Queue

Please don’t reply on this GitHub thread. Visit golang.org/cl/545775.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2023-11-29T18:52:12Z

Message from Go LUCI:

Patch Set 1:

This CL has failed the run. Reason:

Tryjob golang/try/gotip-windows-386 has failed with summary (view all results):

FAILURE

go on master (change 545775)

error: shard 1: failed to run "make.bat": exit status 1

Please don’t reply on this GitHub thread. Visit golang.org/cl/545775.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2023-11-29T18:52:13Z

Message from Go LUCI:

Patch Set 1: LUCI-TryBot-Result-1

Please don’t reply on this GitHub thread. Visit golang.org/cl/545775.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2023-11-29T21:44:39Z

This PR (HEAD: 3b358c7) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/go/+/545775.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to log in to Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

gopherbot · 2023-11-29T21:57:41Z

Message from Quentin McGaw:

Patch Set 2:

(3 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/545775.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-03-04T18:00:21Z

Message from Damien Neil:

Patch Set 2: Code-Review+2 Commit-Queue+1

(5 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/545775.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-03-04T18:00:21Z

Message from Go LUCI:

Patch Set 2:

Dry run: CV is trying the patch.

Bot data: {"action":"start","triggered_at":"2024-03-04T17:52:57Z","revision":"53b7c33d268f0fe40803cd0a36bc6dcb53c07372"}

Please don’t reply on this GitHub thread. Visit golang.org/cl/545775.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-03-04T18:07:36Z

Message from Damien Neil:

Patch Set 2: -Commit-Queue

Please don’t reply on this GitHub thread. Visit golang.org/cl/545775.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-03-04T18:07:37Z

Message from Go LUCI:

Patch Set 2:

This CL has failed the run. Reason:

Tryjob golang/try/x_tools-gotip-linux-amd64 has failed with summary (view all results):

FAILURE

go on master (change 545775)
tools on master (commit 5bf7d00)

Error:
failed to run "test golang.org/x/tools/gopls module": exit status 1

Links:

"test golang.org/x/tools/gopls module" (combined output)

Please don’t reply on this GitHub thread. Visit golang.org/cl/545775.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-03-04T18:07:37Z

Message from Go LUCI:

Patch Set 2: LUCI-TryBot-Result-1

Please don’t reply on this GitHub thread. Visit golang.org/cl/545775.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-03-04T19:42:10Z

Message from Damien Neil:

Patch Set 3: Code-Review+2 Commit-Queue+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/545775.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-03-04T19:42:11Z

Message from Go LUCI:

Patch Set 3:

Dry run: CV is trying the patch.

Bot data: {"action":"start","triggered_at":"2024-03-04T19:38:27Z","revision":"f314cb7a3d3e49738a890ff395dbaddeea9d699b"}

Please don’t reply on this GitHub thread. Visit golang.org/cl/545775.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-03-04T20:08:27Z

Message from Damien Neil:

Patch Set 3: -Commit-Queue

Please don’t reply on this GitHub thread. Visit golang.org/cl/545775.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-03-04T20:08:27Z

Message from Go LUCI:

Patch Set 3:

This CL has passed the run

Please don’t reply on this GitHub thread. Visit golang.org/cl/545775.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-03-04T20:08:28Z

Message from Go LUCI:

Patch Set 3: LUCI-TryBot-Result+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/545775.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-03-10T06:17:21Z

Message from Alex Brainman:

Patch Set 3: Code-Review+2

(2 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/545775.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-03-11T13:08:19Z

Message from Quentin McGaw:

Patch Set 3:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/545775.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-03-11T13:15:32Z

Message from Quentin McGaw:

Patch Set 3:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/545775.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-03-11T20:40:05Z

Message from Damien Neil:

Patch Set 3:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/545775.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-03-11T21:24:54Z

Message from Cherry Mui:

Patch Set 3: Code-Review+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/545775.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-03-12T07:30:45Z

Message from Alex Brainman:

Patch Set 3:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/545775.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-03-15T10:20:02Z

Message from Quentin McGaw:

Patch Set 3:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/545775.
After addressing review feedback, remember to publish your drafts!

- Only search DNS servers for network interfaces with at least one gateway - Clarify comment on deprecated site local anycast fec0/10 DNS IPv6 addresses - Minor maintenance: skip not "up" interfaces earlier in outer loop Change-Id: I98ca7b81d3d51e6aa6bfa4a10dcd651305a843df GitHub-Last-Rev: 3b358c7 GitHub-Pull-Request: #64441 Reviewed-on: https://go-review.googlesource.com/c/go/+/545775 LUCI-TryBot-Result: Go LUCI <[email protected]> Reviewed-by: Cherry Mui <[email protected]> Reviewed-by: Damien Neil <[email protected]> Reviewed-by: Alex Brainman <[email protected]>

gopherbot · 2024-03-15T10:32:59Z

This PR is being closed because golang.org/cl/545775 has been merged.

qdm12 added 3 commits November 29, 2023 09:17

Skip addresses not up without interating over each DNS address

74adff3

Clarify comment on fec0/10 DNS IPv6 addresses

92a882c

Only search DNS servers for interfaces with at least one gateway

6de0c4b

Add missing IpAdapterAddresses fields

3b358c7

gopherbot closed this Mar 15, 2024

net: fixes to dnsReadConfig in dnsconfig_windows.go #64441

net: fixes to dnsReadConfig in dnsconfig_windows.go #64441

Uh oh!

Conversation

qdm12 commented Nov 29, 2023

Uh oh!

gopherbot commented Nov 29, 2023

Uh oh!

gopherbot commented Nov 29, 2023

Uh oh!

gopherbot commented Nov 29, 2023

Uh oh!

gopherbot commented Nov 29, 2023

Uh oh!

gopherbot commented Nov 29, 2023

Uh oh!

gopherbot commented Nov 29, 2023

Uh oh!

gopherbot commented Nov 29, 2023

Uh oh!

gopherbot commented Nov 29, 2023

Uh oh!

gopherbot commented Nov 29, 2023

Uh oh!

gopherbot commented Nov 29, 2023

Uh oh!

gopherbot commented Nov 29, 2023

Uh oh!

gopherbot commented Nov 29, 2023

Uh oh!

gopherbot commented Mar 4, 2024

Uh oh!

gopherbot commented Mar 4, 2024

Uh oh!

gopherbot commented Mar 4, 2024

Uh oh!

gopherbot commented Mar 4, 2024

Uh oh!

gopherbot commented Mar 4, 2024

Uh oh!

gopherbot commented Mar 4, 2024

Uh oh!

gopherbot commented Mar 4, 2024

Uh oh!

gopherbot commented Mar 4, 2024

Uh oh!

gopherbot commented Mar 4, 2024

Uh oh!

gopherbot commented Mar 4, 2024

Uh oh!

gopherbot commented Mar 10, 2024

Uh oh!

gopherbot commented Mar 11, 2024

Uh oh!

gopherbot commented Mar 11, 2024

Uh oh!

gopherbot commented Mar 11, 2024

Uh oh!

gopherbot commented Mar 11, 2024

Uh oh!

gopherbot commented Mar 12, 2024

Uh oh!

gopherbot commented Mar 15, 2024

Uh oh!

gopherbot commented Mar 15, 2024

Uh oh!

Uh oh!