-
Notifications
You must be signed in to change notification settings - Fork 18.1k
encoding/xml: rewrite func procInst #64336
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This PR (HEAD: e19fb97) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/go/+/544475. Important tips:
|
Message from Gopher Robot: Patch Set 1: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/544475. |
This PR (HEAD: 03d542d) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/go/+/544475. Important tips:
|
Message from Jes Cok: Patch Set 2: Run-TryBot+1 (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/544475. |
Message from Gopher Robot: Patch Set 2: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/544475. |
Message from Gopher Robot: Patch Set 2: TryBot-Result+1 (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/544475. |
Message from Jes Cok: Patch Set 2: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/544475. |
This PR (HEAD: 592a655) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/go/+/544475. Important tips:
|
Message from Jes Cok: Patch Set 3: Run-TryBot+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/544475. |
Message from Gopher Robot: Patch Set 3: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/544475. |
Message from Gopher Robot: Patch Set 3: TryBot-Result+1 (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/544475. |
This PR (HEAD: be4c0ce) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/go/+/544475. Important tips:
|
Message from Jes Cok: Patch Set 4: Run-TryBot+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/544475. |
Message from Gopher Robot: Patch Set 4: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/544475. |
Message from Gopher Robot: Patch Set 4: TryBot-Result+1 (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/544475. |
Message from Jes Cok: Patch Set 4: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/544475. |
Message from Jes Cok: Patch Set 4: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/544475. |
Message from Ian Lance Taylor: Patch Set 4: (2 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/544475. |
This PR (HEAD: a9b0890) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/go/+/544475. Important tips:
|
Message from Jes Cok: Patch Set 6: Run-TryBot+1 (2 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/544475. |
Message from Gopher Robot: Patch Set 6: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/544475. |
Message from Gopher Robot: Patch Set 6: TryBot-Result+1 (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/544475. |
Message from Jes Cok: Patch Set 6: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/544475. |
Message from Jes Cok: Patch Set 6: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/544475. |
Message from Ian Lance Taylor: Patch Set 6: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/544475. |
This CL tries to make function procInst more exact, also adds test cases, however, including tricky ones.
This PR (HEAD: b9a3192) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/go/+/544475. Important tips:
|
Message from Jes Cok: Patch Set 7: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/544475. |
Message from Ian Lance Taylor: Patch Set 7: Commit-Queue+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/544475. |
Message from Go LUCI: Patch Set 7: Dry run: CV is trying the patch. Bot data: {"action":"start","triggered_at":"2024-02-07T20:29:38Z","revision":"a627f09c4fbb45f901aa68ba8acbc5ae39ad7635"} Please don’t reply on this GitHub thread. Visit golang.org/cl/544475. |
Message from Ian Lance Taylor: Patch Set 7: -Commit-Queue Please don’t reply on this GitHub thread. Visit golang.org/cl/544475. |
Message from Go LUCI: Patch Set 7: This CL has passed the run Please don’t reply on this GitHub thread. Visit golang.org/cl/544475. |
Message from Go LUCI: Patch Set 7: LUCI-TryBot-Result+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/544475. |
Message from Ian Lance Taylor: Patch Set 7: Auto-Submit+1 Code-Review+2 (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/544475. |
Message from Jes Cok: Patch Set 7: (2 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/544475. |
Message from Jes Cok: Patch Set 7: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/544475. |
This CL tries to make function procInst more exact, also adds test cases, however, including tricky ones. Change-Id: If421299fc84d136e56a25dba7a4919c4424702c8 GitHub-Last-Rev: b9a3192 GitHub-Pull-Request: #64336 Reviewed-on: https://go-review.googlesource.com/c/go/+/544475 LUCI-TryBot-Result: Go LUCI <[email protected]> Reviewed-by: Dmitri Shuralyov <[email protected]> Auto-Submit: Ian Lance Taylor <[email protected]> Reviewed-by: Ian Lance Taylor <[email protected]>
Message from Dmitri Shuralyov: Patch Set 7: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/544475. |
This PR is being closed because golang.org/cl/544475 has been merged. |
This CL tries to make function procInst more exact, also adds test cases, however, including tricky ones. Change-Id: If421299fc84d136e56a25dba7a4919c4424702c8 GitHub-Last-Rev: b9a3192 GitHub-Pull-Request: golang#64336 Reviewed-on: https://go-review.googlesource.com/c/go/+/544475 LUCI-TryBot-Result: Go LUCI <[email protected]> Reviewed-by: Dmitri Shuralyov <[email protected]> Auto-Submit: Ian Lance Taylor <[email protected]> Reviewed-by: Ian Lance Taylor <[email protected]>
This CL tries to make function procInst more exact,
also adds test cases, however, including tricky ones.