internal/abi, runtime, reflect, cmd: merge maxZero const into internal/abi #64268

qiulaidongfeng · 2023-11-19T22:32:25Z

For #59670

gopherbot · 2023-11-19T22:40:44Z

This PR (HEAD: 500e9ce) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/go/+/543655.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to log in to Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

gopherbot · 2023-11-19T22:47:26Z

Message from Gopher Robot:

Patch Set 1:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/543655.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2023-11-20T01:48:25Z

Message from Keith Randall:

Patch Set 1: Auto-Submit+1 Code-Review+2 Commit-Queue+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/543655.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2023-11-20T01:55:10Z

Message from Go LUCI:

Patch Set 1:

Dry run: CV is trying the patch.

Bot data: {"action":"start","triggered_at":"2023-11-20T01:41:56Z","revision":"e85435747f519a45ac809a5d2f4ee0ea745b9ef4"}

Please don’t reply on this GitHub thread. Visit golang.org/cl/543655.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2023-11-20T01:55:10Z

Message from Keith Randall:

Patch Set 1: Code-Review+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/543655.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2023-11-20T02:02:22Z

Message from Keith Randall:

Patch Set 1: -Commit-Queue

Please don’t reply on this GitHub thread. Visit golang.org/cl/543655.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2023-11-20T02:02:23Z

Message from Go LUCI:

Patch Set 1:

This CL has failed the run. Reason:

Tryjob golang/try/gotip-linux-amd64-newinliner has failed with summary (view all results):

FAILURE

go on master (change 543655)

error: shard 3: failed to run "go tool dist test -json": exit status 1

Please don’t reply on this GitHub thread. Visit golang.org/cl/543655.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2023-11-20T02:02:23Z

Message from Go LUCI:

Patch Set 1: LUCI-TryBot-Result-1

Please don’t reply on this GitHub thread. Visit golang.org/cl/543655.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2023-11-20T05:06:13Z

Message from Keith Randall:

Patch Set 2: Code-Review+2 Commit-Queue+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/543655.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2023-11-20T05:06:14Z

Message from Go LUCI:

Patch Set 2:

Dry run: CV is trying the patch.

Bot data: {"action":"start","triggered_at":"2023-11-20T04:54:19Z","revision":"2fa533df090824d20f07adf1f37944ef17b4f4f7"}

Please don’t reply on this GitHub thread. Visit golang.org/cl/543655.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2023-11-20T05:25:56Z

Message from Keith Randall:

Patch Set 2: -Commit-Queue

Please don’t reply on this GitHub thread. Visit golang.org/cl/543655.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2023-11-20T05:25:57Z

Message from Go LUCI:

Patch Set 2:

This CL has passed the run

Please don’t reply on this GitHub thread. Visit golang.org/cl/543655.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2023-11-20T05:25:57Z

Message from Go LUCI:

Patch Set 2: LUCI-TryBot-Result+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/543655.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2023-11-20T06:12:09Z

Message from qiulaidongfeng:

Patch Set 2:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/543655.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2023-11-20T15:59:41Z

Message from Matthew Dempsky:

Patch Set 2: Code-Review+2

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/543655.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2023-11-20T23:02:13Z

Message from qiulaidongfeng:

Patch Set 2:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/543655.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2023-11-21T01:29:34Z

Message from Matthew Dempsky:

Patch Set 2:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/543655.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2023-11-21T13:10:06Z

This PR (HEAD: 8094ec1) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/go/+/543655.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to log in to Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

gopherbot · 2023-11-21T13:26:06Z

Message from qiulaidongfeng:

Patch Set 3: Run-TryBot+1

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/543655.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2023-11-21T13:33:41Z

Message from Gopher Robot:

Patch Set 3:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/543655.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2023-11-21T13:41:31Z

Message from Gopher Robot:

Patch Set 3: TryBot-Result+1

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/543655.
After addressing review feedback, remember to publish your drafts!

…l/abi For golang#59670

gopherbot · 2023-11-21T22:50:38Z

This PR (HEAD: a6edfc5) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/go/+/543655.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to log in to Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

…ytes of runtime.zeroVal."

gopherbot · 2023-11-21T22:58:02Z

This PR (HEAD: fb1f2f3) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/go/+/543655.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to log in to Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

gopherbot · 2023-11-21T23:05:22Z

Message from qiulaidongfeng:

Patch Set 5: Run-TryBot+1

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/543655.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2023-11-21T23:12:34Z

Message from Gopher Robot:

Patch Set 5:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/543655.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2023-11-21T23:27:02Z

Message from Gopher Robot:

Patch Set 5: TryBot-Result+1

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/543655.
After addressing review feedback, remember to publish your drafts!

…l/abi For #59670 Change-Id: If38a74ad067a3ea3ff551c0c25c8ef41abec114b GitHub-Last-Rev: fb1f2f3 GitHub-Pull-Request: #64268 Reviewed-on: https://go-review.googlesource.com/c/go/+/543655 Run-TryBot: qiulaidongfeng <[email protected]> TryBot-Result: Gopher Robot <[email protected]> Reviewed-by: Matthew Dempsky <[email protected]> Reviewed-by: Keith Randall <[email protected]> Reviewed-by: Keith Randall <[email protected]>

gopherbot · 2023-11-22T04:07:38Z

This PR is being closed because golang.org/cl/543655 has been merged.

qiulaidongfeng force-pushed the merge-maxZero branch 2 times, most recently from 51149b3 to 8094ec1 Compare November 21, 2023 13:05

internal/abi, runtime, reflect, cmd: merge maxZero const into interna…

89475c8

…l/abi For golang#59670

qiulaidongfeng force-pushed the merge-maxZero branch from 8094ec1 to a6edfc5 Compare November 21, 2023 22:49

Rename to "ZeroValSize" and document as "ZeroValSize is the size in b…

fb1f2f3

…ytes of runtime.zeroVal."

qiulaidongfeng force-pushed the merge-maxZero branch from a6edfc5 to fb1f2f3 Compare November 21, 2023 22:57

gopherbot closed this Nov 22, 2023

internal/abi, runtime, reflect, cmd: merge maxZero const into internal/abi #64268

internal/abi, runtime, reflect, cmd: merge maxZero const into internal/abi #64268

Uh oh!

Conversation

qiulaidongfeng commented Nov 19, 2023

Uh oh!

gopherbot commented Nov 19, 2023

Uh oh!

gopherbot commented Nov 19, 2023

Uh oh!

gopherbot commented Nov 20, 2023

Uh oh!

gopherbot commented Nov 20, 2023

Uh oh!

gopherbot commented Nov 20, 2023

Uh oh!

gopherbot commented Nov 20, 2023

Uh oh!

gopherbot commented Nov 20, 2023

Uh oh!

gopherbot commented Nov 20, 2023

Uh oh!

gopherbot commented Nov 20, 2023

Uh oh!

gopherbot commented Nov 20, 2023

Uh oh!

gopherbot commented Nov 20, 2023

Uh oh!

gopherbot commented Nov 20, 2023

Uh oh!

gopherbot commented Nov 20, 2023

Uh oh!

gopherbot commented Nov 20, 2023

Uh oh!

gopherbot commented Nov 20, 2023

Uh oh!

gopherbot commented Nov 20, 2023

Uh oh!

gopherbot commented Nov 21, 2023

Uh oh!

gopherbot commented Nov 21, 2023

Uh oh!

gopherbot commented Nov 21, 2023

Uh oh!

gopherbot commented Nov 21, 2023

Uh oh!

gopherbot commented Nov 21, 2023

Uh oh!

gopherbot commented Nov 21, 2023

Uh oh!

gopherbot commented Nov 21, 2023

Uh oh!

gopherbot commented Nov 21, 2023

Uh oh!

gopherbot commented Nov 21, 2023

Uh oh!

gopherbot commented Nov 21, 2023

Uh oh!

gopherbot commented Nov 22, 2023

Uh oh!

Uh oh!