-
Notifications
You must be signed in to change notification settings - Fork 18.1k
net: handle the network parameter properly in LookupPort #63284
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
net: handle the network parameter properly in LookupPort #63284
Conversation
Change-Id: I33a7e7e7b0f224c222f7a3d5fb6e748d45f63df3
Change-Id: I3e1cf4a2e7ced677d1968f33a987935c67321374
This PR (HEAD: 19e3b6f) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/go/+/531635. Important tips:
|
Message from Gopher Robot: Patch Set 1: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/531635. |
This PR (HEAD: 1eda2b5) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/go/+/531635. Important tips:
|
Message from [email protected]: Patch Set 1: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/531635. |
Message from Mateusz Poliwczak: Patch Set 2: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/531635. |
Message from Mateusz Poliwczak: Patch Set 2: Run-TryBot+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/531635. |
Message from Gopher Robot: Patch Set 2: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/531635. |
Message from Gopher Robot: Patch Set 2: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/531635. |
Message from Gopher Robot: Patch Set 2: TryBot-Result-1 (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/531635. |
Message from Bryan Mills: Patch Set 2: (2 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/531635. |
Message from Bryan Mills: Patch Set 2: Code-Review+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/531635. |
23bb026
to
a73f23a
Compare
This PR (HEAD: a73f23a) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/go/+/531635. Important tips:
|
Message from Mateusz Poliwczak: Patch Set 3: Run-TryBot+1 (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/531635. |
Message from Gopher Robot: Patch Set 3: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/531635. |
Message from Gopher Robot: Patch Set 3: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/531635. |
Change-Id: Ie8175208c23c8e6e3e70885432284b7192d3fb94
This PR (HEAD: e587749) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/go/+/531635. Important tips:
|
Message from Mateusz Poliwczak: Patch Set 4: Run-TryBot+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/531635. |
Message from Gopher Robot: Patch Set 4: (2 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/531635. |
Message from Mateusz Poliwczak: Patch Set 4: (2 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/531635. |
Message from Gopher Robot: Patch Set 5: (2 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/531635. |
Message from Gopher Robot: Patch Set 5: TryBot-Result-1 (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/531635. |
Message from Mateusz Poliwczak: Patch Set 6: Run-TryBot+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/531635. |
Message from Gopher Robot: Patch Set 6: (2 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/531635. |
Message from Gopher Robot: Patch Set 6: TryBot-Result-1 (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/531635. |
Change-Id: Icc1638d4af92dd3107829f0dda19ef800a441b25
This PR (HEAD: f1abf40) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/go/+/531635. Important tips:
|
Message from Mateusz Poliwczak: Patch Set 7: Run-TryBot+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/531635. |
Message from Gopher Robot: Patch Set 7: (2 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/531635. |
Message from Gopher Robot: Patch Set 7: TryBot-Result-1 (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/531635. |
Change-Id: I18d1dd6f113a89d0bedb70b0967f0bd8b74e4be2
This PR (HEAD: 4299a83) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/go/+/531635. Important tips:
|
Message from Ian Lance Taylor: Patch Set 8: Run-TryBot+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/531635. |
Message from Gopher Robot: Patch Set 8: (2 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/531635. |
Message from Gopher Robot: Patch Set 8: TryBot-Result-1 (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/531635. |
Message from Mateusz Poliwczak: Patch Set 8: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/531635. |
Change-Id: I21db72b059e4ed702a406723cb4ea9fcfbb730cc
This PR (HEAD: 5ddb777) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/go/+/531635. Important tips:
|
Message from Mateusz Poliwczak: Patch Set 9: Run-TryBot+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/531635. |
Message from Gopher Robot: Patch Set 9: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/531635. |
Message from Gopher Robot: Patch Set 9: TryBot-Result-1 (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/531635. |
Change-Id: Iaf2674302ccbb2e4c69e4d56c337f614c542b31f
This PR (HEAD: eaa6163) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/go/+/531635. Important tips:
|
Message from Mateusz Poliwczak: Patch Set 10: Run-TryBot+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/531635. |
Message from Gopher Robot: Patch Set 10: (2 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/531635. |
Message from Mateusz Poliwczak: Patch Set 10: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/531635. |
Message from Gopher Robot: Patch Set 10: TryBot-Result+1 (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/531635. |
Message from David du Colombier: Patch Set 10: Code-Review+1 (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/531635. |
The cgo version (unix) is populating the GetAddrInfo hints based on the network parameter, but windows not quite. This change populates the hints the same way as the cgo unix version does now. This bug was spotted by Bryan in CL 530415. https://go-review.googlesource.com/c/go/+/530415/comment/76640dc7_ed0409ca/ Change-Id: I6fc29b1e4cdc879123ab0f5a624b6f37c68c00ba GitHub-Last-Rev: eaa6163 GitHub-Pull-Request: #63284 Reviewed-on: https://go-review.googlesource.com/c/go/+/531635 Reviewed-by: Ian Lance Taylor <[email protected]> Run-TryBot: Mateusz Poliwczak <[email protected]> Auto-Submit: Ian Lance Taylor <[email protected]> TryBot-Result: Gopher Robot <[email protected]> Reviewed-by: David du Colombier <[email protected]> Reviewed-by: Bryan Mills <[email protected]>
Message from Ian Lance Taylor: Patch Set 10: Auto-Submit+1 Code-Review+2 (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/531635. |
This PR is being closed because golang.org/cl/531635 has been merged. |
The cgo version (unix) is populating the GetAddrInfo hints
based on the network parameter, but windows not quite.
This change populates the hints the same way as the
cgo unix version does now.
This bug was spotted by Bryan in CL 530415.
https://go-review.googlesource.com/c/go/+/530415/comment/76640dc7_ed0409ca/