Skip to content

io/ioutil: add doc links for deprecated function #58779

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

io/ioutil: add doc links for deprecated function #58779

wants to merge 1 commit into from

Conversation

SilverRainZ
Copy link
Contributor

@SilverRainZ SilverRainZ commented Feb 28, 2023 •
edited by dmitshur
Loading

Go 1.19 introduced doc links (https://go.dev/doc/comment#doclinks).
It will be convenient when we can directly jump to the suggested
function when the original function is deprecated.

@SilverRainZ
io/ioutil: add doc links for deprecated function
b2aa85b 
Go1.19 introduced [doc link](https://go.dev/doc/comment#doclinks), It
will be convenient when we can directly jump to the suggested function
when the original function is deprecated.
@SilverRainZ SilverRainZ changed the title io/iotuil: add doc links for deprecated function io/ioutil: add doc links for deprecated function Feb 28, 2023
@gopherbot
Copy link
Contributor

This PR (HEAD: b2aa85b) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/go/+/471915 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot
Copy link
Contributor

Message from Ian Lance Taylor:

Patch Set 1: Auto-Submit+1 Code-Review+2 Run-TryBot+1

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/471915.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Gopher Robot:

Patch Set 1:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/471915.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Gopher Robot:

Patch Set 1: TryBot-Result+1

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/471915.
After addressing review feedback, remember to publish your drafts!

gopherbot pushed a commit that referenced this pull request Feb 28, 2023
@SilverRainZ @gopherbot
io/ioutil: add doc links for deprecated function
dfe4591 
Go 1.19 introduced doc links (https://go.dev/doc/comment#doclinks).
It will be convenient when we can directly jump to the suggested
function when the original function is deprecated.

Change-Id: I6172a5265f3b47aefec53179bca60f9904606b3f
GitHub-Last-Rev: b2aa85b
GitHub-Pull-Request: #58779
Reviewed-on: https://go-review.googlesource.com/c/go/+/471915
Run-TryBot: Ian Lance Taylor <[email protected]>
Reviewed-by: Ian Lance Taylor <[email protected]>
Auto-Submit: Dmitri Shuralyov <[email protected]>
TryBot-Result: Gopher Robot <[email protected]>
Reviewed-by: Dmitri Shuralyov <[email protected]>
@dmitshur
Copy link
Member

dmitshur commented Mar 5, 2023

Closing because this PR has been merged via CL 471915 as commit dfe4591.

(Normally gerritbot does this, but sometimes it needs help due to #35867.)

@dmitshur dmitshur closed this Mar 5, 2023
@dmitshur dmitshur mentioned this pull request Mar 5, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@SilverRainZ @gopherbot @dmitshur