runtime: fix cpu sample comment #58338

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Closed

subtle-byte wants to merge 1 commit into golang:master from subtle-byte:fix-cpu-sample-comment

Contributor

subtle-byte commented Feb 5, 2023

Fixes #58327


          runtime: fix cpu sample comment

7e0d04b

Contributor

gopherbot commented Feb 5, 2023

This PR (HEAD: 7e0d04b) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/go/+/465335 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

Contributor

gopherbot commented Feb 5, 2023

Message from Gopher Robot:

Patch Set 1:

Congratulations on opening your first change. Thank you for your contribution!

Next steps:
A maintainer will review your change and provide feedback. See
https://go.dev/doc/contribute#review for more info and tips to get your
patch through code review.

Most changes in the Go project go through a few rounds of revision. This can be
surprising to people new to the project. The careful, iterative review process
is our way of helping mentor contributors and ensuring that their contributions
have a lasting impact.

During May-July and Nov-Jan the Go project is in a code freeze, during which
little code gets reviewed or merged. If a reviewer responds with a comment like
R=go1.11 or adds a tag like "wait-release", it means that this CL will be
reviewed as part of the next development cycle. See https://go.dev/s/release
for more details.

Please don’t reply on this GitHub thread. Visit golang.org/cl/465335.
After addressing review feedback, remember to publish your drafts!

Contributor

gopherbot commented Feb 6, 2023

Message from David Chase:

Patch Set 1: Code-Review+1

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/465335.
After addressing review feedback, remember to publish your drafts!

Contributor

gopherbot commented Feb 6, 2023

Message from Michael Knyszek:

Patch Set 1: Code-Review+2 Run-TryBot+1

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/465335.
After addressing review feedback, remember to publish your drafts!

Contributor

gopherbot commented Feb 6, 2023

Message from Michael Knyszek:

Patch Set 1: Auto-Submit+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/465335.
After addressing review feedback, remember to publish your drafts!

Contributor

gopherbot commented Feb 6, 2023

Message from Gopher Robot:

Patch Set 1:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/465335.
After addressing review feedback, remember to publish your drafts!

gopherbot pushed a commit that referenced this pull request


          runtime: fix cpu sample comment

02d8ebd

Fixes #58327

Change-Id: I15593e6ee42e04f2de13804ef26e0e66a2307db0
GitHub-Last-Rev: 7e0d04b
GitHub-Pull-Request: #58338
Reviewed-on: https://go-review.googlesource.com/c/go/+/465335
Reviewed-by: Michael Knyszek <[email protected]>
Run-TryBot: Michael Knyszek <[email protected]>
Auto-Submit: Michael Knyszek <[email protected]>
Reviewed-by: David Chase <[email protected]>
TryBot-Result: Gopher Robot <[email protected]>

Contributor

gopherbot commented Feb 6, 2023

This PR is being closed because golang.org/cl/465335 has been merged.

gopherbot closed this

johanbrandhorst pushed a commit to Pryz/go that referenced this pull request


          runtime: fix cpu sample comment

71d7e5b

Fixes golang#58327

Change-Id: I15593e6ee42e04f2de13804ef26e0e66a2307db0
GitHub-Last-Rev: 7e0d04b
GitHub-Pull-Request: golang#58338
Reviewed-on: https://go-review.googlesource.com/c/go/+/465335
Reviewed-by: Michael Knyszek <[email protected]>
Run-TryBot: Michael Knyszek <[email protected]>
Auto-Submit: Michael Knyszek <[email protected]>
Reviewed-by: David Chase <[email protected]>
TryBot-Result: Gopher Robot <[email protected]>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet