os: use GetTempPath2 on Windows if available #57980
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
nwnt
force-pushed
the
os-tempdir-windows-gettemppath2
branch
from
214628f to
eb3dacf
Compare
|
This PR (HEAD: eb3dacf) has been imported to Gerrit for code review. Please visit https://go-review.googlesource.com/c/go/+/463219 to see it. Tip: You can toggle comments from me using the |
|
Message from Quim Muntal: Patch Set 1: Run-TryBot+1 (3 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/463219. |
|
Message from Gopher Robot: Patch Set 1: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/463219. |
|
Message from Gopher Robot: Patch Set 1: TryBot-Result+1 (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/463219. |
|
Message from Bryan Mills: Patch Set 1: Code-Review+1 (3 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/463219. |
|
Message from Damien Neil: Patch Set 1: (4 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/463219. |
nwnt
force-pushed
the
os-tempdir-windows-gettemppath2
branch
from
eb3dacf to
34a8a96
Compare
|
This PR (HEAD: 34a8a96) has been imported to Gerrit for code review. Please visit https://go-review.googlesource.com/c/go/+/463219 to see it. Tip: You can toggle comments from me using the |
nwnt
force-pushed
the
os-tempdir-windows-gettemppath2
branch
from
34a8a96 to
152a736
Compare
|
This PR (HEAD: 152a736) has been imported to Gerrit for code review. Please visit https://go-review.googlesource.com/c/go/+/463219 to see it. Tip: You can toggle comments from me using the |
nwnt
force-pushed
the
os-tempdir-windows-gettemppath2
branch
from
152a736 to
97b83bc
Compare
nwnt
changed the title
|
This PR (HEAD: 97b83bc) has been imported to Gerrit for code review. Please visit https://go-review.googlesource.com/c/go/+/463219 to see it. Tip: You can toggle comments from me using the |
|
If the Gerrit comments have been addressed, please mark them as resolved in Gerrit (and don't forget to publish the replies). |
This generates GetTempPath2. Go now tries to determine if the windows it runs on has GetTempPath2 by finding it only once at the loading time. If GetTempPath2 exists, it sets the flag so that any calls to tempDir will use it. If it doesn't exist, Go then uses GetTempPath. GetTempPath2 was generated into internal/syscall/windows since syscall is locked down. Fixes golang#56899
nwnt
force-pushed
the
os-tempdir-windows-gettemppath2
branch
from
97b83bc to
b779389
Compare
|
This PR (HEAD: b779389) has been imported to Gerrit for code review. Please visit https://go-review.googlesource.com/c/go/+/463219 to see it. Tip: You can toggle comments from me using the |
|
Message from Thanonchai W: Patch Set 5: (8 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/463219. |
|
Message from Quim Muntal: Patch Set 5: Code-Review+2 Run-TryBot+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/463219. |
|
Message from Gopher Robot: Patch Set 5: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/463219. |
|
Message from Gopher Robot: Patch Set 5: TryBot-Result+1 (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/463219. |
|
Message from Dmitri Shuralyov: Patch Set 5: Code-Review+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/463219. |
This generates GetTempPath2. Go now tries to determine if the windows it runs on has GetTempPath2 by finding it only once at the loading time. If GetTempPath2 exists, it sets the flag so that any calls to tempDir will use it. If it doesn't exist, Go then uses GetTempPath. GetTempPath2 was generated into internal/syscall/windows since syscall is locked down. Fixes #56899 Change-Id: Iff08502aebc787fde802ee9496c070c982fbdc08 GitHub-Last-Rev: b779389 GitHub-Pull-Request: #57980 Reviewed-on: https://go-review.googlesource.com/c/go/+/463219 Run-TryBot: Quim Muntal <[email protected]> TryBot-Result: Gopher Robot <[email protected]> Reviewed-by: Bryan Mills <[email protected]> Reviewed-by: Quim Muntal <[email protected]> Reviewed-by: Dmitri Shuralyov <[email protected]>
|
This PR is being closed because golang.org/cl/463219 has been merged. |
This generates GetTempPath2. Go now tries to determine if the windows it runs on has GetTempPath2 by finding it only once at the loading time. If GetTempPath2 exists, it sets the flag so that any calls to tempDir will use it. If it doesn't exist, Go then uses GetTempPath.
GetTempPath2 was generated into internal/syscall/windows since syscall is locked down.
Fixes #56899