Skip to content

os: use GetTempPath2 on Windows if available #57833

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 0 commits into from

Conversation

nwnt
Copy link
Contributor

@nwnt nwnt commented Jan 17, 2023

This generates GetTempPath2 together with RtlGetNtVersionNumbers. The latter is needed to determine if the running Windows has GetTempPath2 by comparing it against the minimum build number that has the API.

RtlGetNtVersionNumbers was generated into syscall/windows since syscall is locked down.

Fixes #56899

@kaixuanfeng
Copy link

kaixuanfeng commented Jan 17, 2023 via email

@gopherbot
Copy link
Contributor

This PR (HEAD: 9e097be) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/go/+/462052 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot
Copy link
Contributor

Message from Gopher Robot:

Patch Set 1:

Congratulations on opening your first change. Thank you for your contribution!

Next steps:
A maintainer will review your change and provide feedback. See
https://go.dev/doc/contribute#review for more info and tips to get your
patch through code review.

Most changes in the Go project go through a few rounds of revision. This can be
surprising to people new to the project. The careful, iterative review process
is our way of helping mentor contributors and ensuring that their contributions
have a lasting impact.

During May-July and Nov-Jan the Go project is in a code freeze, during which
little code gets reviewed or merged. If a reviewer responds with a comment like
R=go1.11 or adds a tag like "wait-release", it means that this CL will be
reviewed as part of the next development cycle. See https://go.dev/s/release
for more details.


Please don’t reply on this GitHub thread. Visit golang.org/cl/462052.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Quim Muntal:

Patch Set 1:

(2 comments)


Please don’t reply on this GitHub thread. Visit golang.org/cl/462052.
After addressing review feedback, remember to publish your drafts!

@nwnt nwnt closed this Jan 24, 2023
@nwnt nwnt force-pushed the os-tempdir-windows-gettemppath2 branch from 9e097be to 707f888 Compare January 24, 2023 00:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

os: TempDir should use GetTempPath2 when available on Windows
3 participants