Skip to content

cmd/go/internal: use strings.CutSuffix #55830

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

cmd/go/internal: use strings.CutSuffix #55830

wants to merge 1 commit into from

Conversation

cuishuang
Copy link
Contributor

@cuishuang cuishuang commented Sep 23, 2022 •
edited
Loading

Updates #42537

@gopherbot
Copy link
Contributor

This PR (HEAD: fd2a33b) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/go/+/433275 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@cuishuang cuishuang changed the title cmd/go/internal: use the newly added strings.CutSuffix method to opti… cmd/go/internal: use the newly added strings.CutSuffix method to optimize the code Sep 23, 2022
@cuishuang cuishuang changed the title cmd/go/internal: use the newly added strings.CutSuffix method to optimize the code cmd/go/internal: use strings.CutSuffix Sep 23, 2022
@gopherbot
Copy link
Contributor

Message from Benny Siegert:

Patch Set 4: Run-TryBot+1 Code-Review+2

Please don’t reply on this GitHub thread. Visit golang.org/cl/433275.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Gopher Robot:

Patch Set 4:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/433275.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Gopher Robot:

Patch Set 4:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/433275.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Gopher Robot:

Patch Set 4: TryBot-Result-1

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/433275.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Joel Sing:

Patch Set 4:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/433275.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

This PR (HEAD: a87597d) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/go/+/433275 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@cuishuang cuishuang changed the title cmd/go/internal: use strings.CutSuffix cmd/go/internal: use strings.CutSuffix Sep 27, 2022
@gopherbot
Copy link
Contributor

Message from shuang cui:

Patch Set 4:

(2 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/433275.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from shuang cui:

Patch Set 4:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/433275.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from shuang cui:

Patch Set 4:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/433275.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Ian Lance Taylor:

Patch Set 6: Run-TryBot+1 Auto-Submit+1 Code-Review+2

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/433275.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Gopher Robot:

Patch Set 6:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/433275.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

This PR is being closed because golang.org/cl/433275 has been merged.

@gopherbot gopherbot closed this Sep 27, 2022
gopherbot pushed a commit that referenced this pull request Sep 27, 2022
@cuishuang @gopherbot
cmd/go/internal: use strings.CutSuffix
48a58c5 
Updates #42537

Change-Id: I2d4c5e911c8a2ddfe9a976896b05d3cd8be61f6b
GitHub-Last-Rev: a87597d
GitHub-Pull-Request: #55830
Reviewed-on: https://go-review.googlesource.com/c/go/+/433275
TryBot-Result: Gopher Robot <[email protected]>
Reviewed-by: Ian Lance Taylor <[email protected]>
Auto-Submit: Ian Lance Taylor <[email protected]>
Reviewed-by: Benny Siegert <[email protected]>
Run-TryBot: Ian Lance Taylor <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cuishuang @gopherbot