all: use strings.CutPrefix #55347

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Closed

cuishuang wants to merge 1 commit into golang:master from jiangzhehu:master

Contributor

cuishuang commented Sep 22, 2022 •

edited

Loading

Updates #42537


          all: use the newly added strings.CutPrefix method to optimize the code

0d65208

Signed-off-by: cui fliter <[email protected]>

Contributor

gopherbot commented Sep 22, 2022

This PR (HEAD: 0d65208) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/go/+/432895 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

cuishuang changed the title ~~all: use the newly added strings.CutPrefix method to optimize the code~~ all: use strings.CutPrefix

Contributor

gopherbot commented Sep 26, 2022

Message from Ian Lance Taylor:

Patch Set 4: Run-TryBot+1

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/432895.
After addressing review feedback, remember to publish your drafts!

Contributor

gopherbot commented Sep 26, 2022

Message from Gopher Robot:

Patch Set 4:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/432895.
After addressing review feedback, remember to publish your drafts!

Contributor

gopherbot commented Sep 26, 2022

Message from Gopher Robot:

Patch Set 4: TryBot-Result+1

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/432895.
After addressing review feedback, remember to publish your drafts!

cuishuang changed the title ~~all: use strings.CutPrefix~~ all: use strings.CutPrefix

Contributor

gopherbot commented Sep 27, 2022

Message from shuang cui:

Patch Set 4:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/432895.
After addressing review feedback, remember to publish your drafts!

Contributor

gopherbot commented Sep 27, 2022

Message from shuang cui:

Patch Set 5:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/432895.
After addressing review feedback, remember to publish your drafts!

Contributor

gopherbot commented Sep 27, 2022

Message from Ian Lance Taylor:

Patch Set 5: Run-TryBot+1 Auto-Submit+1 Code-Review+2

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/432895.
After addressing review feedback, remember to publish your drafts!

gopherbot pushed a commit that referenced this pull request


          all: use strings.CutPrefix

361f5eb

Updates #42537

Change-Id: Ice23d7d36bbede27551cbc086119694f6a3b5e4a
GitHub-Last-Rev: 0d65208
GitHub-Pull-Request: #55347
Reviewed-on: https://go-review.googlesource.com/c/go/+/432895
Reviewed-by: Benny Siegert <[email protected]>
Auto-Submit: Ian Lance Taylor <[email protected]>
Run-TryBot: Ian Lance Taylor <[email protected]>
Reviewed-by: Ian Lance Taylor <[email protected]>
Run-TryBot: Ian Lance Taylor <[email protected]>
TryBot-Result: Gopher Robot <[email protected]>

Contributor

gopherbot commented Sep 27, 2022

Message from Benny Siegert:

Patch Set 5: Code-Review+2

Please don’t reply on this GitHub thread. Visit golang.org/cl/432895.
After addressing review feedback, remember to publish your drafts!

Contributor

gopherbot commented Sep 27, 2022

This PR is being closed because golang.org/cl/432895 has been merged.

gopherbot closed this

mateusz834 pushed a commit to mateusz834/tgoast that referenced this pull request


          all: use strings.CutPrefix

5ecf259

Updates #42537

Change-Id: Ice23d7d36bbede27551cbc086119694f6a3b5e4a
GitHub-Last-Rev: 0d65208313ea318725159186fad045fc6400fb25
GitHub-Pull-Request: golang/go#55347
Reviewed-on: https://go-review.googlesource.com/c/go/+/432895
Reviewed-by: Benny Siegert <[email protected]>
Auto-Submit: Ian Lance Taylor <[email protected]>
Run-TryBot: Ian Lance Taylor <[email protected]>
Reviewed-by: Ian Lance Taylor <[email protected]>
Run-TryBot: Ian Lance Taylor <[email protected]>
TryBot-Result: Gopher Robot <[email protected]>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet