Revert "net/http: close accepted connection" #52823

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Closed

AlexanderYastrebov wants to merge 1 commit into golang:master from AlexanderYastrebov:revert-close-accepted-connection

Contributor

AlexanderYastrebov commented May 10, 2022 •

edited

Loading

This reverts commit 1ce7fcf.

The change closes accepted connection also in graceful shutdown which
breaks the fix for #33313 (and apparent duplicate #36819).

The proper fix should close accepted connection only if server is closed
but not in graceful shutdown.

Updates #48642


          Revert "net/http: close accepted connection"

f6d885a

This reverts commit 1ce7fcf.

The change closes accepted connection also in graceful shutdown which
breaks the fix for golang#33313 (and apparent duplicate golang#36819).

The proper fix should close accepted connection only if server is closed
but not in graceful shutdown.

Updates golang#48642

AlexanderYastrebov mentioned this pull request

net/http: Server.Close may not able to close all connections #48642

Closed

Contributor

gopherbot commented May 10, 2022

This PR (HEAD: f6d885a) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/go/+/405454 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

Contributor

gopherbot commented May 11, 2022

Message from Damien Neil:

Patch Set 1: Code-Review+2

Please don’t reply on this GitHub thread. Visit golang.org/cl/405454.
After addressing review feedback, remember to publish your drafts!

Contributor

gopherbot commented May 11, 2022

Message from Ian Lance Taylor:

Patch Set 2: Commit message was updated.

Please don’t reply on this GitHub thread. Visit golang.org/cl/405454.
After addressing review feedback, remember to publish your drafts!

Contributor

gopherbot commented May 11, 2022

Message from Ian Lance Taylor:

Patch Set 2: Run-TryBot+1 Auto-Submit+1 Code-Review+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/405454.
After addressing review feedback, remember to publish your drafts!

Contributor

gopherbot commented May 11, 2022

Message from Gopher Robot:

Patch Set 2:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/405454.
After addressing review feedback, remember to publish your drafts!

Contributor

gopherbot commented May 11, 2022

Message from Ian Lance Taylor:

Patch Set 3: Run-TryBot+1 Code-Review+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/405454.
After addressing review feedback, remember to publish your drafts!

Contributor

gopherbot commented May 11, 2022

Message from Gopher Robot:

Patch Set 3:

(2 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/405454.
After addressing review feedback, remember to publish your drafts!

Contributor

gopherbot commented May 11, 2022

Message from Gopher Robot:

Patch Set 3: TryBot-Result+1

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/405454.
After addressing review feedback, remember to publish your drafts!

gopherbot pushed a commit that referenced this pull request


          Revert "net/http: close accepted connection"

c14ed5b

This reverts CL 353714.

The change closes accepted connection also in graceful shutdown which
breaks the fix for #33313 (and apparent duplicate #36819).

The proper fix should close accepted connection only if server is closed
but not in graceful shutdown.

Updates #48642

Change-Id: I2f7005f3f3037e6563745731bb2693923b654004
GitHub-Last-Rev: f6d885a
GitHub-Pull-Request: #52823
Reviewed-on: https://go-review.googlesource.com/c/go/+/405454
Reviewed-by: Damien Neil <[email protected]>
Reviewed-by: Ian Lance Taylor <[email protected]>

Contributor

gopherbot commented May 11, 2022

Message from Ian Lance Taylor:

Patch Set 4: Commit message was updated.

Please don’t reply on this GitHub thread. Visit golang.org/cl/405454.
After addressing review feedback, remember to publish your drafts!

Contributor

gopherbot commented May 11, 2022

This PR is being closed because golang.org/cl/405454 has been merged.

gopherbot closed this

dteh pushed a commit to dteh/fhttp that referenced this pull request


          Revert "net/http: close accepted connection"

26034b5

This reverts CL 353714.

The change closes accepted connection also in graceful shutdown which
breaks the fix for #33313 (and apparent duplicate #36819).

The proper fix should close accepted connection only if server is closed
but not in graceful shutdown.

Updates #48642

Change-Id: I2f7005f3f3037e6563745731bb2693923b654004
GitHub-Last-Rev: f6d885aa37e793811c1624f73a3d90bc733db048
GitHub-Pull-Request: golang/go#52823
Reviewed-on: https://go-review.googlesource.com/c/go/+/405454
Reviewed-by: Damien Neil <[email protected]>
Reviewed-by: Ian Lance Taylor <[email protected]>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet