net/http/httputil: allow MIME parameters when detecting SSE in ReverseProxy #48427

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Closed

jmalloc wants to merge 1 commit into golang:master from jmalloc:parse-sse-media-type

Contributor

jmalloc commented Sep 17, 2021

This change allows httputil.ReverseProxy to detect SSE (server-sent events)
content when the response's Content-Type header includes MIME parameters,
such as "text/event-stream;charset=utf-8".

Prior to this change the value of the Content-Type header was compared
directly to the literal "text/event-stream". This caused a false-negative
which failed to set the FlushInterval correctly when MIME parameters were
present.


          Allow MIME parameters when detecting SSE content.

224518c

This change allows httputil.ReverseProxy to detect SSE (server-sent events)
content when the response's Content-Type header includes MIME parameters, such
as "text/event-stream;charset=utf-8".

Prior to this change the value of the Content-Type header was compared directly
to the literal "text/event-stream". This caused a false-negative which failed to
set the FlushInterval correctly when MIME parameters were present.

google-cla bot added the cla: yes label

ezzatron mentioned this pull request

Strange behaviour when trying to use server-sent events (SSE) - possibly compression related? antoniomika/sish#192

Closed

Contributor

gopherbot commented Sep 17, 2021

This PR (HEAD: 224518c) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/go/+/350509 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

Contributor

gopherbot commented Sep 17, 2021

Message from Go Bot:

Patch Set 1:

Congratulations on opening your first change. Thank you for your contribution!

Next steps:
A maintainer will review your change and provide feedback. See
https://golang.org/doc/contribute.html#review for more info and tips to get your
patch through code review.

Most changes in the Go project go through a few rounds of revision. This can be
surprising to people new to the project. The careful, iterative review process
is our way of helping mentor contributors and ensuring that their contributions
have a lasting impact.

During May-July and Nov-Jan the Go project is in a code freeze, during which
little code gets reviewed or merged. If a reviewer responds with a comment like
R=go1.11 or adds a tag like "wait-release", it means that this CL will be
reviewed as part of the next development cycle. See https://golang.org/s/release
for more details.

Please don’t reply on this GitHub thread. Visit golang.org/cl/350509.
After addressing review feedback, remember to publish your drafts!

jmalloc mentioned this pull request

SSE (server-sent events) support. dogmatiq/protean#14

Open

Contributor

gopherbot commented Oct 8, 2021

Message from Damien Neil:

Patch Set 1: Run-TryBot+1 Code-Review+2 Trust+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/350509.
After addressing review feedback, remember to publish your drafts!

Contributor

gopherbot commented Oct 8, 2021

Message from Go Bot:

Patch Set 1:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/350509.
After addressing review feedback, remember to publish your drafts!

Contributor

gopherbot commented Oct 8, 2021

Message from Go Bot:

Patch Set 1:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/350509.
After addressing review feedback, remember to publish your drafts!

Contributor

gopherbot commented Oct 8, 2021

Message from Go Bot:

Patch Set 1: TryBot-Result-1

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/350509.
After addressing review feedback, remember to publish your drafts!

Contributor

gopherbot commented Oct 12, 2021

Message from James Harris:

Patch Set 1:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/350509.
After addressing review feedback, remember to publish your drafts!

Contributor

gopherbot commented Oct 13, 2021

Message from Alexander Rakoczy:

Patch Set 2: Patch Set 1 was rebased

Please don’t reply on this GitHub thread. Visit golang.org/cl/350509.
After addressing review feedback, remember to publish your drafts!

Contributor

gopherbot commented Oct 13, 2021

Message from Alexander Rakoczy:

Patch Set 2: Run-TryBot+1 Trust+1

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/350509.
After addressing review feedback, remember to publish your drafts!

Contributor

gopherbot commented Oct 13, 2021

Message from Go Bot:

Patch Set 2:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/350509.
After addressing review feedback, remember to publish your drafts!

Contributor

gopherbot commented Oct 13, 2021

Message from Go Bot:

Patch Set 2: TryBot-Result+1

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/350509.
After addressing review feedback, remember to publish your drafts!

gopherbot pushed a commit that referenced this pull request


          net/http/httputil: allow MIME parameters when detecting SSE in Revers…

4a3daee

…eProxy

This change allows httputil.ReverseProxy to detect SSE (server-sent events)
content when the response's Content-Type header includes MIME parameters,
such as "text/event-stream;charset=utf-8".

Prior to this change the value of the Content-Type header was compared
directly to the literal "text/event-stream". This caused a false-negative
which failed to set the FlushInterval correctly when MIME parameters were
present.

Change-Id: If8bb43efb78787b6519d7fe7599ca018a0da0023
GitHub-Last-Rev: 224518c
GitHub-Pull-Request: #48427
Reviewed-on: https://go-review.googlesource.com/c/go/+/350509
Trust: Alexander Rakoczy <[email protected]>
Trust: Damien Neil <[email protected]>
Run-TryBot: Alexander Rakoczy <[email protected]>
TryBot-Result: Go Bot <[email protected]>
Reviewed-by: Damien Neil <[email protected]>

Contributor

gopherbot commented Oct 13, 2021

This PR is being closed because golang.org/cl/350509 has been merged.

gopherbot closed this

bassosimone pushed a commit to ooni/oohttp that referenced this pull request


          net/http/httputil: allow MIME parameters when detecting SSE in Revers…

6a2aa2d

…eProxy

This change allows httputil.ReverseProxy to detect SSE (server-sent events)
content when the response's Content-Type header includes MIME parameters,
such as "text/event-stream;charset=utf-8".

Prior to this change the value of the Content-Type header was compared
directly to the literal "text/event-stream". This caused a false-negative
which failed to set the FlushInterval correctly when MIME parameters were
present.

Change-Id: If8bb43efb78787b6519d7fe7599ca018a0da0023
GitHub-Last-Rev: 224518c5eb9686ee050c79f5f853ebacfdf6fc42
GitHub-Pull-Request: golang/go#48427
Reviewed-on: https://go-review.googlesource.com/c/go/+/350509
Trust: Alexander Rakoczy <[email protected]>
Trust: Damien Neil <[email protected]>
Run-TryBot: Alexander Rakoczy <[email protected]>
TryBot-Result: Go Bot <[email protected]>
Reviewed-by: Damien Neil <[email protected]>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels