test/bench/go1: fix size for RegexpMatchMedium_32 #47254

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Closed

nimelehin wants to merge 1 commit into golang:master from nimelehin:test_regexp_fix

Contributor

nimelehin commented Jul 16, 2021

No description provided.


          test/bench/go1: fix size for RegexpMatchMedium_32

ae9014b

google-cla bot added the cla: yes label

Contributor

gopherbot commented Jul 16, 2021

This PR (HEAD: ae9014b) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/go/+/335189 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

Contributor

gopherbot commented Jul 16, 2021

Message from Go Bot:

Patch Set 1:

Congratulations on opening your first change. Thank you for your contribution!

Next steps:
A maintainer will review your change and provide feedback. See
https://golang.org/doc/contribute.html#review for more info and tips to get your
patch through code review.

Most changes in the Go project go through a few rounds of revision. This can be
surprising to people new to the project. The careful, iterative review process
is our way of helping mentor contributors and ensuring that their contributions
have a lasting impact.

During May-July and Nov-Jan the Go project is in a code freeze, during which
little code gets reviewed or merged. If a reviewer responds with a comment like
R=go1.11 or adds a tag like "wait-release", it means that this CL will be
reviewed as part of the next development cycle. See https://golang.org/s/release
for more details.

Please don’t reply on this GitHub thread. Visit golang.org/cl/335189.
After addressing review feedback, remember to publish your drafts!

Contributor

gopherbot commented Jul 17, 2021

Message from Rob Pike:

Patch Set 1: Code-Review+2

Please don’t reply on this GitHub thread. Visit golang.org/cl/335189.
After addressing review feedback, remember to publish your drafts!

Contributor

gopherbot commented Jul 17, 2021

Message from Rob Pike:

Patch Set 1: Run-TryBot+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/335189.
After addressing review feedback, remember to publish your drafts!

Contributor

gopherbot commented Jul 17, 2021

Message from Go Bot:

Patch Set 1:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/335189.
After addressing review feedback, remember to publish your drafts!

Contributor

gopherbot commented Jul 17, 2021

Message from Go Bot:

Patch Set 1: TryBot-Result+1

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/335189.
After addressing review feedback, remember to publish your drafts!

mmdbalkhi approved these changes

View reviewed changes

Contributor

gopherbot commented Jul 17, 2021

Message from Alberto Donizetti:

Patch Set 1: Trust+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/335189.
After addressing review feedback, remember to publish your drafts!

gopherbot pushed a commit that referenced this pull request


          test/bench/go1: fix size for RegexpMatchMedium_32

a66190e

Change-Id: Idc67abb95248bc010820a89dd6096a2da334e723
GitHub-Last-Rev: ae9014b
GitHub-Pull-Request: #47254
Reviewed-on: https://go-review.googlesource.com/c/go/+/335189
Reviewed-by: Rob Pike <[email protected]>
Run-TryBot: Rob Pike <[email protected]>
TryBot-Result: Go Bot <[email protected]>
Trust: Alberto Donizetti <[email protected]>

Contributor

gopherbot commented Jul 18, 2021

This PR is being closed because golang.org/cl/335189 has been merged.

gopherbot closed this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels