Skip to content

net/http: correct capitalization in cancelTimeBody comment #47160

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

net/http: correct capitalization in cancelTimeBody comment #47160

wants to merge 1 commit into from

Conversation

shota3506
Copy link
Contributor

@shota3506 shota3506 commented Jul 13, 2021 •
edited
Loading

No description provided.

@google-cla google-cla bot added the cla: yes Used by googlebot to label PRs as having a valid CLA. The text of this label should not change. label Jul 13, 2021
@gopherbot
Copy link
Contributor

This PR (HEAD: abe9c49) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/go/+/334229 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot
Copy link
Contributor

Message from Ian Lance Taylor:

Patch Set 1:

(2 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/334229.
After addressing review feedback, remember to publish your drafts!

@shota3506 shota3506 changed the title net/http: fix comment on cancelTimeBody net/http: correct capitalization in cancelTimeBody comment Jul 13, 2021
@shota3506 shota3506 force-pushed the capitalize-comment-in-http-client branch from abe9c49 to 3e5c022 Compare July 13, 2021 21:26
@gopherbot
Copy link
Contributor

This PR (HEAD: 3e5c022) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/go/+/334229 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot
Copy link
Contributor

Message from Shota Sugiura:

Patch Set 3:

(2 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/334229.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Ian Lance Taylor:

Patch Set 3: Code-Review+2

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/334229.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Cherry Mui:

Patch Set 3: Trust+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/334229.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Ian Lance Taylor:

Patch Set 3: Run-TryBot+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/334229.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Go Bot:

Patch Set 3:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/334229.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Go Bot:

Patch Set 3: TryBot-Result-1

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/334229.
After addressing review feedback, remember to publish your drafts!

gopherbot pushed a commit that referenced this pull request Jul 16, 2021
@shota3506 @ianlancetaylor
net/http: correct capitalization in cancelTimeBody comment
aa4e0f5 
Change-Id: I7acda22c01c5350ebf5ddabb1c12af96d368de5d
GitHub-Last-Rev: 3e5c022
GitHub-Pull-Request: #47160
Reviewed-on: https://go-review.googlesource.com/c/go/+/334229
Reviewed-by: Ian Lance Taylor <[email protected]>
Trust: Cherry Mui <[email protected]>
Run-TryBot: Ian Lance Taylor <[email protected]>
@gopherbot
Copy link
Contributor

This PR is being closed because golang.org/cl/334229 has been merged.

@gopherbot gopherbot closed this Jul 16, 2021
@ferrmin ferrmin mentioned this pull request Jul 16, 2021
Merged
bassosimone pushed a commit to ooni/oohttp that referenced this pull request Aug 31, 2021
@shota3506 @ianlancetaylor
net/http: correct capitalization in cancelTimeBody comment
74c0b7f 
Change-Id: I7acda22c01c5350ebf5ddabb1c12af96d368de5d
GitHub-Last-Rev: 3e5c022f8764d4abf91c964ceb4fc0e01ebd1352
GitHub-Pull-Request: golang/go#47160
Reviewed-on: https://go-review.googlesource.com/c/go/+/334229
Reviewed-by: Ian Lance Taylor <[email protected]>
Trust: Cherry Mui <[email protected]>
Run-TryBot: Ian Lance Taylor <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
cla: yes Used by googlebot to label PRs as having a valid CLA. The text of this label should not change.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@shota3506 @gopherbot