-
Notifications
You must be signed in to change notification settings - Fork 18k
net: only perform IPv4 map check for AF_INET6 sockets #45155
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This change avoids executing syscalls testing if IPv4 address mapping is possible unless the socket being opened belongs to the AF_INET6 family. In a pledged OpenBSD process, this test is only allowed when the "inet" pledge is granted; however this check was also being performed for AF_UNIX sockets (separately permitted under the "unix" pledge), and would cause the process to be killed by the kernel. By avoiding the IPv4 address mapping check until the socket is checked to be AF_INET6, a pledged OpenBSD process using AF_UNIX sockets without the "inet" pledge won't be killed for this misbehavior. The OpenBSD kernel is not currently ready to support using UNIX domain sockets with only the "unix" pledge (and without "inet"), but this is one change necessary to support this.
For the OpenBSD kernel patch which is also needed to try this, see https://marc.info/?l=openbsd-tech&m=161221087502321&w=2 |
This PR (HEAD: 3c5541b) has been imported to Gerrit for code review. Please visit https://go-review.googlesource.com/c/go/+/303276 to see it. Tip: You can toggle comments from me using the |
Message from Go Bot: Patch Set 1: Congratulations on opening your first change. Thank you for your contribution! Next steps: Most changes in the Go project go through a few rounds of revision. This can be During May-July and Nov-Jan the Go project is in a code freeze, during which Please don’t reply on this GitHub thread. Visit golang.org/cl/303276. |
Message from Josh Rickmar: Patch Set 1: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/303276. |
Message from Tobias Klauser: Patch Set 2: Run-TryBot+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/303276. |
Message from Go Bot: Patch Set 2: TryBots beginning. Status page: https://farmer.golang.org/try?commit=92dfbe1b Please don’t reply on this GitHub thread. Visit golang.org/cl/303276. |
Message from Go Bot: Patch Set 2: TryBot-Result+1 TryBots are happy. Please don’t reply on this GitHub thread. Visit golang.org/cl/303276. |
Message from Tobias Klauser: Patch Set 2: Code-Review+2 (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/303276. |
Message from Aaron Bieber: Patch Set 2: Code-Review+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/303276. |
This change avoids executing syscalls testing if IPv4 address mapping is possible unless the socket being opened belongs to the AF_INET6 family. In a pledged OpenBSD process, this test is only allowed when the "inet" pledge is granted; however this check was also being performed for AF_UNIX sockets (separately permitted under the "unix" pledge), and would cause the process to be killed by the kernel. By avoiding the IPv4 address mapping check until the socket is checked to be AF_INET6, a pledged OpenBSD process using AF_UNIX sockets without the "inet" pledge won't be killed for this misbehavior. The OpenBSD kernel is not currently ready to support using UNIX domain sockets with only the "unix" pledge (and without "inet"), but this is one change necessary to support this. Change-Id: If6962a7ad999b71bcfc9fd8e10d9c4067fa3f338 GitHub-Last-Rev: 3c5541b GitHub-Pull-Request: #45155 Reviewed-on: https://go-review.googlesource.com/c/go/+/303276 Run-TryBot: Tobias Klauser <[email protected]> TryBot-Result: Go Bot <[email protected]> Reviewed-by: Tobias Klauser <[email protected]> Reviewed-by: Aaron Bieber <[email protected]> Trust: Ian Lance Taylor <[email protected]>
This PR is being closed because golang.org/cl/303276 has been merged. |
This change avoids executing syscalls testing if IPv4 address mapping
is possible unless the socket being opened belongs to the AF_INET6
family.
In a pledged OpenBSD process, this test is only allowed when the
"inet" pledge is granted; however this check was also being performed
for AF_UNIX sockets (separately permitted under the "unix" pledge),
and would cause the process to be killed by the kernel. By avoiding
the IPv4 address mapping check until the socket is checked to be
AF_INET6, a pledged OpenBSD process using AF_UNIX sockets without the
"inet" pledge won't be killed for this misbehavior.
The OpenBSD kernel is not currently ready to support using UNIX domain
sockets with only the "unix" pledge (and without "inet"), but this is
one change necessary to support this.