make.bat: fix compare between GOROOT and srcdir paths, when either contains whitespace. #41319

djdv · 2020-09-10T14:11:40Z

CL 96455 brings CL 57753 to Windows
However, a path comparison within it was left unquoted.
If the Go source directory resides in a path containing whitespace,
the interpreter will compare against the first portion of the path string,
and treat the remainder as an expression.
This patch amends that.

For example, consider the path
C:\Users\Dominic Della Valle\Projects\Go\goroot\src
Issuing make.bat will print out 'Della' is not recognized as an internal or external command, operable program or batch file. before proceeding.

gopherbot · 2020-09-10T14:23:01Z

This PR (HEAD: d2cd699) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/go/+/253898 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

gopherbot · 2020-09-10T14:24:52Z

Message from Gobot Gobot:

Patch Set 1:

Congratulations on opening your first change. Thank you for your contribution!

Next steps:
A maintainer will review your change and provide feedback. See
https://golang.org/doc/contribute.html#review for more info and tips to get your
patch through code review.

Most changes in the Go project go through a few rounds of revision. This can be
surprising to people new to the project. The careful, iterative review process
is our way of helping mentor contributors and ensuring that their contributions
have a lasting impact.

During May-July and Nov-Jan the Go project is in a code freeze, during which
little code gets reviewed or merged. If a reviewer responds with a comment like
R=go1.11 or adds a tag like "wait-release", it means that this CL will be
reviewed as part of the next development cycle. See https://golang.org/s/release
for more details.

Please don’t reply on this GitHub thread. Visit golang.org/cl/253898.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2020-09-10T14:35:44Z

This PR (HEAD: 732243e) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/go/+/253898 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

gopherbot · 2020-09-10T14:44:34Z

Message from Dominic Della Valle:

Patch Set 2:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/253898.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2020-09-12T06:56:23Z

Message from Alex Brainman:

Patch Set 2:

(4 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/253898.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2020-09-12T16:48:37Z

This PR (HEAD: 00d865b) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/go/+/253898 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

gopherbot · 2020-09-12T17:46:28Z

Message from Giovanni Bajo:

Patch Set 3:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/253898.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2020-09-12T17:51:28Z

Message from Dominic Della Valle:

Patch Set 3:

(4 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/253898.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2020-09-12T23:51:43Z

Message from Alex Brainman:

Patch Set 3:

(2 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/253898.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2020-09-13T10:26:25Z

Message from Giovanni Bajo:

Patch Set 3: Run-TryBot+1 Code-Review+1 Trust+1

(3 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/253898.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2020-09-13T10:26:25Z

Message from Gobot Gobot:

Patch Set 3:

TryBots beginning. Status page: https://farmer.golang.org/try?commit=50198e7e

Please don’t reply on this GitHub thread. Visit golang.org/cl/253898.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2020-09-13T10:30:34Z

Message from Gobot Gobot:

Patch Set 3:

Build is still in progress...
This change failed on linux-amd64:
See https://storage.googleapis.com/go-build-log/50198e7e/linux-amd64_2eb5de90.log

Other builds still in progress; subsequent failure notices suppressed until final report. Consult https://build.golang.org/ to see whether they are new failures. Keep in mind that TryBots currently test exactly your git commit, without rebasing. If your commit's git parent is old, the failure might've already been fixed.

Please don’t reply on this GitHub thread. Visit golang.org/cl/253898.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2020-09-13T10:35:22Z

Message from Gobot Gobot:

Patch Set 3: TryBot-Result-1

2 of 20 TryBots failed:
Failed on linux-amd64: https://storage.googleapis.com/go-build-log/50198e7e/linux-amd64_2eb5de90.log
Failed on js-wasm: https://storage.googleapis.com/go-build-log/50198e7e/js-wasm_266a1550.log

Consult https://build.golang.org/ to see whether they are new failures. Keep in mind that TryBots currently test exactly your git commit, without rebasing. If your commit's git parent is old, the failure might've already been fixed.

Please don’t reply on this GitHub thread. Visit golang.org/cl/253898.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2020-09-13T10:45:45Z

Message from Giovanni Bajo:

Patch Set 3: -Run-TryBot Code-Review-2

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/253898.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2020-09-13T16:51:34Z

Message from Dominic Della Valle:

Patch Set 4:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/253898.
After addressing review feedback, remember to publish your drafts!

…ntains whitespace. CL 96455 brings CL 57753 to Windows However, a path comparison within it was left unquoted. If the Go source directory resides in a path containing whitespace, the interpreter will compare against the first portion of the path string, and treat the remainder as an expression. This patch amends that.

gopherbot · 2020-09-13T17:03:54Z

This PR (HEAD: 809ddbb) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/go/+/253898 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

gopherbot · 2020-09-13T17:12:57Z

Message from Dominic Della Valle:

Patch Set 5:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/253898.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2020-09-13T17:23:42Z

Message from Giovanni Bajo:

Patch Set 5: Run-TryBot+1 -Code-Review

Please don’t reply on this GitHub thread. Visit golang.org/cl/253898.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2020-09-13T17:25:20Z

Message from Gobot Gobot:

Patch Set 5:

TryBots beginning. Status page: https://farmer.golang.org/try?commit=1b83016b

Please don’t reply on this GitHub thread. Visit golang.org/cl/253898.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2020-09-13T17:34:45Z

Message from Gobot Gobot:

Patch Set 5: TryBot-Result+1

TryBots are happy.

Please don’t reply on this GitHub thread. Visit golang.org/cl/253898.
After addressing review feedback, remember to publish your drafts!

…ntains whitespace. CL 96455 brings CL 57753 to Windows However, a path comparison within it was left unquoted. If the Go source directory resides in a path containing whitespace, the interpreter will compare against the first portion of the path string, and treat the remainder as an expression. This patch amends that. For example, consider the path `C:\Users\Dominic Della Valle\Projects\Go\goroot\src` Issuing `make.bat` will print out `'Della' is not recognized as an internal or external command, operable program or batch file.` before proceeding. Change-Id: Ifcec159baeec940c29c61aa721c64c13c6fd8c14 GitHub-Last-Rev: 809ddbb GitHub-Pull-Request: #41319 Reviewed-on: https://go-review.googlesource.com/c/go/+/253898 Run-TryBot: Giovanni Bajo <[email protected]> TryBot-Result: Gobot Gobot <[email protected]> Reviewed-by: Giovanni Bajo <[email protected]> Trust: Giovanni Bajo <[email protected]>

gopherbot · 2020-09-13T19:18:56Z

This PR is being closed because golang.org/cl/253898 has been merged.

googlebot added the cla: yes Used by googlebot to label PRs as having a valid CLA. The text of this label should not change. label Sep 10, 2020

djdv changed the title ~~build: fix paths containing whitespace on Windows~~ make.bat: fix compare between GOROOT and srcdir paths, when either contains whitespace. Sep 13, 2020

gopherbot closed this Sep 13, 2020

make.bat: fix compare between GOROOT and srcdir paths, when either contains whitespace. #41319

make.bat: fix compare between GOROOT and srcdir paths, when either contains whitespace. #41319

Uh oh!

Conversation

djdv commented Sep 10, 2020

Uh oh!

gopherbot commented Sep 10, 2020

Uh oh!

gopherbot commented Sep 10, 2020

Uh oh!

gopherbot commented Sep 10, 2020

Uh oh!

gopherbot commented Sep 10, 2020

Uh oh!

gopherbot commented Sep 12, 2020

Uh oh!

gopherbot commented Sep 12, 2020

Uh oh!

gopherbot commented Sep 12, 2020

Uh oh!

gopherbot commented Sep 12, 2020

Uh oh!

gopherbot commented Sep 12, 2020

Uh oh!

gopherbot commented Sep 13, 2020

Uh oh!

gopherbot commented Sep 13, 2020

Uh oh!

gopherbot commented Sep 13, 2020

Uh oh!

gopherbot commented Sep 13, 2020

Uh oh!

gopherbot commented Sep 13, 2020

Uh oh!

gopherbot commented Sep 13, 2020

Uh oh!

gopherbot commented Sep 13, 2020

Uh oh!

gopherbot commented Sep 13, 2020

Uh oh!

gopherbot commented Sep 13, 2020

Uh oh!

gopherbot commented Sep 13, 2020

Uh oh!

gopherbot commented Sep 13, 2020

Uh oh!

gopherbot commented Sep 13, 2020

Uh oh!

Uh oh!