Skip to content

runtime: update docs for GOMAXPROCS #41276

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

runtime: update docs for GOMAXPROCS #41276

wants to merge 2 commits into from

Conversation

ipriver
Copy link
Contributor

@ipriver ipriver commented Sep 8, 2020

https://github.com/golang/go/blob/master/doc/effective_go.html#L3211 is used to update the docs comment for GOMAXPROCS function.

Fixes #41275

@googlebot googlebot added the cla: yes Used by googlebot to label PRs as having a valid CLA. The text of this label should not change. label Sep 8, 2020
@gopherbot
Copy link
Contributor

This PR (HEAD: 625fd4c) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/go/+/253537 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot
Copy link
Contributor

Message from Keith Randall:

Patch Set 1:

(2 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/253537.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

This PR (HEAD: e45c8ac) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/go/+/253537 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

gopherbot pushed a commit that referenced this pull request Sep 10, 2020
@ipriver @randall77
runtime: update docs for GOMAXPROCS
8098dbb 
https://github.com/golang/go/blob/master/doc/effective_go.html#L3211 is used to update the docs comment for `GOMAXPROCS` function.

Fixes #41275

Change-Id: I39f58e93a267c6e9f3ac6638ed51acbe5284ada2
GitHub-Last-Rev: e45c8ac
GitHub-Pull-Request: #41276
Reviewed-on: https://go-review.googlesource.com/c/go/+/253537
Reviewed-by: Keith Randall <[email protected]>
@gopherbot
Copy link
Contributor

This PR is being closed because golang.org/cl/253537 has been merged.

@gopherbot gopherbot closed this Sep 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
cla: yes Used by googlebot to label PRs as having a valid CLA. The text of this label should not change.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

runtime: GOMAXPROCS has outdated information
3 participants
@ipriver @gopherbot @googlebot