Skip to content

misc/cgo/test: test C.enum_* #39977

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

misc/cgo/test: test C.enum_* #39977

wants to merge 2 commits into from

Conversation

howjmay
Copy link
Contributor

@howjmay howjmay commented Jul 1, 2020 •
edited
Loading

Allocate a C enum object, and test if it can be assigned a value
successfully.

For #39537

@googlebot googlebot added the cla: yes Used by googlebot to label PRs as having a valid CLA. The text of this label should not change. label Jul 1, 2020
@gopherbot
Copy link
Contributor

This PR (HEAD: 6d577e4) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/go/+/240697 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot
Copy link
Contributor

Message from Ian Lance Taylor:

Patch Set 1:

(3 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/240697.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

This PR (HEAD: f8d7b31) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/go/+/240697 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@howjmay howjmay changed the title cgo: Test Allocating C enum with C.enum_* misc/cgo/test: test C.enum_* Jul 1, 2020
@gopherbot
Copy link
Contributor

This PR (HEAD: 239a099) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/go/+/240697 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot
Copy link
Contributor

Message from Hau Yang:

Patch Set 4:

(4 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/240697.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Ian Lance Taylor:

Patch Set 4:

Thanks for sending this. We'll review this during the 1.16 release cycle, after 1.15 is released.

Please don’t reply on this GitHub thread. Visit golang.org/cl/240697.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Emmanuel Odeke:

Patch Set 4: Run-TryBot+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/240697.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Go Bot:

Patch Set 4:

TryBots beginning. Status page: https://farmer.golang.org/try?commit=e1946550

Please don’t reply on this GitHub thread. Visit golang.org/cl/240697.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Go Bot:

Patch Set 4: TryBot-Result+1

TryBots are happy.

Please don’t reply on this GitHub thread. Visit golang.org/cl/240697.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Ian Lance Taylor:

Patch Set 4:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/240697.
After addressing review feedback, remember to publish your drafts!

@howjmay
misc/cgo/test: test C.enum_*
be241e9 
Allocate a C enum object, and test if it can be assigned a value
successfully.
@howjmay
misc/cgo/test: Test casting a C enumration object
81890f4 
Declare an object to C Enumeration and check if it has been assigned
correct values.
@gopherbot
Copy link
Contributor

This PR (HEAD: 81890f4) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/go/+/240697 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot
Copy link
Contributor

Message from Ian Lance Taylor:

Patch Set 5: Run-TryBot+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/240697.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Go Bot:

Patch Set 5:

TryBots beginning. Status page: https://farmer.golang.org/try?commit=0ab1f529

Please don’t reply on this GitHub thread. Visit golang.org/cl/240697.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Go Bot:

Patch Set 5: TryBot-Result+1

TryBots are happy.

Please don’t reply on this GitHub thread. Visit golang.org/cl/240697.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Ian Lance Taylor:

Patch Set 5: Code-Review+2

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/240697.
After addressing review feedback, remember to publish your drafts!

gopherbot pushed a commit that referenced this pull request Oct 27, 2020
@howjmay @odeke-em
misc/cgo/test: test C.enum_*
3f6b1a0 
Allocate a C enum object, and test if it can be assigned a value
successfully.

For #39537

Change-Id: I7b5482112486440b9d99f2ee4051328d87f45dca
GitHub-Last-Rev: 81890f4
GitHub-Pull-Request: #39977
Reviewed-on: https://go-review.googlesource.com/c/go/+/240697
Run-TryBot: Ian Lance Taylor <[email protected]>
TryBot-Result: Go Bot <[email protected]>
Reviewed-by: Ian Lance Taylor <[email protected]>
Trust: Emmanuel Odeke <[email protected]>
@gopherbot
Copy link
Contributor

This PR is being closed because golang.org/cl/240697 has been merged.

@gopherbot gopherbot closed this Oct 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
cla: yes Used by googlebot to label PRs as having a valid CLA. The text of this label should not change.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@howjmay @gopherbot @googlebot