net/http: fix infinite 301 redirects of http.FileServe #38534

medcl · 2020-04-20T03:08:49Z

This change modifies If the url is already root "/", don't cause additional redirect. Fixes: #13996

When using `http.FileServer` to serve virtual filesystem, If the url was exactly `/`, it will redirect to `..//`, this is actually itself, as result, this line of code will cause infinite 301 redirects loop. To prevent this behavior it is safe to add additional check `&& url !="/"`. Related issue: golang#13996 ``` $ curl http://localhost:9000/ -v -L % Total % Received % Xferd Average Speed Time Time Time Current Dload Upload Total Spent Left Speed 0 0 0 0 0 0 0 0 --:--:-- --:--:-- --:--:-- 0* Trying ::1:9000... * TCP_NODELAY set * Trying 127.0.0.1:9000... * TCP_NODELAY set * Connected to localhost (127.0.0.1) port 9000 (#0) > GET / HTTP/1.1 > Host: localhost:9000 > User-Agent: curl/7.65.3 > Accept: */* > * Mark bundle as not supporting multiuse < HTTP/1.1 301 Moved Permanently < Location: ..// < Date: Mon, 20 Apr 2020 02:08:14 GMT < Content-Length: 0 < 0 0 0 0 0 0 0 0 --:--:-- --:--:-- --:--:-- 0 * Connection #0 to host localhost left intact * Issue another request to this URL: 'http://localhost:9000/' * Found bundle for host localhost: 0x2754760 [serially] * Can not multiplex, even if we wanted to! * Re-using existing connection! (#0) with host localhost * Connected to localhost (127.0.0.1) port 9000 (#0) > GET / HTTP/1.1 > Host: localhost:9000 > User-Agent: curl/7.65.3 > Accept: */* > * Mark bundle as not supporting multiuse < HTTP/1.1 301 Moved Permanently < Location: ..// < Date: Mon, 20 Apr 2020 02:08:14 GMT < Content-Length: 0 < 0 0 0 0 0 0 0 0 --:--:-- --:--:-- --:--:-- 0 * Connection #0 to host localhost left intact * Issue another request to this URL: 'http://localhost:9000/' * Found bundle for host localhost: 0x2754760 [serially] * Can not multiplex, even if we wanted to! * Re-using existing connection! (#0) with host localhost * Connected to localhost (127.0.0.1) port 9000 (#0) TLDR < 0 0 0 0 0 0 0 0 --:--:-- --:--:-- --:--:-- 0 * Connection #0 to host localhost left intact * Issue another request to this URL: 'http://localhost:9000/' * Found bundle for host localhost: 0x2754760 [serially] * Can not multiplex, even if we wanted to! * Re-using existing connection! (#0) with host localhost * Connected to localhost (127.0.0.1) port 9000 (#0) > GET / HTTP/1.1 > Host: localhost:9000 > User-Agent: curl/7.65.3 > Accept: */* > * Mark bundle as not supporting multiuse < HTTP/1.1 301 Moved Permanently < Location: ..// < Date: Mon, 20 Apr 2020 02:08:14 GMT < Content-Length: 0 < 0 0 0 0 0 0 0 0 --:--:-- --:--:-- --:--:-- 0 * Connection #0 to host localhost left intact * Maximum (50) redirects followed curl: (47) Maximum (50) redirects followed ```

googlebot · 2020-04-20T03:08:53Z

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.

What to do if you already signed the CLA

Individual signers

It's possible we don't have your GitHub username or you're using a different email address on your commit. Check your existing CLA data and verify that your email is set on your git commits.

Corporate signers

Your company has a Point of Contact who decides which employees are authorized to participate. Ask your POC to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the Google project maintainer to go/cla#troubleshoot (Public version).
The email used to register you as an authorized contributor must be the email used for the Git commit. Check your existing CLA data and verify that your email is set on your git commits.
The email used to register you as an authorized contributor must also be attached to your GitHub account.

ℹ️ Googlers: Go here for more info.

medcl · 2020-04-20T03:18:21Z

@googlebot I signed it!

googlebot · 2020-04-20T03:18:24Z

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

gopherbot · 2020-04-20T03:24:42Z

This PR (HEAD: 5ad8f1f) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/go/+/228904 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

gopherbot · 2020-04-20T03:25:59Z

Message from Gobot Gobot:

Patch Set 1:

Congratulations on opening your first change. Thank you for your contribution!

Next steps:
Within the next week or so, a maintainer will review your change and provide
feedback. See https://golang.org/doc/contribute.html#review for more info and
tips to get your patch through code review.

Most changes in the Go project go through a few rounds of revision. This can be
surprising to people new to the project. The careful, iterative review process
is our way of helping mentor contributors and ensuring that their contributions
have a lasting impact.

During May-July and Nov-Jan the Go project is in a code freeze, during which
little code gets reviewed or merged. If a reviewer responds with a comment like
R=go1.11, it means that this CL will be reviewed as part of the next development
cycle. See https://golang.org/s/release for more details.

Please don’t reply on this GitHub thread. Visit golang.org/cl/228904.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2020-04-20T15:09:10Z

Message from Brad Fitzpatrick:

Patch Set 1:

(2 comments)

Please add a test.

Please don’t reply on this GitHub thread. Visit golang.org/cl/228904.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2020-04-21T03:10:42Z

Message from Medcl:

Patch Set 5:

Patch Set 1:

(2 comments)

Please add a test.

Hi, Brad, Really appreciate your fast reaction, since this is a minor change, and didn't ship new features, do you still think it is necessary to add a test. i just don't find a good test case for this change.

Please don’t reply on this GitHub thread. Visit golang.org/cl/228904.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2020-08-17T07:38:43Z

Message from Emmanuel Odeke:

Patch Set 5: Code-Review-1

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/228904.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2020-08-18T14:55:13Z

Message from Medcl:

Patch Set 5:

(2 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/228904.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2020-08-22T13:25:16Z

Message from Emmanuel Odeke:

Patch Set 5:

(4 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/228904.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2020-10-15T03:44:54Z

Message from Go Bot:

Patch Set 1:

Congratulations on opening your first change. Thank you for your contribution!

Next steps:
Within the next week or so, a maintainer will review your change and provide
feedback. See https://golang.org/doc/contribute.html#review for more info and
tips to get your patch through code review.

Most changes in the Go project go through a few rounds of revision. This can be
surprising to people new to the project. The careful, iterative review process
is our way of helping mentor contributors and ensuring that their contributions
have a lasting impact.

During May-July and Nov-Jan the Go project is in a code freeze, during which
little code gets reviewed or merged. If a reviewer responds with a comment like
R=go1.11, it means that this CL will be reviewed as part of the next development
cycle. See https://golang.org/s/release for more details.

Please don’t reply on this GitHub thread. Visit golang.org/cl/228904.
After addressing review feedback, remember to publish your drafts!

googlebot added the cla: no Used by googlebot to label PRs as having an invalid CLA. The text of this label should not change. label Apr 20, 2020

googlebot added cla: yes Used by googlebot to label PRs as having a valid CLA. The text of this label should not change. and removed cla: no Used by googlebot to label PRs as having an invalid CLA. The text of this label should not change. labels Apr 20, 2020

medcl changed the title ~~Fix infini 301 redirects of http.FileServe~~ net/http: fix infini 301 redirects of http.FileServe Apr 20, 2020

medcl changed the title ~~net/http: fix infini 301 redirects of http.FileServe~~ net/http: fix infinite 301 redirects of http.FileServe Apr 21, 2020

gopherbot force-pushed the master branch from a408139 to 5764653 Compare September 14, 2020 21:26

heschi closed this Dec 15, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

net/http: fix infinite 301 redirects of http.FileServe #38534

net/http: fix infinite 301 redirects of http.FileServe #38534

Uh oh!

medcl commented Apr 20, 2020 •

edited

Loading

Uh oh!

googlebot commented Apr 20, 2020

Uh oh!

medcl commented Apr 20, 2020

Uh oh!

googlebot commented Apr 20, 2020

Uh oh!

gopherbot commented Apr 20, 2020

Uh oh!

gopherbot commented Apr 20, 2020

Uh oh!

gopherbot commented Apr 20, 2020

Uh oh!

gopherbot commented Apr 21, 2020

Uh oh!

gopherbot commented Aug 17, 2020

Uh oh!

gopherbot commented Aug 18, 2020

Uh oh!

gopherbot commented Aug 22, 2020

Uh oh!

gopherbot commented Oct 15, 2020

Uh oh!

Uh oh!

net/http: fix infinite 301 redirects of http.FileServe #38534

net/http: fix infinite 301 redirects of http.FileServe #38534

Uh oh!

Conversation

medcl commented Apr 20, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

googlebot commented Apr 20, 2020

What to do if you already signed the CLA

Individual signers

Corporate signers

Uh oh!

medcl commented Apr 20, 2020

Uh oh!

googlebot commented Apr 20, 2020

Uh oh!

gopherbot commented Apr 20, 2020

Uh oh!

gopherbot commented Apr 20, 2020

Uh oh!

gopherbot commented Apr 20, 2020

Uh oh!

gopherbot commented Apr 21, 2020

Uh oh!

gopherbot commented Aug 17, 2020

Uh oh!

gopherbot commented Aug 18, 2020

Uh oh!

gopherbot commented Aug 22, 2020

Uh oh!

gopherbot commented Oct 15, 2020

Uh oh!

Uh oh!

medcl commented Apr 20, 2020 •

edited

Loading