net/http: allow upgrading non keepalive connections #36382

nhooyr · 2020-01-04T08:23:49Z

If one was using http.Transport with DisableKeepAlives and trying
to upgrade a connection against net/http's Server, the Server
would not allow a "Connection: Upgrade" header to be written
and instead override it to "Connection: Close" which would
break the handshake.

This change ensures net/http's Server does not override the
connection header for successful protocol switch responses.

Fixes #36381.

gopherbot · 2020-01-04T08:32:11Z

This PR (HEAD: 1a74c9e) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/go/+/213277 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

gopherbot · 2020-01-06T16:04:17Z

Message from Brad Fitzpatrick:

Patch Set 1:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/213277.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2020-01-06T22:04:03Z

This PR (HEAD: f7fcdcf) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/go/+/213277 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

gopherbot · 2020-01-06T22:19:44Z

Message from Brad Fitzpatrick:

Patch Set 2:

(4 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/213277.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2020-01-07T17:25:39Z

This PR (HEAD: 67084c3) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/go/+/213277 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

gopherbot · 2020-01-07T17:31:32Z

Message from Brad Fitzpatrick:

Patch Set 3:

Please revert all the unrelated cmd/go/testdata go.mod changes.

Please don’t reply on this GitHub thread. Visit golang.org/cl/213277.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2020-01-07T17:34:08Z

This PR (HEAD: fa35c25) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/go/+/213277 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

gopherbot · 2020-01-07T17:41:50Z

Message from Brad Fitzpatrick:

Patch Set 3:

(5 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/213277.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2020-01-07T17:42:00Z

This PR (HEAD: 45fe378) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/go/+/213277 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

gopherbot · 2020-01-07T17:44:49Z

This PR (HEAD: df639f8) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/go/+/213277 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

gopherbot · 2020-01-07T17:47:18Z

Message from Brad Fitzpatrick:

Patch Set 6: Run-TryBot+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/213277.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2020-01-07T17:47:19Z

Message from Gobot Gobot:

Patch Set 6:

TryBots beginning. Status page: https://farmer.golang.org/try?commit=ec0ce490

Please don’t reply on this GitHub thread. Visit golang.org/cl/213277.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2020-01-07T17:56:20Z

This PR (HEAD: dbb003f) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/go/+/213277 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

gopherbot · 2020-01-07T18:00:38Z

Message from Brad Fitzpatrick:

Patch Set 7: Run-TryBot+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/213277.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2020-01-07T18:00:39Z

Message from Gobot Gobot:

Patch Set 7:

TryBots beginning. Status page: https://farmer.golang.org/try?commit=8946b309

Please don’t reply on this GitHub thread. Visit golang.org/cl/213277.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2020-01-07T18:26:29Z

Message from Gobot Gobot:

Patch Set 7: TryBot-Result+1

TryBots are happy.

Please don’t reply on this GitHub thread. Visit golang.org/cl/213277.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2020-01-09T20:42:08Z

This PR (HEAD: 716912d) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/go/+/213277 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

gopherbot · 2020-01-09T21:01:08Z

This PR (HEAD: 80325a2) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/go/+/213277 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

gopherbot · 2020-01-21T22:08:57Z

Message from Anmol Sethi:

Patch Set 10:

This should be good now @brad

Please don’t reply on this GitHub thread. Visit golang.org/cl/213277.
After addressing review feedback, remember to publish your drafts!

nhooyr · 2020-02-21T06:44:50Z

@bradfitz From whom should I request further reviews to get this merged?

gopherbot · 2020-03-29T23:51:46Z

Message from Gobot Gobot:

Patch Set 10:

TryBots beginning. Status page: https://farmer.golang.org/try?commit=13146348

Please don’t reply on this GitHub thread. Visit golang.org/cl/213277.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2020-03-30T00:03:11Z

Message from Gobot Gobot:

Patch Set 10: TryBot-Result+1

TryBots are happy.

Please don’t reply on this GitHub thread. Visit golang.org/cl/213277.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2020-03-30T15:03:56Z

Message from Brad Fitzpatrick:

Patch Set 10:

(2 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/213277.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2020-06-12T08:46:19Z

This PR (HEAD: 702ce2a) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/go/+/213277 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

gopherbot · 2020-06-12T09:06:03Z

This PR (HEAD: da7a944) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/go/+/213277 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

Fixes golang#36381 If one was using http.Transport with DisableKeepAlives and trying to upgrade a connection against net/http's Server, the Server would not allow a "Connection: Upgrade" header to be written and instead override it to "Connection: Close" which would break the handshake. This commit ensures net/http's Server does not override the connection header for successful protocol switch responses.

gopherbot · 2020-06-12T09:07:51Z

This PR (HEAD: dc0de83) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/go/+/213277 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

gopherbot · 2020-07-03T11:51:57Z

Message from Anmol Sethi:

Patch Set 15:

(10 comments)

Thanks for the review guys.

This was in my draft for a while. Can't remember if I was still working on it but please let me know if anything else needs to be done.

Please don’t reply on this GitHub thread. Visit golang.org/cl/213277.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2020-07-20T04:36:25Z

Message from Anmol Sethi:

Patch Set 15:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/213277.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2020-10-15T03:44:23Z

Message from Go Bot:

Patch Set 6:

TryBots beginning. Status page: https://farmer.golang.org/try?commit=ec0ce490

Please don’t reply on this GitHub thread. Visit golang.org/cl/213277.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2020-10-15T03:44:24Z

Message from Go Bot:

Patch Set 7:

TryBots beginning. Status page: https://farmer.golang.org/try?commit=8946b309

Please don’t reply on this GitHub thread. Visit golang.org/cl/213277.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2020-10-15T03:44:25Z

Message from Go Bot:

Patch Set 7: TryBot-Result+1

TryBots are happy.

Please don’t reply on this GitHub thread. Visit golang.org/cl/213277.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2020-10-15T03:44:26Z

Message from Go Bot:

Patch Set 10:

TryBots beginning. Status page: https://farmer.golang.org/try?commit=13146348

Please don’t reply on this GitHub thread. Visit golang.org/cl/213277.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2020-10-15T03:44:27Z

Message from Go Bot:

Patch Set 10: TryBot-Result+1

TryBots are happy.

Please don’t reply on this GitHub thread. Visit golang.org/cl/213277.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2020-10-20T18:44:16Z

Message from Brad Fitzpatrick:

Patch Set 15: Code-Review+2

Please don’t reply on this GitHub thread. Visit golang.org/cl/213277.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2020-10-20T18:44:17Z

Message from Brad Fitzpatrick:

Patch Set 15: Run-TryBot+1 Trust+1

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/213277.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2020-10-20T18:44:18Z

Message from Go Bot:

Patch Set 15:

TryBots beginning. Status page: https://farmer.golang.org/try?commit=0210f5cd

Please don’t reply on this GitHub thread. Visit golang.org/cl/213277.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2020-10-20T18:58:43Z

Message from Go Bot:

Patch Set 15:

Build is still in progress...
This change failed on (x/tools) linux-amd64:
See https://storage.googleapis.com/go-build-log/0210f5cd/linux-amd64_e6abd2c5.log

Other builds still in progress; subsequent failure notices suppressed until final report. Consult https://build.golang.org/ to see whether they are new failures. Keep in mind that TryBots currently test exactly your git commit, without rebasing. If your commit's git parent is old, the failure might've already been fixed.

Please don’t reply on this GitHub thread. Visit golang.org/cl/213277.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2020-10-20T19:04:44Z

Message from Go Bot:

Patch Set 15: TryBot-Result-1

2 of 20 TryBots failed:
Failed on (x/tools) linux-amd64: https://storage.googleapis.com/go-build-log/0210f5cd/linux-amd64_e6abd2c5.log
Failed on linux-amd64: https://storage.googleapis.com/go-build-log/0210f5cd/linux-amd64_e204a81c.log

Consult https://build.golang.org/ to see whether they are new failures. Keep in mind that TryBots currently test exactly your git commit, without rebasing. If your commit's git parent is old, the failure might've already been fixed.

Please don’t reply on this GitHub thread. Visit golang.org/cl/213277.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2020-10-24T00:42:34Z

Message from Emmanuel Odeke:

Patch Set 16: Trust+1

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/213277.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2020-12-01T19:46:54Z

Message from Damien Neil:

Patch Set 16: Code-Review+2

Please don’t reply on this GitHub thread. Visit golang.org/cl/213277.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2020-12-01T19:46:55Z

Message from Damien Neil:

Patch Set 16: -Code-Review

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/213277.
After addressing review feedback, remember to publish your drafts!

If one was using http.Transport with DisableKeepAlives and trying to upgrade a connection against net/http's Server, the Server would not allow a "Connection: Upgrade" header to be written and instead override it to "Connection: Close" which would break the handshake. This change ensures net/http's Server does not override the connection header for successful protocol switch responses. Fixes #36381. Change-Id: I882aad8539e6c87ff5f37c20e20b3a7fa1a30357 GitHub-Last-Rev: dc0de83 GitHub-Pull-Request: #36382 Reviewed-on: https://go-review.googlesource.com/c/go/+/213277 Trust: Emmanuel Odeke <[email protected]> Trust: Brad Fitzpatrick <[email protected]> Reviewed-by: Brad Fitzpatrick <[email protected]>

gopherbot · 2020-12-01T19:49:15Z

This PR is being closed because golang.org/cl/213277 has been merged.

googlebot added the cla: yes Used by googlebot to label PRs as having a valid CLA. The text of this label should not change. label Jan 4, 2020

nhooyr force-pushed the upgrade branch from 1a74c9e to f7fcdcf Compare January 6, 2020 22:03

nhooyr force-pushed the upgrade branch from f7fcdcf to 67084c3 Compare January 7, 2020 17:24

nhooyr force-pushed the upgrade branch from 67084c3 to fa35c25 Compare January 7, 2020 17:33

nhooyr force-pushed the upgrade branch from fa35c25 to 45fe378 Compare January 7, 2020 17:36

nhooyr force-pushed the upgrade branch from 45fe378 to df639f8 Compare January 7, 2020 17:43

nhooyr force-pushed the upgrade branch from df639f8 to dbb003f Compare January 7, 2020 17:55

bradfitz changed the title ~~net/http: allow upgrading non keepalive connections~~ net/http: fix Transport upgrading responses for non-keep-alive requests Jan 8, 2020

nhooyr force-pushed the upgrade branch from dbb003f to 716912d Compare January 9, 2020 20:40

nhooyr force-pushed the upgrade branch from 716912d to 80325a2 Compare January 9, 2020 21:00

nhooyr changed the title ~~net/http: fix Transport upgrading responses for non-keep-alive requests~~ net/http: allow upgrading non keepalive connections Jun 12, 2020

nhooyr force-pushed the upgrade branch from 80325a2 to 702ce2a Compare June 12, 2020 08:45

nhooyr force-pushed the upgrade branch from 702ce2a to da7a944 Compare June 12, 2020 09:05

nhooyr force-pushed the upgrade branch from da7a944 to dc0de83 Compare June 12, 2020 09:06

gopherbot force-pushed the master branch from a408139 to 5764653 Compare September 14, 2020 21:26

gopherbot closed this Dec 1, 2020

net/http: allow upgrading non keepalive connections #36382

net/http: allow upgrading non keepalive connections #36382

Conversation

nhooyr commented Jan 4, 2020 • edited by odeke-em Loading

gopherbot commented Jan 4, 2020

gopherbot commented Jan 6, 2020

gopherbot commented Jan 6, 2020

gopherbot commented Jan 6, 2020

gopherbot commented Jan 7, 2020

gopherbot commented Jan 7, 2020

gopherbot commented Jan 7, 2020

gopherbot commented Jan 7, 2020

gopherbot commented Jan 7, 2020

gopherbot commented Jan 7, 2020

gopherbot commented Jan 7, 2020

gopherbot commented Jan 7, 2020

gopherbot commented Jan 7, 2020

gopherbot commented Jan 7, 2020

gopherbot commented Jan 7, 2020

gopherbot commented Jan 7, 2020

gopherbot commented Jan 9, 2020

gopherbot commented Jan 9, 2020

gopherbot commented Jan 21, 2020

nhooyr commented Feb 21, 2020

gopherbot commented Mar 29, 2020

gopherbot commented Mar 30, 2020

gopherbot commented Mar 30, 2020

gopherbot commented Jun 12, 2020

gopherbot commented Jun 12, 2020

gopherbot commented Jun 12, 2020

gopherbot commented Jul 3, 2020

gopherbot commented Jul 20, 2020

gopherbot commented Oct 15, 2020

gopherbot commented Oct 15, 2020

gopherbot commented Oct 15, 2020

gopherbot commented Oct 15, 2020

gopherbot commented Oct 15, 2020

gopherbot commented Oct 20, 2020

gopherbot commented Oct 20, 2020

gopherbot commented Oct 20, 2020

gopherbot commented Oct 20, 2020

gopherbot commented Oct 20, 2020

gopherbot commented Oct 24, 2020

gopherbot commented Dec 1, 2020

gopherbot commented Dec 1, 2020

gopherbot commented Dec 1, 2020

nhooyr commented Jan 4, 2020 •

edited by odeke-em

Loading