Skip to content

testing: use conventional comments for exported internal funcs & structs #36054

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

testing: use conventional comments for exported internal funcs & structs #36054

wants to merge 2 commits into from

Conversation

vovapi
Copy link
Contributor

@vovapi vovapi commented Dec 9, 2019

No description provided.

@googlebot googlebot added the cla: yes Used by googlebot to label PRs as having a valid CLA. The text of this label should not change. label Dec 9, 2019
@gopherbot
Copy link
Contributor

This PR (HEAD: b9cdaa6) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/go/+/210497 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@bradfitz bradfitz changed the title testing: conventional comments for exported internal funcs & structs testing: use conventional comments for exported internal funcs & structs Dec 9, 2019
@gopherbot
Copy link
Contributor

Message from Brad Fitzpatrick:

Patch Set 2:

(3 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/210497.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

This PR (HEAD: aa63775) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/go/+/210497 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot
Copy link
Contributor

Message from Vladimir Evgrafov:

Patch Set 3:

(3 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/210497.
After addressing review feedback, remember to publish your drafts!

gopherbot pushed a commit that referenced this pull request Dec 10, 2019
@vovapi @bradfitz
testing: use conventional comments for exported internal funcs & structs
207a0b7 
Change-Id: I2dd5ddc22bfff143b81d5945992d8c5fccf387f4
GitHub-Last-Rev: aa63775
GitHub-Pull-Request: #36054
Reviewed-on: https://go-review.googlesource.com/c/go/+/210497
Reviewed-by: Brad Fitzpatrick <[email protected]>
@gopherbot
Copy link
Contributor

Message from Brad Fitzpatrick:

Patch Set 3: Code-Review+2

Please don’t reply on this GitHub thread. Visit golang.org/cl/210497.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

This PR is being closed because golang.org/cl/210497 has been merged.

@gopherbot gopherbot closed this Dec 10, 2019
@vovapi vovapi deleted the testing-doc-comments branch December 10, 2019 21:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
cla: yes Used by googlebot to label PRs as having a valid CLA. The text of this label should not change.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vovapi @gopherbot @googlebot