Skip to content

doc: clarify interaction of ioutil.WriteFile with umask #35836

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

doc: clarify interaction of ioutil.WriteFile with umask #35836

wants to merge 1 commit into from

Conversation

mostynb
Copy link
Contributor

@mostynb mostynb commented Nov 25, 2019 •
edited
Loading

Note that ioutil.WriteFile's perm argument is the value before the
umask is applied.

Fixes #35835

Change-Id: I61cd9c88bced3be52b616d86e060cd3fd912ab1f

@googlebot googlebot added the cla: yes Used by googlebot to label PRs as having a valid CLA. The text of this label should not change. label Nov 25, 2019
@gopherbot
Copy link
Contributor

This PR (HEAD: ef153e5) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/go/+/208838 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot
Copy link
Contributor

Message from Ian Lance Taylor:

Patch Set 2:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/208838.
After addressing review feedback, remember to publish your drafts!

@mostynb
doc: clarify interaction of ioutil.WriteFile with umask
0069abb 
Note that ioutil.WriteFile's perm argument is the value before the
umask is applied.

Fixes golang#35835

Change-Id: I61cd9c88bced3be52b616d86e060cd3fd912ab1f
@gopherbot
Copy link
Contributor

This PR (HEAD: 0069abb) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/go/+/208838 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot
Copy link
Contributor

Message from Mostyn Bramley-Moore:

Patch Set 3:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/208838.
After addressing review feedback, remember to publish your drafts!

gopherbot pushed a commit that referenced this pull request Nov 27, 2019
@mostynb @ianlancetaylor
doc: clarify interaction of ioutil.WriteFile with umask
95c9a65 
Note that ioutil.WriteFile's perm argument is the value before the
umask is applied.

Fixes #35835

Change-Id: I61cd9c88bced3be52b616d86e060cd3fd912ab1f

Change-Id: I61cd9c88bced3be52b616d86e060cd3fd912ab1f
GitHub-Last-Rev: 0069abb
GitHub-Pull-Request: #35836
Reviewed-on: https://go-review.googlesource.com/c/go/+/208838
Reviewed-by: Ian Lance Taylor <[email protected]>
@gopherbot
Copy link
Contributor

This PR is being closed because golang.org/cl/208838 has been merged.

@gopherbot gopherbot closed this Nov 27, 2019
@mostynb mostynb deleted the umask_docs branch November 27, 2019 08:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
cla: yes Used by googlebot to label PRs as having a valid CLA. The text of this label should not change.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

os, io/ioutil: clarify ioutil.WriteFile and os.Mkdir docs re permissions and umask
3 participants
@mostynb @gopherbot @googlebot