Skip to content

net/http: fix Server.ConnContext modifying context for all new connections #35751

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

net/http: fix Server.ConnContext modifying context for all new connections #35751

wants to merge 2 commits into from

Conversation

rkollar
Copy link
Contributor

@rkollar rkollar commented Nov 21, 2019

Fixes #35750

@googlebot googlebot added the cla: yes Used by googlebot to label PRs as having a valid CLA. The text of this label should not change. label Nov 21, 2019
@gopherbot
Copy link
Contributor

This PR (HEAD: 827fb3f) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/go/+/208318 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot
Copy link
Contributor

Message from Gobot Gobot:

Patch Set 1:

Congratulations on opening your first change. Thank you for your contribution!

Next steps:
Within the next week or so, a maintainer will review your change and provide
feedback. See https://golang.org/doc/contribute.html#review for more info and
tips to get your patch through code review.

Most changes in the Go project go through a few rounds of revision. This can be
surprising to people new to the project. The careful, iterative review process
is our way of helping mentor contributors and ensuring that their contributions
have a lasting impact.

During May-July and Nov-Jan the Go project is in a code freeze, during which
little code gets reviewed or merged. If a reviewer responds with a comment like
R=go1.11, it means that this CL will be reviewed as part of the next development
cycle. See https://golang.org/s/release for more details.

Please don’t reply on this GitHub thread. Visit golang.org/cl/208318.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Brad Fitzpatrick:

Patch Set 1:

Fix looks right but it'd be nice to see a test too.

Please don’t reply on this GitHub thread. Visit golang.org/cl/208318.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

This PR (HEAD: 953fdfd) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/go/+/208318 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot
Copy link
Contributor

Message from Brad Fitzpatrick:

Patch Set 2: Run-TryBot+1 Code-Review+2

Please don’t reply on this GitHub thread. Visit golang.org/cl/208318.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Gobot Gobot:

Patch Set 2:

TryBots beginning. Status page: https://farmer.golang.org/try?commit=773f03b1

Please don’t reply on this GitHub thread. Visit golang.org/cl/208318.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Gobot Gobot:

Patch Set 2: TryBot-Result+1

TryBots are happy.

Please don’t reply on this GitHub thread. Visit golang.org/cl/208318.
After addressing review feedback, remember to publish your drafts!

gopherbot pushed a commit that referenced this pull request Nov 21, 2019
@rkollar @bradfitz
net/http: fix Server.ConnContext modifying context for all new connec…
bbbc658 
…tions

Fixes #35750

Change-Id: I65d38cfc5ddd66131777e104c269cc3559b2471d
GitHub-Last-Rev: 953fdfd
GitHub-Pull-Request: #35751
Reviewed-on: https://go-review.googlesource.com/c/go/+/208318
Reviewed-by: Brad Fitzpatrick <[email protected]>
Run-TryBot: Brad Fitzpatrick <[email protected]>
TryBot-Result: Gobot Gobot <[email protected]>
gopherbot pushed a commit that referenced this pull request Nov 22, 2019
@rkollar @bradfitz
[release-branch.go1.13] net/http: fix Server.ConnContext modifying co…
94b6eec 
…ntext for all new connections

Updates #35750
Fixes #35765

Change-Id: I65d38cfc5ddd66131777e104c269cc3559b2471d
GitHub-Last-Rev: 953fdfd
GitHub-Pull-Request: #35751
Reviewed-on: https://go-review.googlesource.com/c/go/+/208318
Reviewed-by: Brad Fitzpatrick <[email protected]>
Run-TryBot: Brad Fitzpatrick <[email protected]>
TryBot-Result: Gobot Gobot <[email protected]>
(cherry picked from commit bbbc658)
Reviewed-on: https://go-review.googlesource.com/c/go/+/208235
Reviewed-by: Bryan C. Mills <[email protected]>
@odeke-em
Copy link
Member

Thank you for the PR @rkollar and for catching this bug!

Somehow this PR wasn't closed after the Gerrit merge from master and even after the backport, kindly cc-ing @bradfitz @dmitshur @andybons and I'll manually close this PR.

@odeke-em odeke-em closed this Nov 26, 2019
@dmitshur dmitshur mentioned this pull request Nov 27, 2019
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
cla: yes Used by googlebot to label PRs as having a valid CLA. The text of this label should not change.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

net/http: Server.ConnContext accidentally modifies context for all connections
4 participants
@rkollar @gopherbot @odeke-em @googlebot