cmd/go: keep "go help" in unknown topic suggestion #33245

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Closed

jmartin82 wants to merge 1 commit into golang:master from jmartin82:help

Contributor

jmartin82 commented Jul 23, 2019

Fixed missing concatenation to build the suggested command.

Fixes #33153


          fixed proposed command issue on the help error message

9631abf

googlebot added the cla: yes label

Contributor

gopherbot commented Jul 23, 2019

This PR (HEAD: 9631abf) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/go/+/187217 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

Contributor

gopherbot commented Jul 23, 2019

Message from Agniva De Sarker:

Patch Set 1: Run-TryBot+1 Code-Review+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/187217.
After addressing review feedback, remember to publish your drafts!

Contributor

gopherbot commented Jul 23, 2019

Message from Gobot Gobot:

Patch Set 1:

TryBots beginning. Status page: https://farmer.golang.org/try?commit=1b842cfd

Please don’t reply on this GitHub thread. Visit golang.org/cl/187217.
After addressing review feedback, remember to publish your drafts!

Contributor

gopherbot commented Jul 23, 2019

Message from Agniva De Sarker:

Patch Set 1:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/187217.
After addressing review feedback, remember to publish your drafts!

Contributor

gopherbot commented Jul 23, 2019

Message from Ian Lance Taylor:

Patch Set 1:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/187217.
After addressing review feedback, remember to publish your drafts!

Contributor

gopherbot commented Jul 23, 2019

Message from Gobot Gobot:

Patch Set 1: TryBot-Result+1

TryBots are happy.

Please don’t reply on this GitHub thread. Visit golang.org/cl/187217.
After addressing review feedback, remember to publish your drafts!

jmartin82 changed the title ~~cmd/go: Fix the suggested command on the help error message~~ cmd/go: keep "go help" in unknown topic suggestion

Contributor

gopherbot commented Jul 23, 2019

Message from Jordi Martin Cardona:

Patch Set 2:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/187217.
After addressing review feedback, remember to publish your drafts!

Contributor

gopherbot commented Jul 23, 2019

Message from Bryan C. Mills:

Patch Set 2: Run-TryBot+1 Code-Review+2

Please don’t reply on this GitHub thread. Visit golang.org/cl/187217.
After addressing review feedback, remember to publish your drafts!

Contributor

gopherbot commented Jul 23, 2019

Message from Gobot Gobot:

Patch Set 2:

TryBots beginning. Status page: https://farmer.golang.org/try?commit=55ae98a0

Please don’t reply on this GitHub thread. Visit golang.org/cl/187217.
After addressing review feedback, remember to publish your drafts!

Contributor

gopherbot commented Jul 23, 2019

Message from Gobot Gobot:

Patch Set 2: TryBot-Result+1

TryBots are happy.

Please don’t reply on this GitHub thread. Visit golang.org/cl/187217.
After addressing review feedback, remember to publish your drafts!

gopherbot pushed a commit that referenced this pull request


          cmd/go: keep "go help" in unknown topic suggestion

68e2899

Fixed missing concatenation to build the suggested command.

Fixes #33153

Change-Id: I26c02f2966247aa07d1447b8ec1a2203046842dd
GitHub-Last-Rev: 9631abf
GitHub-Pull-Request: #33245
Reviewed-on: https://go-review.googlesource.com/c/go/+/187217
Reviewed-by: Bryan C. Mills <[email protected]>
Run-TryBot: Bryan C. Mills <[email protected]>
TryBot-Result: Gobot Gobot <[email protected]>

Contributor

gopherbot commented Jul 23, 2019

This PR is being closed because golang.org/cl/187217 has been merged.

gopherbot closed this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels